[PATCH v2] cdrom: Fix typo, 'devicen' to 'device'

[PATCH v2] cdrom: Fix typo, 'devicen' to 'device'

[Steven Davis]

Nothing big here, just a typo that really bugged me. :)

I assume whoever wrote this was trying to make a new
line, so I went ahead and put a back slash in it.

Signed-off-by: Steven Davis <goldside000@outlook.com>
---
V1 -> V2: Add directory I changed to subject

 drivers/cdrom/cdrom.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/cdrom/cdrom.c b/drivers/cdrom/cdrom.c
index 6a99a459b..2863e5db2 100644
--- a/drivers/cdrom/cdrom.c
+++ b/drivers/cdrom/cdrom.c
@@ -1106,7 +1106,7 @@ int open_for_data(struct cdrom_device_info *cdi)
 		}
 	}
 
-	cd_dbg(CD_OPEN, "all seems well, opening the devicen");
+	cd_dbg(CD_OPEN, "all seems well, opening the device\n");
 
 	/* all seems well, we can open the device */
 	ret = cdo->open(cdi, 0); /* open for data */
-- 
2.39.5

Re: [PATCH v2] cdrom: Fix typo, 'devicen' to 'device'

[Phillip Potter]

On Sun, Dec 29, 2024 at 04:57:54PM +0000, Steven Davis wrote:
> Nothing big here, just a typo that really bugged me. :)
> 
> I assume whoever wrote this was trying to make a new
> line, so I went ahead and put a back slash in it.
> 
> Signed-off-by: Steven Davis <goldside000@outlook.com>
> ---
> V1 -> V2: Add directory I changed to subject
> 
>  drivers/cdrom/cdrom.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/cdrom/cdrom.c b/drivers/cdrom/cdrom.c
> index 6a99a459b..2863e5db2 100644
> --- a/drivers/cdrom/cdrom.c
> +++ b/drivers/cdrom/cdrom.c
> @@ -1106,7 +1106,7 @@ int open_for_data(struct cdrom_device_info *cdi)
>  		}
>  	}
>  
> -	cd_dbg(CD_OPEN, "all seems well, opening the devicen");
> +	cd_dbg(CD_OPEN, "all seems well, opening the device\n");
>  
>  	/* all seems well, we can open the device */
>  	ret = cdo->open(cdi, 0); /* open for data */
> -- 
> 2.39.5
> 

Hi Steven,

Thank you for the patch, looks good to me. I will forward onto Jens for
inclusion upstream.

Reviewed-by: Phillip Potter <phil@philpotter.co.uk>

On another note though: The raw patch submission e-mail body seems to have
some encoding issues, evidenced by the presence of extra content on empty
lines:
=20
-	cd_dbg(CD_OPEN, "all seems well, opening the devicen");
+	cd_dbg(CD_OPEN, "all seems well, opening the device\n");
=20

Also, it triggers checkpatch for the same reason:
ERROR: patch seems to be corrupt (line wrapped?)
#165: FILE: drivers/cdrom/cdrom.c:1107:
=20

total: 1 errors, 0 warnings, 11 lines checked

In this instance, happy to send on from yourself with this corrected,
but please do look into why this is happening - it is possibly related
to your e-mail client.

Many thanks.

Regards,
Phil

Re: [PATCH v2] cdrom: Fix typo, 'devicen' to 'device'

[Steven Davis]

On Sun, Dec 29, 2024 at 18:32:57 +0000, Phillip Potter wrote:
> On another note though: The raw patch submission e-mail body seems to have
> some encoding issues, evidenced by the presence of extra content on empty
> lines:
> =20
> -	cd_dbg(CD_OPEN, "all seems well, opening the devicen");
> +	cd_dbg(CD_OPEN, "all seems well, opening the device\n");
> =20
>
> Also, it triggers checkpatch for the same reason:
> ERROR: patch seems to be corrupt (line wrapped?)
> #165: FILE: drivers/cdrom/cdrom.c:1107:
> =20
>
> total: 1 errors, 0 warnings, 11 lines checked
> In this instance, happy to send on from yourself with this corrected,
> but please do look into why this is happening - it is possibly related
> to your e-mail client.

That's strange, I've been using git send-email, and that's the first time
that's ever happened. I ran checkpatch before I sent it, and it didn't say
anything.

I thank you for accepting my patch, nonetheless!

	Steven

Re: [PATCH v2] cdrom: Fix typo, 'devicen' to 'device'

[Phillip Potter]

On Sun, Dec 29, 2024 at 06:43:20PM +0000, Steven Davis wrote:
> 
> That's strange, I've been using git send-email, and that's the first time
> that's ever happened. I ran checkpatch before I sent it, and it didn't say
> anything.
> 
> I thank you for accepting my patch, nonetheless!
> 
> 	Steven

No problem :-)

Yeah to rule out it being my side, I also checked the raw submission on
lore.kernel.org:
https://lore.kernel.org/lkml/20241229165744.21725-1-goldside000@outlook.com/raw

The extra characters are visible there as well.

Regards,
Phil

Re: [PATCH v2] cdrom: Fix typo, 'devicen' to 'device'

[Steven Davis]

On Sun, Dec 29, 2024 at 18:32:57 +0000, Phillip Potter wrote:
> Yeah to rule out it being my side, I also checked the raw submission on
> lore.kernel.org:
> https://lore.kernel.org/lkml/20241229165744.21725-1-goldside000@outlook.com/raw
>
> The extra characters are visible there as well.

Huh. Maybe I've got a buggy version of git send-email or something. I'll
see what's going on with it when I get a chance.

	Steven