From: Peter Zijlstra <peterz@infradead.org>
To: Doug Smythies <dsmythies@telus.net>
Cc: linux-kernel@vger.kernel.org, vincent.guittot@linaro.org
Subject: Re: [REGRESSION] Re: [PATCH 00/24] Complete EEVDF
Date: Mon, 6 Jan 2025 12:57:32 +0100 [thread overview]
Message-ID: <20250106115732.GE20870@noisy.programming.kicks-ass.net> (raw)
In-Reply-To: <005f01db5a44$3bb698e0$b323caa0$@telus.net>
On Sun, Dec 29, 2024 at 02:51:43PM -0800, Doug Smythies wrote:
> Hi Peter,
>
> I have been having trouble with turbostat reporting processor package power levels that can not possibly be true.
> After eliminating the turbostat program itself as the source of the issue I bisected the kernel.
> An edited summary (actual log attached):
>
> 82e9d0456e06 sched/fair: Avoid re-setting virtual deadline on 'migrations'
> b10 bad fc1892becd56 sched/eevdf: Fixup PELT vs DELAYED_DEQUEUE
> b13 bad 54a58a787791 sched/fair: Implement DELAY_ZERO
> skip 152e11f6df29 sched/fair: Implement delayed dequeue
> skip e1459a50ba31 sched: Teach dequeue_task() about special task states
> skip a1c446611e31 sched,freezer: Mark TASK_FROZEN special
> skip 781773e3b680 sched/fair: Implement ENQUEUE_DELAYED
> skip f12e148892ed sched/fair: Prepare pick_next_task() for delayed dequeue
> skip 2e0199df252a sched/fair: Prepare exit/cleanup paths for delayed_dequeue
> b12 good e28b5f8bda01 sched/fair: Assert {set_next,put_prev}_entity() are properly balanced
> dfa0a574cbc4 sched/uclamg: Handle delayed dequeue
> b11 good abc158c82ae5 sched: Prepare generic code for delayed dequeue
> e8901061ca0c sched: Split DEQUEUE_SLEEP from deactivate_task()
>
> Where "bN" is just my assigned kernel name for each bisection step.
>
> In the linux-kernel email archives I found a thread that isolated these same commits.
> It was from late Novermebr / early December:
>
> https://lore.kernel.org/all/20240727105030.226163742@infradead.org/T/#m9aeb4d897e029cf7546513bb09499c320457c174
>
> An example of the turbostat manifestation of the issue:
>
> doug@s19:~$ sudo ~/kernel/linux/tools/power/x86/turbostat/turbostat --quiet --Summary --show
> Busy%,Bzy_MHz,IRQ,PkgWatt,PkgTmp,TSC_MHz --interval 1
> [sudo] password for doug:
> Busy% Bzy_MHz TSC_MHz IRQ PkgTmp PkgWatt
> 99.76 4800 4104 12304 73 80.08
> 99.76 4800 4104 12047 73 80.23
> 99.76 4800 879 12157 73 11.40
> 99.76 4800 26667 84214 72 557.23
> 99.76 4800 4104 12036 72 79.39
>
> Where TSC_MHz was reported as 879, there was a big gap in time.
> Like 4.7 seconds instead of 1.
> Where TSC_MHz was reported as 26667, there was not a big gap in time.
>
> It happens for about 5% of the samples + or - a lot.
> It only happens when the workload is almost exactly 100%.
> More load, it doesn't occur.
> Less load, it doesn't occur. Although, I did get this once:
>
> Busy% Bzy_MHz TSC_MHz IRQ PkgTmp PkgWatt
> 91.46 4800 4104 11348 73 103.98
> 91.46 4800 4104 11353 73 103.89
> 91.50 4800 3903 11339 73 98.16
> 91.43 4800 4271 12001 73 108.52
> 91.45 4800 4148 11481 73 105.13
> 91.46 4800 4104 11341 73 103.96
> 91.46 4800 4104 11348 73 103.99
>
> So, it might just be much less probable and less severe.
>
> It happens over many different types of workload that I have tried.
In private email you've communicated it happens due to
sched_setaffinity() sometimes taking multiple seconds.
I'm trying to reproduce by starting a bash 'while ;: do :; done' spinner
for each CPU, but so far am not able to reproduce.
What is the easiest 100% load you're seeing this with?
next prev parent reply other threads:[~2025-01-06 11:57 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-29 22:51 Doug Smythies
2025-01-06 11:57 ` Peter Zijlstra [this message]
2025-01-06 15:01 ` Doug Smythies
2025-01-06 16:59 ` Peter Zijlstra
2025-01-06 17:04 ` Peter Zijlstra
2025-01-06 17:14 ` Peter Zijlstra
2025-01-07 1:24 ` Doug Smythies
2025-01-07 10:49 ` Peter Zijlstra
2025-01-06 22:28 ` Doug Smythies
2025-01-07 11:26 ` Peter Zijlstra
2025-01-07 15:04 ` Doug Smythies
2025-01-07 16:25 ` Doug Smythies
2025-01-07 19:23 ` Peter Zijlstra
2025-01-08 5:15 ` Doug Smythies
2025-01-08 13:12 ` Peter Zijlstra
2025-01-08 15:48 ` Doug Smythies
2025-01-09 10:59 ` Peter Zijlstra
2025-01-09 12:18 ` [tip: sched/urgent] sched/fair: Fix EEVDF entity placement bug causing scheduling lag tip-bot2 for Peter Zijlstra
2025-04-17 9:56 ` Alexander Egorenkov
2025-04-22 5:40 ` ll"RE: " Doug Smythies
2025-04-24 7:56 ` Alexander Egorenkov
2025-04-26 15:09 ` Doug Smythies
2025-01-10 5:09 ` [REGRESSION] Re: [PATCH 00/24] Complete EEVDF Doug Smythies
2025-01-10 11:57 ` Peter Zijlstra
2025-01-12 23:14 ` Doug Smythies
2025-01-13 11:03 ` Peter Zijlstra
2025-01-14 10:58 ` Peter Zijlstra
2025-01-14 15:15 ` Doug Smythies
2025-01-15 2:08 ` Len Brown
2025-01-15 16:47 ` Doug Smythies
2025-01-19 0:09 ` Doug Smythies
2025-01-20 3:55 ` Doug Smythies
2025-01-21 11:06 ` Peter Zijlstra
2025-01-21 8:49 ` Peter Zijlstra
2025-01-21 11:21 ` Peter Zijlstra
2025-01-21 15:58 ` Doug Smythies
2025-01-24 4:34 ` Doug Smythies
2025-01-24 11:04 ` Peter Zijlstra
2025-01-13 11:05 ` Peter Zijlstra
2025-01-13 16:01 ` Doug Smythies
2025-01-13 12:58 ` [tip: sched/urgent] sched/fair: Fix update_cfs_group() vs DELAY_DEQUEUE tip-bot2 for Peter Zijlstra
2025-01-12 19:59 ` [REGRESSION] Re: [PATCH 00/24] Complete EEVDF Doug Smythies
-- strict thread matches above, loose matches on Subject: below --
2024-07-27 10:27 Peter Zijlstra
2024-11-28 10:32 ` [REGRESSION] " Marcel Ziswiler
2024-11-28 10:58 ` Peter Zijlstra
2024-11-28 11:37 ` Marcel Ziswiler
2024-11-29 9:08 ` Peter Zijlstra
2024-12-02 18:46 ` Marcel Ziswiler
2024-12-09 9:49 ` Peter Zijlstra
2024-12-10 16:05 ` Marcel Ziswiler
2024-12-10 16:13 ` Steven Rostedt
2024-12-10 8:45 ` Luis Machado
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250106115732.GE20870@noisy.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=dsmythies@telus.net \
--cc=linux-kernel@vger.kernel.org \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome