* [PATCH] arm64: dts: ti: k3-j784s4-evm:quad-port-eth-exp1: Remove duplicate hogs
@ 2025-01-10 10:18 Jayesh Choudhary
2025-01-10 10:45 ` Siddharth Vadapalli
0 siblings, 1 reply; 3+ messages in thread
From: Jayesh Choudhary @ 2025-01-10 10:18 UTC (permalink / raw)
To: nm, vigneshr, kristo, robh, krzk+dt, conor+dt, devicetree
Cc: linux-kernel, linux-arm-kernel, s-vadapalli, c-vankar, j-choudhary
The j784s4-evm board dts now has the gpio hogs for MUX2 after integration
of audio support.
Remove duplicate gpio-hogs from the overlay dtso to prevent mux probe
failures leading to can-phy3 deferred probe:
'gpio-mux mux-controller: probe with driver gpio-mux failed with error -16'
Signed-off-by: Jayesh Choudhary <j-choudhary@ti.com>
---
GPIO 13 and 15 are set to high in k3-j784s4-evm.dts in exp2 node
as gpio-hog and GPIO 14 is set to high using idle-state in mux1 node.
Log with probe issue:
<https://gist.github.com/Jayesh2000/861ba647dfaec2dd8ed745a5b8d002e4>
Log with this fix:
<https://gist.github.com/Jayesh2000/73d59504d52a36bb31fe49a4faae2693>
.../boot/dts/ti/k3-j784s4-evm-quad-port-eth-exp1.dtso | 7 -------
1 file changed, 7 deletions(-)
diff --git a/arch/arm64/boot/dts/ti/k3-j784s4-evm-quad-port-eth-exp1.dtso b/arch/arm64/boot/dts/ti/k3-j784s4-evm-quad-port-eth-exp1.dtso
index dcd2c7c39ec3..c1f9573557d0 100644
--- a/arch/arm64/boot/dts/ti/k3-j784s4-evm-quad-port-eth-exp1.dtso
+++ b/arch/arm64/boot/dts/ti/k3-j784s4-evm-quad-port-eth-exp1.dtso
@@ -102,13 +102,6 @@ qsgmii-line-hog {
gpios = <16 GPIO_ACTIVE_HIGH>;
output-low;
};
-
- /* Toggle MUX2 for MDIO lines */
- mux-sel-hog {
- gpio-hog;
- gpios = <13 GPIO_ACTIVE_HIGH>, <14 GPIO_ACTIVE_HIGH>, <15 GPIO_ACTIVE_HIGH>;
- output-high;
- };
};
&main_pmx0 {
--
2.34.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] arm64: dts: ti: k3-j784s4-evm:quad-port-eth-exp1: Remove duplicate hogs
2025-01-10 10:18 [PATCH] arm64: dts: ti: k3-j784s4-evm:quad-port-eth-exp1: Remove duplicate hogs Jayesh Choudhary
@ 2025-01-10 10:45 ` Siddharth Vadapalli
2025-01-10 10:50 ` Jayesh Choudhary
0 siblings, 1 reply; 3+ messages in thread
From: Siddharth Vadapalli @ 2025-01-10 10:45 UTC (permalink / raw)
To: Jayesh Choudhary
Cc: nm, vigneshr, kristo, robh, krzk+dt, conor+dt, devicetree,
linux-kernel, linux-arm-kernel, s-vadapalli, c-vankar
On Fri, Jan 10, 2025 at 03:48:55PM +0530, Jayesh Choudhary wrote:
Hello Jayesh,
In the $subject of this patch, please use the overlay name as-is instead
of adding the colon which splits the overlay name:
s/k3-j784s4-evm:quad-port-eth-exp1/k3-j784s4-evm-quad-port-eth-exp1
> The j784s4-evm board dts now has the gpio hogs for MUX2 after integration
> of audio support.
> Remove duplicate gpio-hogs from the overlay dtso to prevent mux probe
> failures leading to can-phy3 deferred probe:
> 'gpio-mux mux-controller: probe with driver gpio-mux failed with error -16'
This appears to be a fix since overlay functionality was broken since
the commit which introduced audio support. Please add a "Fixes" tag
to indicate this.
>
> Signed-off-by: Jayesh Choudhary <j-choudhary@ti.com>
With the above comments addressed,
Reviewed-by: Siddharth Vadapalli <s-vadapalli@ti.com>
Regards,
Siddharth.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] arm64: dts: ti: k3-j784s4-evm:quad-port-eth-exp1: Remove duplicate hogs
2025-01-10 10:45 ` Siddharth Vadapalli
@ 2025-01-10 10:50 ` Jayesh Choudhary
0 siblings, 0 replies; 3+ messages in thread
From: Jayesh Choudhary @ 2025-01-10 10:50 UTC (permalink / raw)
To: Siddharth Vadapalli
Cc: nm, vigneshr, kristo, robh, krzk+dt, conor+dt, devicetree,
linux-kernel, linux-arm-kernel, c-vankar
Hello Siddharth,
Thank you for the review.
On 10/01/25 16:15, Siddharth Vadapalli wrote:
> On Fri, Jan 10, 2025 at 03:48:55PM +0530, Jayesh Choudhary wrote:
>
> Hello Jayesh,
>
> In the $subject of this patch, please use the overlay name as-is instead
> of adding the colon which splits the overlay name:
> s/k3-j784s4-evm:quad-port-eth-exp1/k3-j784s4-evm-quad-port-eth-exp1
I will fix this typo.
>
>> The j784s4-evm board dts now has the gpio hogs for MUX2 after integration
>> of audio support.
>> Remove duplicate gpio-hogs from the overlay dtso to prevent mux probe
>> failures leading to can-phy3 deferred probe:
>> 'gpio-mux mux-controller: probe with driver gpio-mux failed with error -16'
>
> This appears to be a fix since overlay functionality was broken since
> the commit which introduced audio support. Please add a "Fixes" tag
> to indicate this.
>
Will add it in v2.
Warm Regards,
Jayesh
>>
>> Signed-off-by: Jayesh Choudhary <j-choudhary@ti.com>
>
> With the above comments addressed,
>
> Reviewed-by: Siddharth Vadapalli <s-vadapalli@ti.com>
>
> Regards,
> Siddharth.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-01-10 10:50 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-01-10 10:18 [PATCH] arm64: dts: ti: k3-j784s4-evm:quad-port-eth-exp1: Remove duplicate hogs Jayesh Choudhary
2025-01-10 10:45 ` Siddharth Vadapalli
2025-01-10 10:50 ` Jayesh Choudhary
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®