From: Niklas Cassel <cassel@kernel.org>
To: "Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Manivannan Sadhasivam" <manivannan.sadhasivam@linaro.org>,
"Rob Herring" <robh@kernel.org>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Heiko Stuebner" <heiko@sntech.de>
Cc: Damien Le Moal <dlemoal@kernel.org>,
Anand Moon <linux.amoon@gmail.com>,
linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org,
linux-kernel@vger.kernel.org, Niklas Cassel <cassel@kernel.org>
Subject: [PATCH] PCI: dw-rockchip: Skip waiting for link up
Date: Mon, 13 Jan 2025 11:59:34 +0100 [thread overview]
Message-ID: <20250113-rockchip-no-wait-v1-1-25417f37b92f@kernel.org> (raw)
The Root Complex specific device tree binding for pcie-dw-rockchip has the
'sys' interrupt marked as required.
The driver requests the 'sys' IRQ unconditionally, and errors out if not
provided.
Thus, we can unconditionally set use_linkup_irq before calling
dw_pcie_host_init().
This will skip the wait for link up (since the bus will be enumerated once
the link up IRQ is triggered), which reduces the bootup time.
Signed-off-by: Niklas Cassel <cassel@kernel.org>
---
drivers/pci/controller/dwc/pcie-dw-rockchip.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/pci/controller/dwc/pcie-dw-rockchip.c b/drivers/pci/controller/dwc/pcie-dw-rockchip.c
index 1170e1107508bd793b610949b0afe98516c177a4..62034affb95fbb965aad3cebc613a83e31c90aee 100644
--- a/drivers/pci/controller/dwc/pcie-dw-rockchip.c
+++ b/drivers/pci/controller/dwc/pcie-dw-rockchip.c
@@ -435,6 +435,7 @@ static int rockchip_pcie_configure_rc(struct rockchip_pcie *rockchip)
pp = &rockchip->pci.pp;
pp->ops = &rockchip_pcie_host_ops;
+ pp->use_linkup_irq = true;
return dw_pcie_host_init(pp);
}
---
base-commit: 2adda4102931b152f35d054055497631ed97fe73
change-id: 20250113-rockchip-no-wait-403ffbc42313
Best regards,
--
Niklas Cassel <cassel@kernel.org>
next reply other threads:[~2025-01-13 10:59 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-13 10:59 Niklas Cassel [this message]
2025-01-13 19:27 ` Bjorn Helgaas
2025-01-13 21:14 ` Niklas Cassel
2025-01-13 20:22 ` Bjorn Helgaas
2025-10-21 4:26 ` FUKAUMI Naoki
2025-10-21 7:10 ` Shawn Lin
2025-11-08 12:34 ` Niklas Cassel
2025-11-08 13:27 ` Niklas Cassel
2025-11-08 14:21 ` Diederik de Haas
2025-11-09 4:42 ` FUKAUMI Naoki
2025-11-09 12:28 ` Niklas Cassel
2025-11-09 23:16 ` FUKAUMI Naoki
2025-11-09 23:26 ` [RESEND] " FUKAUMI Naoki
2025-11-10 2:30 ` Shawn Lin
2025-11-10 4:56 ` FUKAUMI Naoki
2025-11-10 7:12 ` Shawn Lin
2025-11-10 7:52 ` FUKAUMI Naoki
2025-11-10 10:15 ` Shawn Lin
2025-11-10 12:34 ` Niklas Cassel
2025-11-10 12:41 ` Niklas Cassel
2025-11-10 15:21 ` FUKAUMI Naoki
2025-11-10 15:37 ` Manivannan Sadhasivam
2025-11-10 15:53 ` Manivannan Sadhasivam
2025-11-10 19:59 ` Niklas Cassel
2025-11-10 22:14 ` FUKAUMI Naoki
2025-11-11 2:09 ` FUKAUMI Naoki
2025-11-11 3:17 ` Shawn Lin
2025-11-11 14:00 ` Niklas Cassel
2025-11-11 1:11 ` Shawn Lin
2025-11-10 11:24 ` Manivannan Sadhasivam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250113-rockchip-no-wait-v1-1-25417f37b92f@kernel.org \
--to=cassel@kernel.org \
--cc=bhelgaas@google.com \
--cc=dlemoal@kernel.org \
--cc=heiko@sntech.de \
--cc=kw@linux.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux.amoon@gmail.com \
--cc=lpieralisi@kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®