mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH v1 1/1] mfd: intel_soc_pmic_crc: Drop unneeded assignment for cache_type
@ 2025-01-29 15:28 Andy Shevchenko
  2025-01-29 16:36 ` Hans de Goede
  2025-02-10 17:35 ` (subset) " Lee Jones
  0 siblings, 2 replies; 3+ messages in thread
From: Andy Shevchenko @ 2025-01-29 15:28 UTC (permalink / raw)
  To: Andy Shevchenko, Hans de Goede, Lee Jones, linux-kernel; +Cc: Andy Shevchenko

REGCACHE_NONE is the default type of the cache when not provided.
Drop unneeded explicit assignment to it.

Note, it's defined to 0, and if ever be redefined, it will break
literally a lot of the drivers, so it very unlikely to happen.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/mfd/intel_soc_pmic_crc.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/mfd/intel_soc_pmic_crc.c b/drivers/mfd/intel_soc_pmic_crc.c
index 879fbf5cd162..41429f9bcb69 100644
--- a/drivers/mfd/intel_soc_pmic_crc.c
+++ b/drivers/mfd/intel_soc_pmic_crc.c
@@ -113,7 +113,6 @@ static const struct regmap_config crystal_cove_regmap_config = {
 	.val_bits = 8,
 
 	.max_register = CRYSTAL_COVE_MAX_REGISTER,
-	.cache_type = REGCACHE_NONE,
 };
 
 static const struct regmap_irq crystal_cove_irqs[] = {
-- 
2.43.0.rc1.1336.g36b5255a03ac


^ permalink raw reply	[flat|nested] 3+ messages in thread
* Re: [PATCH v1 1/1] mfd: intel_soc_pmic_crc: Drop unneeded assignment for cache_type
  2025-01-29 15:28 [PATCH v1 1/1] mfd: intel_soc_pmic_crc: Drop unneeded assignment for cache_type Andy Shevchenko
@ 2025-01-29 16:36 ` Hans de Goede
  2025-02-10 17:35 ` (subset) " Lee Jones
  1 sibling, 0 replies; 3+ messages in thread
From: Hans de Goede @ 2025-01-29 16:36 UTC (permalink / raw)
  To: Andy Shevchenko, Lee Jones, linux-kernel; +Cc: Andy Shevchenko

Hi,

On 29-Jan-25 4:28 PM, Andy Shevchenko wrote:
> REGCACHE_NONE is the default type of the cache when not provided.
> Drop unneeded explicit assignment to it.
> 
> Note, it's defined to 0, and if ever be redefined, it will break
> literally a lot of the drivers, so it very unlikely to happen.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

Thanks, patch looks good to me:

Reviewed-by: Hans de Goede <hdegoede@redhat.com>

Regards,

Hans



> ---
>  drivers/mfd/intel_soc_pmic_crc.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/mfd/intel_soc_pmic_crc.c b/drivers/mfd/intel_soc_pmic_crc.c
> index 879fbf5cd162..41429f9bcb69 100644
> --- a/drivers/mfd/intel_soc_pmic_crc.c
> +++ b/drivers/mfd/intel_soc_pmic_crc.c
> @@ -113,7 +113,6 @@ static const struct regmap_config crystal_cove_regmap_config = {
>  	.val_bits = 8,
>  
>  	.max_register = CRYSTAL_COVE_MAX_REGISTER,
> -	.cache_type = REGCACHE_NONE,
>  };
>  
>  static const struct regmap_irq crystal_cove_irqs[] = {


^ permalink raw reply	[flat|nested] 3+ messages in thread
* Re: (subset) [PATCH v1 1/1] mfd: intel_soc_pmic_crc: Drop unneeded assignment for cache_type
  2025-01-29 15:28 [PATCH v1 1/1] mfd: intel_soc_pmic_crc: Drop unneeded assignment for cache_type Andy Shevchenko
  2025-01-29 16:36 ` Hans de Goede
@ 2025-02-10 17:35 ` Lee Jones
  1 sibling, 0 replies; 3+ messages in thread
From: Lee Jones @ 2025-02-10 17:35 UTC (permalink / raw)
  To: Hans de Goede, Lee Jones, linux-kernel, Andy Shevchenko; +Cc: Andy Shevchenko

On Wed, 29 Jan 2025 17:28:28 +0200, Andy Shevchenko wrote:
> REGCACHE_NONE is the default type of the cache when not provided.
> Drop unneeded explicit assignment to it.
> 
> Note, it's defined to 0, and if ever be redefined, it will break
> literally a lot of the drivers, so it very unlikely to happen.
> 
> 
> [...]

Applied, thanks!

[1/1] mfd: intel_soc_pmic_crc: Drop unneeded assignment for cache_type
      commit: 0b1cfd51841c69c024facfe59ea7bbe6b589a7de

--
Lee Jones [李琼斯]


^ permalink raw reply	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-02-10 17:35 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-01-29 15:28 [PATCH v1 1/1] mfd: intel_soc_pmic_crc: Drop unneeded assignment for cache_type Andy Shevchenko
2025-01-29 16:36 ` Hans de Goede
2025-02-10 17:35 ` (subset) " Lee Jones

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®