From: James Clark <james.clark@linaro.org>
To: lcherian@marvell.com, coresight@lists.linaro.org
Cc: James Clark <james.clark@linaro.org>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
Mike Leach <mike.leach@linaro.org>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com
Subject: [PATCH 1/7] coresight: Rename coresight_{set,clear}_claim_tags()
Date: Tue, 11 Feb 2025 10:39:37 +0000 [thread overview]
Message-ID: <20250211103945.967495-2-james.clark@linaro.org> (raw)
In-Reply-To: <20250211103945.967495-1-james.clark@linaro.org>
These look like they set the whole tags register as one value, but they
only set and clear the self hosted bit using a SET/CLR bits mechanism.
Rename the functions to reflect this better.
Signed-off-by: James Clark <james.clark@linaro.org>
---
drivers/hwtracing/coresight/coresight-core.c | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/hwtracing/coresight/coresight-core.c b/drivers/hwtracing/coresight/coresight-core.c
index 0a9380350fb5..523dbb381f90 100644
--- a/drivers/hwtracing/coresight/coresight-core.c
+++ b/drivers/hwtracing/coresight/coresight-core.c
@@ -142,14 +142,14 @@ static inline bool coresight_is_claimed_any(struct coresight_device *csdev)
return coresight_read_claim_tags(csdev) != 0;
}
-static inline void coresight_set_claim_tags(struct coresight_device *csdev)
+static inline void coresight_set_self_claim_tag(struct coresight_device *csdev)
{
csdev_access_relaxed_write32(&csdev->access, CORESIGHT_CLAIM_SELF_HOSTED,
CORESIGHT_CLAIMSET);
isb();
}
-static inline void coresight_clear_claim_tags(struct coresight_device *csdev)
+static inline void coresight_clear_self_claim_tag(struct coresight_device *csdev)
{
csdev_access_relaxed_write32(&csdev->access, CORESIGHT_CLAIM_SELF_HOSTED,
CORESIGHT_CLAIMCLR);
@@ -174,11 +174,11 @@ int coresight_claim_device_unlocked(struct coresight_device *csdev)
if (coresight_is_claimed_any(csdev))
return -EBUSY;
- coresight_set_claim_tags(csdev);
+ coresight_set_self_claim_tag(csdev);
if (coresight_is_claimed_self_hosted(csdev))
return 0;
- /* There was a race setting the tags, clean up and fail */
- coresight_clear_claim_tags(csdev);
+ /* There was a race setting the tag, clean up and fail */
+ coresight_clear_self_claim_tag(csdev);
return -EBUSY;
}
EXPORT_SYMBOL_GPL(coresight_claim_device_unlocked);
@@ -199,7 +199,7 @@ int coresight_claim_device(struct coresight_device *csdev)
EXPORT_SYMBOL_GPL(coresight_claim_device);
/*
- * coresight_disclaim_device_unlocked : Clear the claim tags for the device.
+ * coresight_disclaim_device_unlocked : Clear the claim tag for the device.
* Called with CS_UNLOCKed for the component.
*/
void coresight_disclaim_device_unlocked(struct coresight_device *csdev)
@@ -209,7 +209,7 @@ void coresight_disclaim_device_unlocked(struct coresight_device *csdev)
return;
if (coresight_is_claimed_self_hosted(csdev))
- coresight_clear_claim_tags(csdev);
+ coresight_clear_self_claim_tag(csdev);
else
/*
* The external agent may have not honoured our claim
--
2.34.1
next prev parent reply other threads:[~2025-02-11 10:40 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-11 10:39 [PATCH 0/7] coresight: Clear self hosted claim tag on probe James Clark
2025-02-11 10:39 ` James Clark [this message]
2025-03-13 11:24 ` [PATCH 1/7] coresight: Rename coresight_{set,clear}_claim_tags() Leo Yan
2025-02-11 10:39 ` [PATCH 2/7] coresight: Convert disclaim functions to take a struct cs_access James Clark
2025-03-13 14:54 ` Leo Yan
2025-03-17 11:36 ` James Clark
2025-03-17 18:29 ` Leo Yan
2025-03-18 9:27 ` James Clark
2025-02-11 10:39 ` [PATCH 3/7] coresight: Only check bottom two claim bits James Clark
2025-03-13 11:46 ` Leo Yan
2025-02-11 10:39 ` [PATCH 4/7] coresight: Add claim tag warnings and debug messages James Clark
2025-03-13 14:40 ` Leo Yan
2025-03-17 11:56 ` James Clark
2025-02-11 10:39 ` [PATCH 5/7] coresight: Clear self hosted claim tag on probe James Clark
2025-02-12 18:24 ` Mike Leach
2025-02-13 13:20 ` James Clark
2025-03-13 16:04 ` Leo Yan
2025-03-17 15:05 ` James Clark
2025-03-17 18:09 ` Leo Yan
2025-02-11 10:39 ` [PATCH 6/7] coresight: Remove inlines from static function definitions James Clark
2025-03-14 9:50 ` Leo Yan
2025-03-17 15:26 ` James Clark
2025-03-17 17:45 ` Leo Yan
2025-02-11 10:39 ` [PATCH 7/7] coresight: Remove extern from function declarations James Clark
2025-03-13 16:17 ` Leo Yan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250211103945.967495-2-james.clark@linaro.org \
--to=james.clark@linaro.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=alexandre.torgue@foss.st.com \
--cc=coresight@lists.linaro.org \
--cc=lcherian@marvell.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=mike.leach@linaro.org \
--cc=suzuki.poulose@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®