From: James Clark <james.clark@linaro.org>
To: Leo Yan <leo.yan@arm.com>
Cc: lcherian@marvell.com, coresight@lists.linaro.org,
Mike Leach <mike.leach@linaro.org>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com
Subject: Re: [PATCH 2/7] coresight: Convert disclaim functions to take a struct cs_access
Date: Mon, 17 Mar 2025 11:36:40 +0000 [thread overview]
Message-ID: <c6a86373-64be-4101-a08a-74aa302bf64c@linaro.org> (raw)
In-Reply-To: <20250313145456.GR9682@e132581.arm.com>
On 13/03/2025 2:54 pm, Leo Yan wrote:
> On Tue, Feb 11, 2025 at 10:39:38AM +0000, James Clark wrote:
>
> [...]
>
>> static inline bool coresight_is_claimed_any(struct coresight_device *csdev)
>> {
>> - return coresight_read_claim_tags(csdev) != 0;
>> + return coresight_read_claim_tags(&csdev->access) != 0;
>> }
>
> Likewise other claim functions, can coresight_is_claimed_any() change its
> argument type from struct coresight_device to struct csdev_access?
>
> Thanks,
> Leo
I only wanted to change the ones that I had to. I think we should
prioritize passing csdev as much as possible in the coresight framework
to make everything consistent. Otherwise it's extra churn for no
benefit, and if we need something from csdev here in the future we'll
have to change this one back again.
next prev parent reply other threads:[~2025-03-17 11:36 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-11 10:39 [PATCH 0/7] coresight: Clear self hosted claim tag on probe James Clark
2025-02-11 10:39 ` [PATCH 1/7] coresight: Rename coresight_{set,clear}_claim_tags() James Clark
2025-03-13 11:24 ` Leo Yan
2025-02-11 10:39 ` [PATCH 2/7] coresight: Convert disclaim functions to take a struct cs_access James Clark
2025-03-13 14:54 ` Leo Yan
2025-03-17 11:36 ` James Clark [this message]
2025-03-17 18:29 ` Leo Yan
2025-03-18 9:27 ` James Clark
2025-02-11 10:39 ` [PATCH 3/7] coresight: Only check bottom two claim bits James Clark
2025-03-13 11:46 ` Leo Yan
2025-02-11 10:39 ` [PATCH 4/7] coresight: Add claim tag warnings and debug messages James Clark
2025-03-13 14:40 ` Leo Yan
2025-03-17 11:56 ` James Clark
2025-02-11 10:39 ` [PATCH 5/7] coresight: Clear self hosted claim tag on probe James Clark
2025-02-12 18:24 ` Mike Leach
2025-02-13 13:20 ` James Clark
2025-03-13 16:04 ` Leo Yan
2025-03-17 15:05 ` James Clark
2025-03-17 18:09 ` Leo Yan
2025-02-11 10:39 ` [PATCH 6/7] coresight: Remove inlines from static function definitions James Clark
2025-03-14 9:50 ` Leo Yan
2025-03-17 15:26 ` James Clark
2025-03-17 17:45 ` Leo Yan
2025-02-11 10:39 ` [PATCH 7/7] coresight: Remove extern from function declarations James Clark
2025-03-13 16:17 ` Leo Yan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c6a86373-64be-4101-a08a-74aa302bf64c@linaro.org \
--to=james.clark@linaro.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=alexandre.torgue@foss.st.com \
--cc=coresight@lists.linaro.org \
--cc=lcherian@marvell.com \
--cc=leo.yan@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=mike.leach@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®