mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: James Clark <james.clark@linaro.org>
To: Leo Yan <leo.yan@arm.com>
Cc: lcherian@marvell.com, coresight@lists.linaro.org,
	Mike Leach <mike.leach@linaro.org>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Maxime Coquelin <mcoquelin.stm32@gmail.com>,
	Alexandre Torgue <alexandre.torgue@foss.st.com>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	linux-stm32@st-md-mailman.stormreply.com
Subject: Re: [PATCH 6/7] coresight: Remove inlines from static function definitions
Date: Mon, 17 Mar 2025 15:26:42 +0000	[thread overview]
Message-ID: <9d06b27a-c2ce-41b8-9657-151000c0b244@linaro.org> (raw)
In-Reply-To: <20250314095025.GW9682@e132581.arm.com>



On 14/03/2025 9:50 am, Leo Yan wrote:
> On Tue, Feb 11, 2025 at 10:39:42AM +0000, James Clark wrote:
>>
>> These are all static and in one compilation unit so the inline has no
>> effect on the binary.
> 
> I read the doc coding-style.rst, the section "15) The inline disease",
> my understanding is though the inline is not encouraged, I prefer we can
> follow up the rule:
> 
>    A reasonable rule of thumb is to not put inline at functions that have more
>    than 3 lines of code in them. An exception to this rule are the cases where
>    a parameter is known to be a compile time constant, and as a result of this
>    constantness you *know* the compiler will be able to optimize most of your
>    function away at compile time. For a good example of this later case, see
>    the kmalloc() inline function.
> 

Isn't this advice about whether to make an inline function in a header 
file or do definition + declaration? I only removed static ones local to 
.c files where 'inline' has no effect at all. We build with optimisation 
enabled so the compiler already auto inlines small functions and ignores 
the inline keyword for large re-used ones anyway.

>> Except if FTRACE is enabled, then some functions
>> which were already not inlined now get the nops added which allows them
>> to be traced.
> 
> I understand it is a side effect that we cannot use function tracer for
> inline functions.  This is not a big issue for me, as we still can use
> "perf probe" and trace_printk() for debugging.
> 
> Thanks,
> Leo
> 

I think it can be useful, I've used it a little bit. Might as well make 
it easier to use for someone if it exists.


  reply	other threads:[~2025-03-17 15:26 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-11 10:39 [PATCH 0/7] coresight: Clear self hosted claim tag on probe James Clark
2025-02-11 10:39 ` [PATCH 1/7] coresight: Rename coresight_{set,clear}_claim_tags() James Clark
2025-03-13 11:24   ` Leo Yan
2025-02-11 10:39 ` [PATCH 2/7] coresight: Convert disclaim functions to take a struct cs_access James Clark
2025-03-13 14:54   ` Leo Yan
2025-03-17 11:36     ` James Clark
2025-03-17 18:29       ` Leo Yan
2025-03-18  9:27         ` James Clark
2025-02-11 10:39 ` [PATCH 3/7] coresight: Only check bottom two claim bits James Clark
2025-03-13 11:46   ` Leo Yan
2025-02-11 10:39 ` [PATCH 4/7] coresight: Add claim tag warnings and debug messages James Clark
2025-03-13 14:40   ` Leo Yan
2025-03-17 11:56     ` James Clark
2025-02-11 10:39 ` [PATCH 5/7] coresight: Clear self hosted claim tag on probe James Clark
2025-02-12 18:24   ` Mike Leach
2025-02-13 13:20     ` James Clark
2025-03-13 16:04   ` Leo Yan
2025-03-17 15:05     ` James Clark
2025-03-17 18:09       ` Leo Yan
2025-02-11 10:39 ` [PATCH 6/7] coresight: Remove inlines from static function definitions James Clark
2025-03-14  9:50   ` Leo Yan
2025-03-17 15:26     ` James Clark [this message]
2025-03-17 17:45       ` Leo Yan
2025-02-11 10:39 ` [PATCH 7/7] coresight: Remove extern from function declarations James Clark
2025-03-13 16:17   ` Leo Yan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9d06b27a-c2ce-41b8-9657-151000c0b244@linaro.org \
    --to=james.clark@linaro.org \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=alexandre.torgue@foss.st.com \
    --cc=coresight@lists.linaro.org \
    --cc=lcherian@marvell.com \
    --cc=leo.yan@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-stm32@st-md-mailman.stormreply.com \
    --cc=mcoquelin.stm32@gmail.com \
    --cc=mike.leach@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®