* [PATCH v2] staging: comedi: remove redundant filename references in headers
@ 2025-03-11 10:07 Siddarth G
2025-03-11 11:17 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Siddarth G @ 2025-03-11 10:07 UTC (permalink / raw)
To: gregkh, abbotti, hsweeten
Cc: skhan, linux-kernel, ruffalolavoisier, colin.i.king,
n.zhandarovich, Siddarth G
checkpatch.pl reports the following warning in COMEDI subsystem files:
WARNING: It's generally not useful to have the filename in the file
These file headers contain redundant filename references (e.g., "* comedi_buf.c"
in comedi_buf.c) which are unnecessary.
This patch removes these references from 14 files to comply with kernel coding
standards and eliminate the warnings.
Signed-off-by: Siddarth G <siddarthsgml@gmail.com>
---
Changes in v2:
-Included the exact checkpatch.pl warning in the commit message for clarity.
---
drivers/comedi/comedi_buf.c | 1 -
drivers/comedi/comedi_fops.c | 1 -
drivers/comedi/comedi_pci.c | 1 -
drivers/comedi/comedi_pcmcia.c | 1 -
drivers/comedi/comedi_usb.c | 1 -
drivers/comedi/drivers.c | 1 -
drivers/comedi/drivers/ni_routing/ni_device_routes.c | 1 -
drivers/comedi/drivers/ni_routing/ni_device_routes.h | 1 -
drivers/comedi/drivers/ni_routing/ni_route_values.c | 1 -
drivers/comedi/drivers/ni_routing/ni_route_values.h | 1 -
drivers/comedi/drivers/tests/comedi_example_test.c | 1 -
drivers/comedi/drivers/tests/ni_routes_test.c | 1 -
drivers/comedi/drivers/tests/unittest.h | 1 -
drivers/comedi/range.c | 1 -
14 files changed, 14 deletions(-)
diff --git a/drivers/comedi/comedi_buf.c b/drivers/comedi/comedi_buf.c
index 393966c09740..6597b25c0fc4 100644
--- a/drivers/comedi/comedi_buf.c
+++ b/drivers/comedi/comedi_buf.c
@@ -1,6 +1,5 @@
// SPDX-License-Identifier: GPL-2.0+
/*
- * comedi_buf.c
*
* COMEDI - Linux Control and Measurement Device Interface
* Copyright (C) 1997-2000 David A. Schleef <ds@schleef.org>
diff --git a/drivers/comedi/comedi_fops.c b/drivers/comedi/comedi_fops.c
index b9df9b19d4bd..80afb683a2d1 100644
--- a/drivers/comedi/comedi_fops.c
+++ b/drivers/comedi/comedi_fops.c
@@ -1,6 +1,5 @@
// SPDX-License-Identifier: GPL-2.0+
/*
- * comedi/comedi_fops.c
* comedi kernel module
*
* COMEDI - Linux Control and Measurement Device Interface
diff --git a/drivers/comedi/comedi_pci.c b/drivers/comedi/comedi_pci.c
index cc2581902195..c664c6d6eb7e 100644
--- a/drivers/comedi/comedi_pci.c
+++ b/drivers/comedi/comedi_pci.c
@@ -1,6 +1,5 @@
// SPDX-License-Identifier: GPL-2.0+
/*
- * comedi_pci.c
* Comedi PCI driver specific functions.
*
* COMEDI - Linux Control and Measurement Device Interface
diff --git a/drivers/comedi/comedi_pcmcia.c b/drivers/comedi/comedi_pcmcia.c
index c53aad0fc2ce..2a7ba645af88 100644
--- a/drivers/comedi/comedi_pcmcia.c
+++ b/drivers/comedi/comedi_pcmcia.c
@@ -1,6 +1,5 @@
// SPDX-License-Identifier: GPL-2.0+
/*
- * comedi_pcmcia.c
* Comedi PCMCIA driver specific functions.
*
* COMEDI - Linux Control and Measurement Device Interface
diff --git a/drivers/comedi/comedi_usb.c b/drivers/comedi/comedi_usb.c
index d11ea148ebf8..fd38b4cfb4b4 100644
--- a/drivers/comedi/comedi_usb.c
+++ b/drivers/comedi/comedi_usb.c
@@ -1,6 +1,5 @@
// SPDX-License-Identifier: GPL-2.0+
/*
- * comedi_usb.c
* Comedi USB driver specific functions.
*
* COMEDI - Linux Control and Measurement Device Interface
diff --git a/drivers/comedi/drivers.c b/drivers/comedi/drivers.c
index 376130bfba8a..050c7417e273 100644
--- a/drivers/comedi/drivers.c
+++ b/drivers/comedi/drivers.c
@@ -1,6 +1,5 @@
// SPDX-License-Identifier: GPL-2.0+
/*
- * module/drivers.c
* functions for manipulating drivers
*
* COMEDI - Linux Control and Measurement Device Interface
diff --git a/drivers/comedi/drivers/ni_routing/ni_device_routes.c b/drivers/comedi/drivers/ni_routing/ni_device_routes.c
index 58654c2b12d6..f68bbc3f6761 100644
--- a/drivers/comedi/drivers/ni_routing/ni_device_routes.c
+++ b/drivers/comedi/drivers/ni_routing/ni_device_routes.c
@@ -1,6 +1,5 @@
// SPDX-License-Identifier: GPL-2.0+
/*
- * comedi/drivers/ni_routing/ni_device_routes.c
* List of valid routes for specific NI boards.
*
* COMEDI - Linux Control and Measurement Device Interface
diff --git a/drivers/comedi/drivers/ni_routing/ni_device_routes.h b/drivers/comedi/drivers/ni_routing/ni_device_routes.h
index 09e4e172c659..460f840f7600 100644
--- a/drivers/comedi/drivers/ni_routing/ni_device_routes.h
+++ b/drivers/comedi/drivers/ni_routing/ni_device_routes.h
@@ -1,6 +1,5 @@
/* SPDX-License-Identifier: GPL-2.0+ */
/*
- * comedi/drivers/ni_routing/ni_device_routes.c
* List of valid routes for specific NI boards.
*
* COMEDI - Linux Control and Measurement Device Interface
diff --git a/drivers/comedi/drivers/ni_routing/ni_route_values.c b/drivers/comedi/drivers/ni_routing/ni_route_values.c
index 54a740b39819..dbf8c99ea922 100644
--- a/drivers/comedi/drivers/ni_routing/ni_route_values.c
+++ b/drivers/comedi/drivers/ni_routing/ni_route_values.c
@@ -1,6 +1,5 @@
// SPDX-License-Identifier: GPL-2.0+
/*
- * comedi/drivers/ni_routing/ni_route_values.c
* Route information for NI boards.
*
* COMEDI - Linux Control and Measurement Device Interface
diff --git a/drivers/comedi/drivers/ni_routing/ni_route_values.h b/drivers/comedi/drivers/ni_routing/ni_route_values.h
index 80880083ea41..70e245fdd403 100644
--- a/drivers/comedi/drivers/ni_routing/ni_route_values.h
+++ b/drivers/comedi/drivers/ni_routing/ni_route_values.h
@@ -1,6 +1,5 @@
/* SPDX-License-Identifier: GPL-2.0+ */
/*
- * comedi/drivers/ni_routing/ni_route_values.h
* Route information for NI boards.
*
* COMEDI - Linux Control and Measurement Device Interface
diff --git a/drivers/comedi/drivers/tests/comedi_example_test.c b/drivers/comedi/drivers/tests/comedi_example_test.c
index 81d074bcdea5..dfb00b60f0c9 100644
--- a/drivers/comedi/drivers/tests/comedi_example_test.c
+++ b/drivers/comedi/drivers/tests/comedi_example_test.c
@@ -1,6 +1,5 @@
// SPDX-License-Identifier: GPL-2.0+
/*
- * comedi/drivers/tests/comedi_example_test.c
* Example set of unit tests.
*
* COMEDI - Linux Control and Measurement Device Interface
diff --git a/drivers/comedi/drivers/tests/ni_routes_test.c b/drivers/comedi/drivers/tests/ni_routes_test.c
index 652362486ff6..afeb7f85347d 100644
--- a/drivers/comedi/drivers/tests/ni_routes_test.c
+++ b/drivers/comedi/drivers/tests/ni_routes_test.c
@@ -1,6 +1,5 @@
// SPDX-License-Identifier: GPL-2.0+
/*
- * comedi/drivers/tests/ni_routes_test.c
* Unit tests for NI routes (ni_routes.c module).
*
* COMEDI - Linux Control and Measurement Device Interface
diff --git a/drivers/comedi/drivers/tests/unittest.h b/drivers/comedi/drivers/tests/unittest.h
index b0b34e058aad..87716ef0ea45 100644
--- a/drivers/comedi/drivers/tests/unittest.h
+++ b/drivers/comedi/drivers/tests/unittest.h
@@ -1,6 +1,5 @@
/* SPDX-License-Identifier: GPL-2.0+ */
/*
- * comedi/drivers/tests/unittest.h
* Simple framework for unittests for comedi drivers.
*
* COMEDI - Linux Control and Measurement Device Interface
diff --git a/drivers/comedi/range.c b/drivers/comedi/range.c
index 8f43cf88d784..d006402146c4 100644
--- a/drivers/comedi/range.c
+++ b/drivers/comedi/range.c
@@ -1,6 +1,5 @@
// SPDX-License-Identifier: GPL-2.0+
/*
- * comedi/range.c
* comedi routines for voltage ranges
*
* COMEDI - Linux Control and Measurement Device Interface
--
2.43.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH v2] staging: comedi: remove redundant filename references in headers
2025-03-11 10:07 [PATCH v2] staging: comedi: remove redundant filename references in headers Siddarth G
@ 2025-03-11 11:17 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2025-03-11 11:17 UTC (permalink / raw)
To: Siddarth G
Cc: abbotti, hsweeten, skhan, linux-kernel, ruffalolavoisier,
colin.i.king, n.zhandarovich
On Tue, Mar 11, 2025 at 03:37:41PM +0530, Siddarth G wrote:
> checkpatch.pl reports the following warning in COMEDI subsystem files:
> WARNING: It's generally not useful to have the filename in the file
> These file headers contain redundant filename references (e.g., "* comedi_buf.c"
> in comedi_buf.c) which are unnecessary.
> This patch removes these references from 14 files to comply with kernel coding
> standards and eliminate the warnings.
>
> Signed-off-by: Siddarth G <siddarthsgml@gmail.com>
> ---
> Changes in v2:
> -Included the exact checkpatch.pl warning in the commit message for clarity.
> ---
> drivers/comedi/comedi_buf.c | 1 -
> drivers/comedi/comedi_fops.c | 1 -
> drivers/comedi/comedi_pci.c | 1 -
> drivers/comedi/comedi_pcmcia.c | 1 -
> drivers/comedi/comedi_usb.c | 1 -
> drivers/comedi/drivers.c | 1 -
> drivers/comedi/drivers/ni_routing/ni_device_routes.c | 1 -
> drivers/comedi/drivers/ni_routing/ni_device_routes.h | 1 -
> drivers/comedi/drivers/ni_routing/ni_route_values.c | 1 -
> drivers/comedi/drivers/ni_routing/ni_route_values.h | 1 -
> drivers/comedi/drivers/tests/comedi_example_test.c | 1 -
> drivers/comedi/drivers/tests/ni_routes_test.c | 1 -
> drivers/comedi/drivers/tests/unittest.h | 1 -
> drivers/comedi/range.c | 1 -
These files are not in the "staging" directory, so no need for staging/
to be in the subject line at all :(
Also, start by working on checkpatch cleanups in the drivers/staging/
directory, not elsewhere in the kernel tree, so you get experience in
doing all of this properly before moving out to other areas. Also, some
subsystems do not want checkpatch cleanups, so be careful.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-03-11 11:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-03-11 10:07 [PATCH v2] staging: comedi: remove redundant filename references in headers Siddarth G
2025-03-11 11:17 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®