* [PATCH] USB: host: omap: Do not enable by default during compile testing
@ 2025-04-17 7:46 Krzysztof Kozlowski
2025-04-17 8:22 ` Greg Kroah-Hartman
0 siblings, 1 reply; 3+ messages in thread
From: Krzysztof Kozlowski @ 2025-04-17 7:46 UTC (permalink / raw)
To: Greg Kroah-Hartman, linux-usb, linux-kernel; +Cc: Krzysztof Kozlowski
Enabling the compile test should not cause automatic enabling of all
drivers, but only allow to choose to compile them.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
For longer rationale:
https://lore.kernel.org/all/191543a8-2e2e-4ac4-9b2b-d253820a0c9f@app.fastmail.com/
---
drivers/usb/host/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/host/Kconfig b/drivers/usb/host/Kconfig
index d011d6c753ed..6dedacba94b3 100644
--- a/drivers/usb/host/Kconfig
+++ b/drivers/usb/host/Kconfig
@@ -225,7 +225,7 @@ config USB_EHCI_HCD_OMAP
tristate "EHCI support for OMAP3 and later chips"
depends on ARCH_OMAP || COMPILE_TEST
depends on NOP_USB_XCEIV
- default y
+ default ARCH_OMAP
help
Enables support for the on-chip EHCI controller on
OMAP3 and later chips.
--
2.45.2
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] USB: host: omap: Do not enable by default during compile testing
2025-04-17 7:46 [PATCH] USB: host: omap: Do not enable by default during compile testing Krzysztof Kozlowski
@ 2025-04-17 8:22 ` Greg Kroah-Hartman
2025-04-17 8:27 ` Krzysztof Kozlowski
0 siblings, 1 reply; 3+ messages in thread
From: Greg Kroah-Hartman @ 2025-04-17 8:22 UTC (permalink / raw)
To: Krzysztof Kozlowski; +Cc: linux-usb, linux-kernel
On Thu, Apr 17, 2025 at 09:46:34AM +0200, Krzysztof Kozlowski wrote:
> Enabling the compile test should not cause automatic enabling of all
> drivers, but only allow to choose to compile them.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
> ---
>
> For longer rationale:
> https://lore.kernel.org/all/191543a8-2e2e-4ac4-9b2b-d253820a0c9f@app.fastmail.com/
> ---
> drivers/usb/host/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/host/Kconfig b/drivers/usb/host/Kconfig
> index d011d6c753ed..6dedacba94b3 100644
> --- a/drivers/usb/host/Kconfig
> +++ b/drivers/usb/host/Kconfig
> @@ -225,7 +225,7 @@ config USB_EHCI_HCD_OMAP
> tristate "EHCI support for OMAP3 and later chips"
> depends on ARCH_OMAP || COMPILE_TEST
> depends on NOP_USB_XCEIV
> - default y
> + default ARCH_OMAP
Should this get a "Fixes:" tag as well?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] USB: host: omap: Do not enable by default during compile testing
2025-04-17 8:22 ` Greg Kroah-Hartman
@ 2025-04-17 8:27 ` Krzysztof Kozlowski
0 siblings, 0 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2025-04-17 8:27 UTC (permalink / raw)
To: Greg Kroah-Hartman; +Cc: linux-usb, linux-kernel
On 17/04/2025 10:22, Greg Kroah-Hartman wrote:
> On Thu, Apr 17, 2025 at 09:46:34AM +0200, Krzysztof Kozlowski wrote:
>> Enabling the compile test should not cause automatic enabling of all
>> drivers, but only allow to choose to compile them.
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>>
>> ---
>>
>> For longer rationale:
>> https://lore.kernel.org/all/191543a8-2e2e-4ac4-9b2b-d253820a0c9f@app.fastmail.com/
>> ---
>> drivers/usb/host/Kconfig | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/usb/host/Kconfig b/drivers/usb/host/Kconfig
>> index d011d6c753ed..6dedacba94b3 100644
>> --- a/drivers/usb/host/Kconfig
>> +++ b/drivers/usb/host/Kconfig
>> @@ -225,7 +225,7 @@ config USB_EHCI_HCD_OMAP
>> tristate "EHCI support for OMAP3 and later chips"
>> depends on ARCH_OMAP || COMPILE_TEST
>> depends on NOP_USB_XCEIV
>> - default y
>> + default ARCH_OMAP
>
> Should this get a "Fixes:" tag as well?
>
I think not, because some people's intention was to enable everything
during compile test, thus it was not a bug, but a feature.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-04-17 8:27 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-04-17 7:46 [PATCH] USB: host: omap: Do not enable by default during compile testing Krzysztof Kozlowski
2025-04-17 8:22 ` Greg Kroah-Hartman
2025-04-17 8:27 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®