* [PATCH RFC v2 0/5] Add support for Saef SFTO340XC panel.
@ 2025-04-24 15:07 Kory Maincent
2025-04-24 15:07 ` [PATCH RFC v2 1/5] dt-bindings: display: panel: Fix port binding Kory Maincent
` (4 more replies)
0 siblings, 5 replies; 11+ messages in thread
From: Kory Maincent @ 2025-04-24 15:07 UTC (permalink / raw)
To: Neil Armstrong, Jessica Zhang, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, David Airlie, Simona Vetter, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Thierry Reding,
Laurent Pinchart
Cc: Thomas Petazzoni, Miquel Raynal, dri-devel, linux-kernel,
devicetree, Kory Maincent
Add support for Saef Technology Limited SFTO340XC LCD panel.
Add alongside the number of lanes configuration in the ili9881c driver
as the board on my desc use the panel with only two lanes.
Faced an issue with panel-common binding. Wrote a fix (first patch) but not
sure it is the right one. If someone from dt tree could take a look, it
would be nice.
Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>
---
Changes in v2:
- Add new patch trying to fix panel-common binding.
- Read the data-lanes parameter from the port endpoint and use
drm_of_get_data_lanes_count instead of of_property_read_u32.
- Link to v1: https://lore.kernel.org/r/20250408-feature_sfto340xc-v1-0-f303d1b9a996@bootlin.com
---
Kory Maincent (5):
dt-bindings: display: panel: Fix port binding
dt-bindings: display: panel: ili9881c: Add data-lanes property
drm/panel: ilitek-ili9881c: Add support for two-lane configuration
dt-bindings: ili9881c: Add Saef SFTO340XC support
drm: panel: Add Saef SFTO340XC LCD panel
.../bindings/display/panel/ilitek,ili9881c.yaml | 21 ++
.../bindings/display/panel/panel-common.yaml | 2 +-
drivers/gpu/drm/panel/panel-ilitek-ili9881c.c | 265 ++++++++++++++++++++-
3 files changed, 285 insertions(+), 3 deletions(-)
---
base-commit: bef4f1156b74721b7d111114538659031119b6f2
change-id: 20250129-feature_sfto340xc-d2b25a5b5748
Best regards,
--
Köry Maincent, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH RFC v2 1/5] dt-bindings: display: panel: Fix port binding
2025-04-24 15:07 [PATCH RFC v2 0/5] Add support for Saef SFTO340XC panel Kory Maincent
@ 2025-04-24 15:07 ` Kory Maincent
2025-04-28 7:32 ` Krzysztof Kozlowski
2025-04-24 15:07 ` [PATCH RFC v2 2/5] dt-bindings: display: panel: ili9881c: Add data-lanes property Kory Maincent
` (3 subsequent siblings)
4 siblings, 1 reply; 11+ messages in thread
From: Kory Maincent @ 2025-04-24 15:07 UTC (permalink / raw)
To: Neil Armstrong, Jessica Zhang, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, David Airlie, Simona Vetter, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Thierry Reding,
Laurent Pinchart
Cc: Thomas Petazzoni, Miquel Raynal, dri-devel, linux-kernel,
devicetree, Kory Maincent
Faced a binding error check while adding the data-lanes property in the
ilitek,ili9881c binding. See the next patch for the binding changes.
Here is the error:
Documentation/devicetree/bindings/display/panel/ilitek,ili9881c.example.dtb:
panel@0: port:endpoint: Unevaluated properties are not allowed
('data-lanes' was unexpected)
Change the reference of properties/port to $defs/port-base to makes it
work.
The only difference between port and port-base is the unevaluatedProperty
set to false. I have tried to use properties/port in both panel-common
and ilitek,ili9881c bindings but the error is still there. The only way
to not face the error is to use $defs/port-base reference. I don't
really understand the ins and outs, maybe it is a issue from the binding
check tool.
Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>
---
Changes in v2:
- New patch
---
Documentation/devicetree/bindings/display/panel/panel-common.yaml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/display/panel/panel-common.yaml b/Documentation/devicetree/bindings/display/panel/panel-common.yaml
index 087415753d606ce67bceabaa9b0ba7d463282f92..635f67ced0cb7103684a1415ab740d83409a7dbb 100644
--- a/Documentation/devicetree/bindings/display/panel/panel-common.yaml
+++ b/Documentation/devicetree/bindings/display/panel/panel-common.yaml
@@ -76,7 +76,7 @@ properties:
# Connectivity
port:
- $ref: /schemas/graph.yaml#/properties/port
+ $ref: /schemas/graph.yaml#/$defs/port-base
ddc-i2c-bus:
$ref: /schemas/types.yaml#/definitions/phandle
--
2.34.1
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH RFC v2 2/5] dt-bindings: display: panel: ili9881c: Add data-lanes property
2025-04-24 15:07 [PATCH RFC v2 0/5] Add support for Saef SFTO340XC panel Kory Maincent
2025-04-24 15:07 ` [PATCH RFC v2 1/5] dt-bindings: display: panel: Fix port binding Kory Maincent
@ 2025-04-24 15:07 ` Kory Maincent
2025-04-28 7:33 ` Krzysztof Kozlowski
2025-04-24 15:07 ` [PATCH RFC v2 3/5] drm/panel: ilitek-ili9881c: Add support for two-lane configuration Kory Maincent
` (2 subsequent siblings)
4 siblings, 1 reply; 11+ messages in thread
From: Kory Maincent @ 2025-04-24 15:07 UTC (permalink / raw)
To: Neil Armstrong, Jessica Zhang, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, David Airlie, Simona Vetter, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Thierry Reding,
Laurent Pinchart
Cc: Thomas Petazzoni, Miquel Raynal, dri-devel, linux-kernel,
devicetree, Kory Maincent
Add the data-lanes property to specify the number of DSI lanes used by the
panel. This allows configuring the panel for either two, three or four
lanes.
At the same time, extend the devicetree example with an endpoint node for
better clarity.
Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>
---
Change in v2:
- Use data-lanes property from video-interfaces.yaml
- Add endpoint description example
---
.../bindings/display/panel/ilitek,ili9881c.yaml | 20 ++++++++++++++++++++
1 file changed, 20 insertions(+)
diff --git a/Documentation/devicetree/bindings/display/panel/ilitek,ili9881c.yaml b/Documentation/devicetree/bindings/display/panel/ilitek,ili9881c.yaml
index baf5dfe5f5ebdd92f460a78d0e56e1b45e7dd323..3a897e464178dfc8a7c70e0fafb51184c50a520b 100644
--- a/Documentation/devicetree/bindings/display/panel/ilitek,ili9881c.yaml
+++ b/Documentation/devicetree/bindings/display/panel/ilitek,ili9881c.yaml
@@ -27,6 +27,20 @@ properties:
reg:
maxItems: 1
+ port:
+ $ref: /schemas/graph.yaml#/$defs/port-base
+ unevaluatedProperties: false
+
+ properties:
+ endpoint:
+ $ref: /schemas/media/video-interfaces.yaml#
+ unevaluatedProperties: false
+
+ properties:
+ data-lanes:
+ minItems: 1
+ maxItems: 4
+
backlight: true
power-supply: true
reset-gpios: true
@@ -53,6 +67,12 @@ examples:
power-supply = <®_display>;
reset-gpios = <&r_pio 0 5 GPIO_ACTIVE_LOW>; /* PL05 */
backlight = <&pwm_bl>;
+ port {
+ panel_in: endpoint {
+ remote-endpoint = <&dsi_out>;
+ data-lanes = <1 2>;
+ };
+ };
};
};
--
2.34.1
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH RFC v2 3/5] drm/panel: ilitek-ili9881c: Add support for two-lane configuration
2025-04-24 15:07 [PATCH RFC v2 0/5] Add support for Saef SFTO340XC panel Kory Maincent
2025-04-24 15:07 ` [PATCH RFC v2 1/5] dt-bindings: display: panel: Fix port binding Kory Maincent
2025-04-24 15:07 ` [PATCH RFC v2 2/5] dt-bindings: display: panel: ili9881c: Add data-lanes property Kory Maincent
@ 2025-04-24 15:07 ` Kory Maincent
2025-04-26 3:31 ` Dmitry Baryshkov
2025-04-24 15:07 ` [PATCH RFC v2 4/5] dt-bindings: ili9881c: Add Saef SFTO340XC support Kory Maincent
2025-04-24 15:07 ` [PATCH RFC v2 5/5] drm: panel: Add Saef SFTO340XC LCD panel Kory Maincent
4 siblings, 1 reply; 11+ messages in thread
From: Kory Maincent @ 2025-04-24 15:07 UTC (permalink / raw)
To: Neil Armstrong, Jessica Zhang, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, David Airlie, Simona Vetter, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Thierry Reding,
Laurent Pinchart
Cc: Thomas Petazzoni, Miquel Raynal, dri-devel, linux-kernel,
devicetree, Kory Maincent
Enable support for two-lane configuration which is done by setting the
LANSEL_SW_EN and LANSEL_SW bits in the Pad Control register.
Use the data-lanes device tree parameter to configure the number of lanes.
The default configuration remains set to four lanes.
Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>
---
Change in v2:
- Read the data-lanes parameter from the port endpoint and use
drm_of_get_data_lanes_count instead of of_property_read_u32.
---
drivers/gpu/drm/panel/panel-ilitek-ili9881c.c | 33 +++++++++++++++++++++++++--
1 file changed, 31 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/panel/panel-ilitek-ili9881c.c b/drivers/gpu/drm/panel/panel-ilitek-ili9881c.c
index 28cd7560e5db1d5734b10babdb4e4e553c6e07d0..2e38dea28336f445cb6a074dbbec006f0659287a 100644
--- a/drivers/gpu/drm/panel/panel-ilitek-ili9881c.c
+++ b/drivers/gpu/drm/panel/panel-ilitek-ili9881c.c
@@ -16,6 +16,7 @@
#include <drm/drm_mipi_dsi.h>
#include <drm/drm_modes.h>
+#include <drm/drm_of.h>
#include <drm/drm_panel.h>
#include <video/mipi_display.h>
@@ -1263,6 +1264,21 @@ static int ili9881c_send_cmd_data(struct ili9881c *ctx, u8 cmd, u8 data)
return 0;
}
+static int ili9881c_set_lanes_cfg(struct ili9881c *ctx)
+{
+ int ret;
+
+ if (ctx->dsi->lanes != 2)
+ /* Nothing to do */
+ return 0;
+
+ ret = ili9881c_switch_page(ctx, 1);
+ if (ret)
+ return ret;
+
+ return ili9881c_send_cmd_data(ctx, 0xB7, 0x3);
+}
+
static int ili9881c_prepare(struct drm_panel *panel)
{
struct ili9881c *ctx = panel_to_ili9881c(panel);
@@ -1295,6 +1311,10 @@ static int ili9881c_prepare(struct drm_panel *panel)
return ret;
}
+ ret = ili9881c_set_lanes_cfg(ctx);
+ if (ret)
+ return ret;
+
ret = ili9881c_switch_page(ctx, 0);
if (ret)
return ret;
@@ -1503,8 +1523,9 @@ static const struct drm_panel_funcs ili9881c_funcs = {
static int ili9881c_dsi_probe(struct mipi_dsi_device *dsi)
{
+ struct device_node *endpoint;
struct ili9881c *ctx;
- int ret;
+ int ret, lanes;
ctx = devm_kzalloc(&dsi->dev, sizeof(*ctx), GFP_KERNEL);
if (!ctx)
@@ -1545,11 +1566,19 @@ static int ili9881c_dsi_probe(struct mipi_dsi_device *dsi)
if (ret)
return ret;
+ endpoint = of_graph_get_endpoint_by_regs(dsi->dev.of_node, -1, -1);
+ lanes = drm_of_get_data_lanes_count(endpoint, 2, 4);
+ of_node_put(endpoint);
+ if (lanes == -EINVAL)
+ lanes = 4;
+ else if (lanes < 0)
+ return lanes;
+
drm_panel_add(&ctx->panel);
dsi->mode_flags = ctx->desc->mode_flags;
dsi->format = MIPI_DSI_FMT_RGB888;
- dsi->lanes = 4;
+ dsi->lanes = lanes;
return mipi_dsi_attach(dsi);
}
--
2.34.1
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH RFC v2 4/5] dt-bindings: ili9881c: Add Saef SFTO340XC support
2025-04-24 15:07 [PATCH RFC v2 0/5] Add support for Saef SFTO340XC panel Kory Maincent
` (2 preceding siblings ...)
2025-04-24 15:07 ` [PATCH RFC v2 3/5] drm/panel: ilitek-ili9881c: Add support for two-lane configuration Kory Maincent
@ 2025-04-24 15:07 ` Kory Maincent
2025-04-24 15:07 ` [PATCH RFC v2 5/5] drm: panel: Add Saef SFTO340XC LCD panel Kory Maincent
4 siblings, 0 replies; 11+ messages in thread
From: Kory Maincent @ 2025-04-24 15:07 UTC (permalink / raw)
To: Neil Armstrong, Jessica Zhang, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, David Airlie, Simona Vetter, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Thierry Reding,
Laurent Pinchart
Cc: Thomas Petazzoni, Miquel Raynal, dri-devel, linux-kernel,
devicetree, Kory Maincent
Document the compatible value for Saef SFTO340XC panels.
Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>
---
Documentation/devicetree/bindings/display/panel/ilitek,ili9881c.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/display/panel/ilitek,ili9881c.yaml b/Documentation/devicetree/bindings/display/panel/ilitek,ili9881c.yaml
index 3a897e464178dfc8a7c70e0fafb51184c50a520b..1e6845454e23bb37f1f7adffd99cd17a5effe68e 100644
--- a/Documentation/devicetree/bindings/display/panel/ilitek,ili9881c.yaml
+++ b/Documentation/devicetree/bindings/display/panel/ilitek,ili9881c.yaml
@@ -19,6 +19,7 @@ properties:
- ampire,am8001280g
- bananapi,lhr050h41
- feixin,k101-im2byl02
+ - saef,sfto340xc
- startek,kd050hdfia020
- tdo,tl050hdv35
- wanchanglong,w552946aba
--
2.34.1
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH RFC v2 5/5] drm: panel: Add Saef SFTO340XC LCD panel
2025-04-24 15:07 [PATCH RFC v2 0/5] Add support for Saef SFTO340XC panel Kory Maincent
` (3 preceding siblings ...)
2025-04-24 15:07 ` [PATCH RFC v2 4/5] dt-bindings: ili9881c: Add Saef SFTO340XC support Kory Maincent
@ 2025-04-24 15:07 ` Kory Maincent
2025-04-26 3:32 ` Dmitry Baryshkov
4 siblings, 1 reply; 11+ messages in thread
From: Kory Maincent @ 2025-04-24 15:07 UTC (permalink / raw)
To: Neil Armstrong, Jessica Zhang, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, David Airlie, Simona Vetter, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Thierry Reding,
Laurent Pinchart
Cc: Thomas Petazzoni, Miquel Raynal, dri-devel, linux-kernel,
devicetree, Kory Maincent
Add support for Saef Technology Limited SFTO340XC LCD panel.
Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>
---
drivers/gpu/drm/panel/panel-ilitek-ili9881c.c | 232 ++++++++++++++++++++++++++
1 file changed, 232 insertions(+)
diff --git a/drivers/gpu/drm/panel/panel-ilitek-ili9881c.c b/drivers/gpu/drm/panel/panel-ilitek-ili9881c.c
index 2e38dea28336f445cb6a074dbbec006f0659287a..574d2dad873474ffa02d554aff9d62c63e070d99 100644
--- a/drivers/gpu/drm/panel/panel-ilitek-ili9881c.c
+++ b/drivers/gpu/drm/panel/panel-ilitek-ili9881c.c
@@ -44,6 +44,7 @@ struct ili9881c_desc {
const struct drm_display_mode *mode;
const unsigned long mode_flags;
u8 default_address_mode;
+ const unsigned int msleep_delay;
};
struct ili9881c {
@@ -458,6 +459,207 @@ static const struct ili9881c_instr k101_im2byl02_init[] = {
ILI9881C_COMMAND_INSTR(0xD3, 0x3F), /* VN0 */
};
+static const struct ili9881c_instr sfto340xc_init[] = {
+ ILI9881C_SWITCH_PAGE_INSTR(3),
+ ILI9881C_COMMAND_INSTR(0x01, 0x00),
+ ILI9881C_COMMAND_INSTR(0x02, 0x01),
+ ILI9881C_COMMAND_INSTR(0x03, 0x73),
+ ILI9881C_COMMAND_INSTR(0x04, 0x03),
+ ILI9881C_COMMAND_INSTR(0x05, 0x00),
+ ILI9881C_COMMAND_INSTR(0x06, 0x0A),
+ ILI9881C_COMMAND_INSTR(0x07, 0x05),
+ ILI9881C_COMMAND_INSTR(0x08, 0x00),
+ ILI9881C_COMMAND_INSTR(0x09, 0x40),
+ ILI9881C_COMMAND_INSTR(0x0a, 0x00),
+ ILI9881C_COMMAND_INSTR(0x0B, 0x00),
+ ILI9881C_COMMAND_INSTR(0x0C, 0x00),
+ ILI9881C_COMMAND_INSTR(0x0D, 0x40),
+ ILI9881C_COMMAND_INSTR(0x0E, 0x00),
+ ILI9881C_COMMAND_INSTR(0x0f, 0x3c),
+ ILI9881C_COMMAND_INSTR(0x10, 0x3c),
+ ILI9881C_COMMAND_INSTR(0x11, 0x00),
+ ILI9881C_COMMAND_INSTR(0x12, 0x00),
+ ILI9881C_COMMAND_INSTR(0x13, 0x00),
+ ILI9881C_COMMAND_INSTR(0x14, 0x00),
+ ILI9881C_COMMAND_INSTR(0x15, 0x00),
+ ILI9881C_COMMAND_INSTR(0x16, 0x00),
+ ILI9881C_COMMAND_INSTR(0x17, 0x00),
+ ILI9881C_COMMAND_INSTR(0x18, 0x00),
+ ILI9881C_COMMAND_INSTR(0x19, 0x00),
+ ILI9881C_COMMAND_INSTR(0x1A, 0x00),
+ ILI9881C_COMMAND_INSTR(0x1B, 0x00),
+ ILI9881C_COMMAND_INSTR(0x1C, 0x00),
+ ILI9881C_COMMAND_INSTR(0x1D, 0x00),
+ ILI9881C_COMMAND_INSTR(0x1E, 0xC0),
+ ILI9881C_COMMAND_INSTR(0x1F, 0x80),
+ ILI9881C_COMMAND_INSTR(0x20, 0x06),
+ ILI9881C_COMMAND_INSTR(0x21, 0x01),
+ ILI9881C_COMMAND_INSTR(0x22, 0x00),
+ ILI9881C_COMMAND_INSTR(0x23, 0x00),
+ ILI9881C_COMMAND_INSTR(0x24, 0x00),
+ ILI9881C_COMMAND_INSTR(0x25, 0x00),
+ ILI9881C_COMMAND_INSTR(0x26, 0x00),
+ ILI9881C_COMMAND_INSTR(0x27, 0x00),
+ ILI9881C_COMMAND_INSTR(0x28, 0xB3),
+ ILI9881C_COMMAND_INSTR(0x29, 0x03),
+ ILI9881C_COMMAND_INSTR(0x2A, 0x00),
+ ILI9881C_COMMAND_INSTR(0x2B, 0x00),
+ ILI9881C_COMMAND_INSTR(0x2C, 0x00),
+ ILI9881C_COMMAND_INSTR(0x2D, 0x00),
+ ILI9881C_COMMAND_INSTR(0x2E, 0x00),
+ ILI9881C_COMMAND_INSTR(0x2F, 0x00),
+ ILI9881C_COMMAND_INSTR(0x30, 0x00),
+ ILI9881C_COMMAND_INSTR(0x31, 0x00),
+ ILI9881C_COMMAND_INSTR(0x32, 0x00),
+ ILI9881C_COMMAND_INSTR(0x33, 0x00),
+ ILI9881C_COMMAND_INSTR(0x34, 0x23),
+ ILI9881C_COMMAND_INSTR(0x35, 0x00),
+ ILI9881C_COMMAND_INSTR(0x36, 0x00),
+ ILI9881C_COMMAND_INSTR(0x37, 0x08),
+ ILI9881C_COMMAND_INSTR(0x38, 0x3C),
+ ILI9881C_COMMAND_INSTR(0x39, 0x00),
+ ILI9881C_COMMAND_INSTR(0x3A, 0x00),
+ ILI9881C_COMMAND_INSTR(0x3B, 0x00),
+ ILI9881C_COMMAND_INSTR(0x3C, 0x00),
+ ILI9881C_COMMAND_INSTR(0x3D, 0x00),
+ ILI9881C_COMMAND_INSTR(0x3E, 0x00),
+ ILI9881C_COMMAND_INSTR(0x3F, 0x00),
+ ILI9881C_COMMAND_INSTR(0x40, 0x00),
+ ILI9881C_COMMAND_INSTR(0x41, 0x00),
+ ILI9881C_COMMAND_INSTR(0x42, 0x00),
+ ILI9881C_COMMAND_INSTR(0x43, 0x00),
+ ILI9881C_COMMAND_INSTR(0x44, 0x00),
+ ILI9881C_COMMAND_INSTR(0x50, 0x01),
+ ILI9881C_COMMAND_INSTR(0x51, 0x23),
+ ILI9881C_COMMAND_INSTR(0x52, 0x44),
+ ILI9881C_COMMAND_INSTR(0x53, 0x67),
+ ILI9881C_COMMAND_INSTR(0x54, 0x89),
+ ILI9881C_COMMAND_INSTR(0x55, 0xAB),
+ ILI9881C_COMMAND_INSTR(0x56, 0x01),
+ ILI9881C_COMMAND_INSTR(0x57, 0x23),
+ ILI9881C_COMMAND_INSTR(0x58, 0x45),
+ ILI9881C_COMMAND_INSTR(0x59, 0x67),
+ ILI9881C_COMMAND_INSTR(0x5A, 0x89),
+ ILI9881C_COMMAND_INSTR(0x5B, 0xAB),
+ ILI9881C_COMMAND_INSTR(0x5C, 0xCD),
+ ILI9881C_COMMAND_INSTR(0x5D, 0xEF),
+ ILI9881C_COMMAND_INSTR(0x5E, 0x01),
+ ILI9881C_COMMAND_INSTR(0x5F, 0x00),
+ ILI9881C_COMMAND_INSTR(0x60, 0x00),
+ ILI9881C_COMMAND_INSTR(0x61, 0x01),
+ ILI9881C_COMMAND_INSTR(0x62, 0x01),
+ ILI9881C_COMMAND_INSTR(0x63, 0x08),
+ ILI9881C_COMMAND_INSTR(0x64, 0x0E),
+ ILI9881C_COMMAND_INSTR(0x65, 0x0E),
+ ILI9881C_COMMAND_INSTR(0x66, 0x0F),
+ ILI9881C_COMMAND_INSTR(0x67, 0x0F),
+ ILI9881C_COMMAND_INSTR(0x68, 0x0C),
+ ILI9881C_COMMAND_INSTR(0x69, 0x0C),
+ ILI9881C_COMMAND_INSTR(0x6A, 0x0D),
+ ILI9881C_COMMAND_INSTR(0x6B, 0x0D),
+ ILI9881C_COMMAND_INSTR(0x6C, 0x02),
+ ILI9881C_COMMAND_INSTR(0x6D, 0x02),
+ ILI9881C_COMMAND_INSTR(0x6E, 0x14),
+ ILI9881C_COMMAND_INSTR(0x6F, 0x14),
+ ILI9881C_COMMAND_INSTR(0x70, 0x15),
+ ILI9881C_COMMAND_INSTR(0x71, 0x15),
+ ILI9881C_COMMAND_INSTR(0x72, 0x06),
+ ILI9881C_COMMAND_INSTR(0x73, 0x07),
+ ILI9881C_COMMAND_INSTR(0x74, 0x02),
+ ILI9881C_COMMAND_INSTR(0x75, 0x00),
+ ILI9881C_COMMAND_INSTR(0x76, 0x00),
+ ILI9881C_COMMAND_INSTR(0x77, 0x01),
+ ILI9881C_COMMAND_INSTR(0x78, 0x01),
+ ILI9881C_COMMAND_INSTR(0x79, 0x08),
+ ILI9881C_COMMAND_INSTR(0x7A, 0x0D),
+ ILI9881C_COMMAND_INSTR(0x7B, 0x0D),
+ ILI9881C_COMMAND_INSTR(0x7C, 0x0C),
+ ILI9881C_COMMAND_INSTR(0x7D, 0x0C),
+ ILI9881C_COMMAND_INSTR(0x7E, 0x0F),
+ ILI9881C_COMMAND_INSTR(0x7F, 0x0F),
+ ILI9881C_COMMAND_INSTR(0x80, 0x0E),
+ ILI9881C_COMMAND_INSTR(0x81, 0x0E),
+ ILI9881C_COMMAND_INSTR(0x82, 0x02),
+ ILI9881C_COMMAND_INSTR(0x83, 0x02),
+ ILI9881C_COMMAND_INSTR(0x84, 0x14),
+ ILI9881C_COMMAND_INSTR(0x85, 0x14),
+ ILI9881C_COMMAND_INSTR(0x86, 0x15),
+ ILI9881C_COMMAND_INSTR(0x87, 0x15),
+ ILI9881C_COMMAND_INSTR(0x88, 0x07),
+ ILI9881C_COMMAND_INSTR(0x89, 0x06),
+ ILI9881C_COMMAND_INSTR(0x8A, 0x02),
+ ILI9881C_SWITCH_PAGE_INSTR(4),
+ ILI9881C_COMMAND_INSTR(0x6C, 0x15),
+ ILI9881C_COMMAND_INSTR(0x6E, 0x1a),
+ ILI9881C_COMMAND_INSTR(0x6F, 0x35),
+ ILI9881C_COMMAND_INSTR(0x8D, 0x1f),
+ ILI9881C_COMMAND_INSTR(0x87, 0xBA),
+ ILI9881C_COMMAND_INSTR(0x26, 0x76),
+ ILI9881C_COMMAND_INSTR(0xB2, 0xD1),
+ ILI9881C_COMMAND_INSTR(0x3B, 0x98),
+ ILI9881C_COMMAND_INSTR(0x3A, 0x24),
+ ILI9881C_COMMAND_INSTR(0x35, 0x1F),
+ ILI9881C_COMMAND_INSTR(0xB5, 0x27),
+ ILI9881C_COMMAND_INSTR(0x31, 0x75),
+ ILI9881C_COMMAND_INSTR(0x30, 0x03),
+ ILI9881C_COMMAND_INSTR(0x33, 0x14),
+ ILI9881C_COMMAND_INSTR(0x38, 0x01),
+ ILI9881C_COMMAND_INSTR(0x39, 0x00),
+ ILI9881C_SWITCH_PAGE_INSTR(1),
+ ILI9881C_COMMAND_INSTR(0x22, 0x0a),
+ ILI9881C_COMMAND_INSTR(0x2E, 0x50),
+ ILI9881C_COMMAND_INSTR(0x2F, 0x00),
+ ILI9881C_COMMAND_INSTR(0x31, 0x00),
+ ILI9881C_COMMAND_INSTR(0x53, 0x4a),
+ ILI9881C_COMMAND_INSTR(0x55, 0x65),
+ ILI9881C_COMMAND_INSTR(0x50, 0xbf),
+ ILI9881C_COMMAND_INSTR(0x51, 0xbf),
+ ILI9881C_COMMAND_INSTR(0x60, 0x14),
+ ILI9881C_COMMAND_INSTR(0x61, 0x00),
+ ILI9881C_COMMAND_INSTR(0x62, 0x20),
+ ILI9881C_COMMAND_INSTR(0x63, 0x10),
+ ILI9881C_COMMAND_INSTR(0xA0, 0x04),
+ ILI9881C_COMMAND_INSTR(0xA1, 0x39),
+ ILI9881C_COMMAND_INSTR(0xA2, 0x48),
+ ILI9881C_COMMAND_INSTR(0xA3, 0x13),
+ ILI9881C_COMMAND_INSTR(0xA4, 0x17),
+ ILI9881C_COMMAND_INSTR(0xA5, 0x29),
+ ILI9881C_COMMAND_INSTR(0xA6, 0x1c),
+ ILI9881C_COMMAND_INSTR(0xA7, 0x1d),
+ ILI9881C_COMMAND_INSTR(0xA8, 0xbb),
+ ILI9881C_COMMAND_INSTR(0xA9, 0x16),
+ ILI9881C_COMMAND_INSTR(0xAA, 0x24),
+ ILI9881C_COMMAND_INSTR(0xAB, 0x9e),
+ ILI9881C_COMMAND_INSTR(0xAC, 0x16),
+ ILI9881C_COMMAND_INSTR(0xAD, 0x14),
+ ILI9881C_COMMAND_INSTR(0xAE, 0x48),
+ ILI9881C_COMMAND_INSTR(0xAF, 0x1c),
+ ILI9881C_COMMAND_INSTR(0xB0, 0x22),
+ ILI9881C_COMMAND_INSTR(0xB1, 0x51),
+ ILI9881C_COMMAND_INSTR(0xB2, 0x60),
+ ILI9881C_COMMAND_INSTR(0xB3, 0x32),
+ ILI9881C_COMMAND_INSTR(0xC0, 0x04),
+ ILI9881C_COMMAND_INSTR(0xC1, 0x39),
+ ILI9881C_COMMAND_INSTR(0xC2, 0x48),
+ ILI9881C_COMMAND_INSTR(0xC3, 0x13),
+ ILI9881C_COMMAND_INSTR(0xC4, 0x17),
+ ILI9881C_COMMAND_INSTR(0xC5, 0x29),
+ ILI9881C_COMMAND_INSTR(0xC6, 0x1c),
+ ILI9881C_COMMAND_INSTR(0xC7, 0x1d),
+ ILI9881C_COMMAND_INSTR(0xC8, 0xbb),
+ ILI9881C_COMMAND_INSTR(0xC9, 0x16),
+ ILI9881C_COMMAND_INSTR(0xCA, 0x24),
+ ILI9881C_COMMAND_INSTR(0xCB, 0x9e),
+ ILI9881C_COMMAND_INSTR(0xCC, 0x16),
+ ILI9881C_COMMAND_INSTR(0xCD, 0x14),
+ ILI9881C_COMMAND_INSTR(0xCE, 0x48),
+ ILI9881C_COMMAND_INSTR(0xCF, 0x1c),
+ ILI9881C_COMMAND_INSTR(0xD0, 0x22),
+ ILI9881C_COMMAND_INSTR(0xD1, 0x51),
+ ILI9881C_COMMAND_INSTR(0xD2, 0x60),
+ ILI9881C_COMMAND_INSTR(0xD3, 0x32),
+};
+
static const struct ili9881c_instr kd050hdfia020_init[] = {
ILI9881C_SWITCH_PAGE_INSTR(3),
ILI9881C_COMMAND_INSTR(0x01, 0x00),
@@ -1335,6 +1537,9 @@ static int ili9881c_prepare(struct drm_panel *panel)
if (ret)
return ret;
+ if (ctx->desc->msleep_delay)
+ msleep(ctx->desc->msleep_delay);
+
return 0;
}
@@ -1401,6 +1606,23 @@ static const struct drm_display_mode k101_im2byl02_default_mode = {
.height_mm = 217,
};
+static const struct drm_display_mode sfto340xc_default_mode = {
+ .clock = 34000,
+
+ .hdisplay = 800,
+ .hsync_start = 800 + 10,
+ .hsync_end = 800 + 10 + 5,
+ .htotal = 800 + 10 + 5 + 10,
+
+ .vdisplay = 800,
+ .vsync_start = 800 + 10,
+ .vsync_end = 800 + 10 + 5,
+ .vtotal = 800 + 10 + 5 + 10,
+
+ .width_mm = 87,
+ .height_mm = 87,
+};
+
static const struct drm_display_mode kd050hdfia020_default_mode = {
.clock = 62000,
@@ -1605,6 +1827,15 @@ static const struct ili9881c_desc k101_im2byl02_desc = {
.mode_flags = MIPI_DSI_MODE_VIDEO_SYNC_PULSE,
};
+static const struct ili9881c_desc sfto340xc_desc = {
+ .init = sfto340xc_init,
+ .init_length = ARRAY_SIZE(sfto340xc_init),
+ .mode = &sfto340xc_default_mode,
+ .mode_flags = MIPI_DSI_MODE_VIDEO | MIPI_DSI_MODE_VIDEO_BURST |
+ MIPI_DSI_MODE_LPM | MIPI_DSI_CLOCK_NON_CONTINUOUS,
+ .msleep_delay = 100,
+};
+
static const struct ili9881c_desc kd050hdfia020_desc = {
.init = kd050hdfia020_init,
.init_length = ARRAY_SIZE(kd050hdfia020_init),
@@ -1641,6 +1872,7 @@ static const struct ili9881c_desc am8001280g_desc = {
static const struct of_device_id ili9881c_of_match[] = {
{ .compatible = "bananapi,lhr050h41", .data = &lhr050h41_desc },
{ .compatible = "feixin,k101-im2byl02", .data = &k101_im2byl02_desc },
+ { .compatible = "saef,sfto340xc", .data = &sfto340xc_desc },
{ .compatible = "startek,kd050hdfia020", .data = &kd050hdfia020_desc },
{ .compatible = "tdo,tl050hdv35", .data = &tl050hdv35_desc },
{ .compatible = "wanchanglong,w552946aba", .data = &w552946aba_desc },
--
2.34.1
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH RFC v2 3/5] drm/panel: ilitek-ili9881c: Add support for two-lane configuration
2025-04-24 15:07 ` [PATCH RFC v2 3/5] drm/panel: ilitek-ili9881c: Add support for two-lane configuration Kory Maincent
@ 2025-04-26 3:31 ` Dmitry Baryshkov
0 siblings, 0 replies; 11+ messages in thread
From: Dmitry Baryshkov @ 2025-04-26 3:31 UTC (permalink / raw)
To: Kory Maincent
Cc: Neil Armstrong, Jessica Zhang, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, David Airlie, Simona Vetter, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Thierry Reding,
Laurent Pinchart, Thomas Petazzoni, Miquel Raynal, dri-devel,
linux-kernel, devicetree
On Thu, Apr 24, 2025 at 05:07:41PM +0200, Kory Maincent wrote:
> Enable support for two-lane configuration which is done by setting the
> LANSEL_SW_EN and LANSEL_SW bits in the Pad Control register.
>
> Use the data-lanes device tree parameter to configure the number of lanes.
> The default configuration remains set to four lanes.
>
> Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>
> ---
>
> Change in v2:
> - Read the data-lanes parameter from the port endpoint and use
> drm_of_get_data_lanes_count instead of of_property_read_u32.
> ---
> drivers/gpu/drm/panel/panel-ilitek-ili9881c.c | 33 +++++++++++++++++++++++++--
> 1 file changed, 31 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/panel/panel-ilitek-ili9881c.c b/drivers/gpu/drm/panel/panel-ilitek-ili9881c.c
> index 28cd7560e5db1d5734b10babdb4e4e553c6e07d0..2e38dea28336f445cb6a074dbbec006f0659287a 100644
> --- a/drivers/gpu/drm/panel/panel-ilitek-ili9881c.c
> +++ b/drivers/gpu/drm/panel/panel-ilitek-ili9881c.c
> @@ -16,6 +16,7 @@
>
> #include <drm/drm_mipi_dsi.h>
> #include <drm/drm_modes.h>
> +#include <drm/drm_of.h>
> #include <drm/drm_panel.h>
>
> #include <video/mipi_display.h>
> @@ -1263,6 +1264,21 @@ static int ili9881c_send_cmd_data(struct ili9881c *ctx, u8 cmd, u8 data)
> return 0;
> }
>
> +static int ili9881c_set_lanes_cfg(struct ili9881c *ctx)
> +{
> + int ret;
> +
> + if (ctx->dsi->lanes != 2)
> + /* Nothing to do */
> + return 0;
> +
> + ret = ili9881c_switch_page(ctx, 1);
> + if (ret)
> + return ret;
> +
> + return ili9881c_send_cmd_data(ctx, 0xB7, 0x3);
> +}
> +
> static int ili9881c_prepare(struct drm_panel *panel)
> {
> struct ili9881c *ctx = panel_to_ili9881c(panel);
> @@ -1295,6 +1311,10 @@ static int ili9881c_prepare(struct drm_panel *panel)
> return ret;
> }
>
> + ret = ili9881c_set_lanes_cfg(ctx);
> + if (ret)
> + return ret;
> +
> ret = ili9881c_switch_page(ctx, 0);
> if (ret)
> return ret;
> @@ -1503,8 +1523,9 @@ static const struct drm_panel_funcs ili9881c_funcs = {
>
> static int ili9881c_dsi_probe(struct mipi_dsi_device *dsi)
> {
> + struct device_node *endpoint;
> struct ili9881c *ctx;
> - int ret;
> + int ret, lanes;
>
> ctx = devm_kzalloc(&dsi->dev, sizeof(*ctx), GFP_KERNEL);
> if (!ctx)
> @@ -1545,11 +1566,19 @@ static int ili9881c_dsi_probe(struct mipi_dsi_device *dsi)
> if (ret)
> return ret;
>
> + endpoint = of_graph_get_endpoint_by_regs(dsi->dev.of_node, -1, -1);
> + lanes = drm_of_get_data_lanes_count(endpoint, 2, 4);
> + of_node_put(endpoint);
I think you can use drm_of_get_data_lanes_count_ep() here.
> + if (lanes == -EINVAL)
> + lanes = 4;
> + else if (lanes < 0)
> + return lanes;
> +
> drm_panel_add(&ctx->panel);
>
> dsi->mode_flags = ctx->desc->mode_flags;
> dsi->format = MIPI_DSI_FMT_RGB888;
> - dsi->lanes = 4;
> + dsi->lanes = lanes;
>
> return mipi_dsi_attach(dsi);
> }
>
> --
> 2.34.1
>
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH RFC v2 5/5] drm: panel: Add Saef SFTO340XC LCD panel
2025-04-24 15:07 ` [PATCH RFC v2 5/5] drm: panel: Add Saef SFTO340XC LCD panel Kory Maincent
@ 2025-04-26 3:32 ` Dmitry Baryshkov
0 siblings, 0 replies; 11+ messages in thread
From: Dmitry Baryshkov @ 2025-04-26 3:32 UTC (permalink / raw)
To: Kory Maincent
Cc: Neil Armstrong, Jessica Zhang, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, David Airlie, Simona Vetter, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Thierry Reding,
Laurent Pinchart, Thomas Petazzoni, Miquel Raynal, dri-devel,
linux-kernel, devicetree
On Thu, Apr 24, 2025 at 05:07:43PM +0200, Kory Maincent wrote:
> Add support for Saef Technology Limited SFTO340XC LCD panel.
>
> Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>
> ---
> drivers/gpu/drm/panel/panel-ilitek-ili9881c.c | 232 ++++++++++++++++++++++++++
> 1 file changed, 232 insertions(+)
>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH RFC v2 1/5] dt-bindings: display: panel: Fix port binding
2025-04-24 15:07 ` [PATCH RFC v2 1/5] dt-bindings: display: panel: Fix port binding Kory Maincent
@ 2025-04-28 7:32 ` Krzysztof Kozlowski
2025-04-28 10:16 ` Kory Maincent
0 siblings, 1 reply; 11+ messages in thread
From: Krzysztof Kozlowski @ 2025-04-28 7:32 UTC (permalink / raw)
To: Kory Maincent
Cc: Neil Armstrong, Jessica Zhang, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, David Airlie, Simona Vetter, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Thierry Reding,
Laurent Pinchart, Thomas Petazzoni, Miquel Raynal, dri-devel,
linux-kernel, devicetree
On Thu, Apr 24, 2025 at 05:07:39PM GMT, Kory Maincent wrote:
> Faced a binding error check while adding the data-lanes property in the
> ilitek,ili9881c binding. See the next patch for the binding changes.
> Here is the error:
> Documentation/devicetree/bindings/display/panel/ilitek,ili9881c.example.dtb:
> panel@0: port:endpoint: Unevaluated properties are not allowed
> ('data-lanes' was unexpected)
There is no error at this point so your rationale is not correct. You
cannot use possible error as reason to fix something... You can use
instead other arguments that the binding is incomplete or incorrect.
>
> Change the reference of properties/port to $defs/port-base to makes it
> work.
> The only difference between port and port-base is the unevaluatedProperty
> set to false. I have tried to use properties/port in both panel-common
> and ilitek,ili9881c bindings but the error is still there. The only way
> to not face the error is to use $defs/port-base reference. I don't
> really understand the ins and outs, maybe it is a issue from the binding
> check tool.
>
> Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>
> ---
>
> Changes in v2:
> - New patch
> ---
> Documentation/devicetree/bindings/display/panel/panel-common.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/display/panel/panel-common.yaml b/Documentation/devicetree/bindings/display/panel/panel-common.yaml
> index 087415753d606ce67bceabaa9b0ba7d463282f92..635f67ced0cb7103684a1415ab740d83409a7dbb 100644
> --- a/Documentation/devicetree/bindings/display/panel/panel-common.yaml
> +++ b/Documentation/devicetree/bindings/display/panel/panel-common.yaml
> @@ -76,7 +76,7 @@ properties:
>
> # Connectivity
> port:
> - $ref: /schemas/graph.yaml#/properties/port
> + $ref: /schemas/graph.yaml#/$defs/port-base
This allows anything in the port in every other binding, so is not
correct. You need to fully describe the port here with
additionalProps:false, probably. Just like every other binding with
port-base is doing.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH RFC v2 2/5] dt-bindings: display: panel: ili9881c: Add data-lanes property
2025-04-24 15:07 ` [PATCH RFC v2 2/5] dt-bindings: display: panel: ili9881c: Add data-lanes property Kory Maincent
@ 2025-04-28 7:33 ` Krzysztof Kozlowski
0 siblings, 0 replies; 11+ messages in thread
From: Krzysztof Kozlowski @ 2025-04-28 7:33 UTC (permalink / raw)
To: Kory Maincent
Cc: Neil Armstrong, Jessica Zhang, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, David Airlie, Simona Vetter, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Thierry Reding,
Laurent Pinchart, Thomas Petazzoni, Miquel Raynal, dri-devel,
linux-kernel, devicetree
On Thu, Apr 24, 2025 at 05:07:40PM GMT, Kory Maincent wrote:
> Add the data-lanes property to specify the number of DSI lanes used by the
> panel. This allows configuring the panel for either two, three or four
> lanes.
That's the property of DSI controller, not the panel. I do not
understand why this is different than every other panel binding and your
commit msg should explain that. If you do something than everyone else
it is a clear hint you need to explain that.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH RFC v2 1/5] dt-bindings: display: panel: Fix port binding
2025-04-28 7:32 ` Krzysztof Kozlowski
@ 2025-04-28 10:16 ` Kory Maincent
0 siblings, 0 replies; 11+ messages in thread
From: Kory Maincent @ 2025-04-28 10:16 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Neil Armstrong, Jessica Zhang, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, David Airlie, Simona Vetter, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Thierry Reding,
Laurent Pinchart, Thomas Petazzoni, Miquel Raynal, dri-devel,
linux-kernel, devicetree
On Mon, 28 Apr 2025 09:32:21 +0200
Krzysztof Kozlowski <krzk@kernel.org> wrote:
> On Thu, Apr 24, 2025 at 05:07:39PM GMT, Kory Maincent wrote:
> > Faced a binding error check while adding the data-lanes property in the
> > ilitek,ili9881c binding. See the next patch for the binding changes.
> > Here is the error:
> > Documentation/devicetree/bindings/display/panel/ilitek,ili9881c.example.dtb:
> > panel@0: port:endpoint: Unevaluated properties are not allowed
> > ('data-lanes' was unexpected)
>
> There is no error at this point so your rationale is not correct. You
> cannot use possible error as reason to fix something... You can use
> instead other arguments that the binding is incomplete or incorrect.
As I have said in the cover letter, I faced this error and this patch fixed it
but I didn't get the ins and outs.
Indeed, I didn't understand the conflict between the port definition in
panel-common and the panel binding change from the 2nd patch.
> > Change the reference of properties/port to $defs/port-base to makes it
> > work.
> > The only difference between port and port-base is the unevaluatedProperty
> > set to false. I have tried to use properties/port in both panel-common
> > and ilitek,ili9881c bindings but the error is still there. The only way
> > to not face the error is to use $defs/port-base reference. I don't
> > really understand the ins and outs, maybe it is a issue from the binding
> > check tool.
> >
> > Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>
> > ---
> >
> > Changes in v2:
> > - New patch
> > ---
> > Documentation/devicetree/bindings/display/panel/panel-common.yaml | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git
> > a/Documentation/devicetree/bindings/display/panel/panel-common.yaml
> > b/Documentation/devicetree/bindings/display/panel/panel-common.yaml index
> > 087415753d606ce67bceabaa9b0ba7d463282f92..635f67ced0cb7103684a1415ab740d83409a7dbb
> > 100644 ---
> > a/Documentation/devicetree/bindings/display/panel/panel-common.yaml +++
> > b/Documentation/devicetree/bindings/display/panel/panel-common.yaml @@
> > -76,7 +76,7 @@ properties: # Connectivity port:
> > - $ref: /schemas/graph.yaml#/properties/port
> > + $ref: /schemas/graph.yaml#/$defs/port-base
>
> This allows anything in the port in every other binding, so is not
> correct. You need to fully describe the port here with
> additionalProps:false, probably. Just like every other binding with
> port-base is doing.
Yeah that was expected.
As I said I tried with port-base but it throw me this error and I didn't manage
to remove it with only the panel binding change for now.
Regards,
--
Köry Maincent, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2025-04-28 10:16 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-04-24 15:07 [PATCH RFC v2 0/5] Add support for Saef SFTO340XC panel Kory Maincent
2025-04-24 15:07 ` [PATCH RFC v2 1/5] dt-bindings: display: panel: Fix port binding Kory Maincent
2025-04-28 7:32 ` Krzysztof Kozlowski
2025-04-28 10:16 ` Kory Maincent
2025-04-24 15:07 ` [PATCH RFC v2 2/5] dt-bindings: display: panel: ili9881c: Add data-lanes property Kory Maincent
2025-04-28 7:33 ` Krzysztof Kozlowski
2025-04-24 15:07 ` [PATCH RFC v2 3/5] drm/panel: ilitek-ili9881c: Add support for two-lane configuration Kory Maincent
2025-04-26 3:31 ` Dmitry Baryshkov
2025-04-24 15:07 ` [PATCH RFC v2 4/5] dt-bindings: ili9881c: Add Saef SFTO340XC support Kory Maincent
2025-04-24 15:07 ` [PATCH RFC v2 5/5] drm: panel: Add Saef SFTO340XC LCD panel Kory Maincent
2025-04-26 3:32 ` Dmitry Baryshkov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®