* [PATCH][next] tpm: remove extraneous space after newline \n
@ 2025-04-29 16:38 Colin Ian King
2025-04-29 17:00 ` Christophe JAILLET
2025-04-30 5:20 ` Dan Carpenter
0 siblings, 2 replies; 3+ messages in thread
From: Colin Ian King @ 2025-04-29 16:38 UTC (permalink / raw)
To: Peter Huewe, Jarkko Sakkinen, Jason Gunthorpe, linux-integrity
Cc: kernel-janitors, linux-kernel
There is an extraneous space after a \n in a printk statement.
Remove it.
Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
---
drivers/char/tpm/eventlog/tpm1.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/char/tpm/eventlog/tpm1.c b/drivers/char/tpm/eventlog/tpm1.c
index 12ee42a31c71..566f4df58d48 100644
--- a/drivers/char/tpm/eventlog/tpm1.c
+++ b/drivers/char/tpm/eventlog/tpm1.c
@@ -258,7 +258,7 @@ static int tpm1_ascii_bios_measurements_show(struct seq_file *m, void *v)
eventname = kmalloc(MAX_TEXT_EVENT, GFP_KERNEL);
if (!eventname) {
- printk(KERN_ERR "%s: ERROR - No Memory for event name\n ",
+ printk(KERN_ERR "%s: ERROR - No Memory for event name\n",
__func__);
return -EFAULT;
}
--
2.49.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH][next] tpm: remove extraneous space after newline \n
2025-04-29 16:38 [PATCH][next] tpm: remove extraneous space after newline \n Colin Ian King
@ 2025-04-29 17:00 ` Christophe JAILLET
2025-04-30 5:20 ` Dan Carpenter
1 sibling, 0 replies; 3+ messages in thread
From: Christophe JAILLET @ 2025-04-29 17:00 UTC (permalink / raw)
To: Colin Ian King, Peter Huewe, Jarkko Sakkinen, Jason Gunthorpe,
linux-integrity
Cc: kernel-janitors, linux-kernel
Le 29/04/2025 à 18:38, Colin Ian King a écrit :
> There is an extraneous space after a \n in a printk statement.
> Remove it.
>
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
> ---
> drivers/char/tpm/eventlog/tpm1.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/char/tpm/eventlog/tpm1.c b/drivers/char/tpm/eventlog/tpm1.c
> index 12ee42a31c71..566f4df58d48 100644
> --- a/drivers/char/tpm/eventlog/tpm1.c
> +++ b/drivers/char/tpm/eventlog/tpm1.c
> @@ -258,7 +258,7 @@ static int tpm1_ascii_bios_measurements_show(struct seq_file *m, void *v)
>
> eventname = kmalloc(MAX_TEXT_EVENT, GFP_KERNEL);
> if (!eventname) {
> - printk(KERN_ERR "%s: ERROR - No Memory for event name\n ",
> + printk(KERN_ERR "%s: ERROR - No Memory for event name\n",
> __func__);
> return -EFAULT;
> }
Hi,,
kmalloc() is already verbose, so I think that the whole printk() could
be removed.
CJ
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH][next] tpm: remove extraneous space after newline \n
2025-04-29 16:38 [PATCH][next] tpm: remove extraneous space after newline \n Colin Ian King
2025-04-29 17:00 ` Christophe JAILLET
@ 2025-04-30 5:20 ` Dan Carpenter
1 sibling, 0 replies; 3+ messages in thread
From: Dan Carpenter @ 2025-04-30 5:20 UTC (permalink / raw)
To: Colin Ian King
Cc: Peter Huewe, Jarkko Sakkinen, Jason Gunthorpe, linux-integrity,
kernel-janitors, linux-kernel
On Tue, Apr 29, 2025 at 05:38:59PM +0100, Colin Ian King wrote:
> There is an extraneous space after a \n in a printk statement.
> Remove it.
>
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
> ---
> drivers/char/tpm/eventlog/tpm1.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/char/tpm/eventlog/tpm1.c b/drivers/char/tpm/eventlog/tpm1.c
> index 12ee42a31c71..566f4df58d48 100644
> --- a/drivers/char/tpm/eventlog/tpm1.c
> +++ b/drivers/char/tpm/eventlog/tpm1.c
> @@ -258,7 +258,7 @@ static int tpm1_ascii_bios_measurements_show(struct seq_file *m, void *v)
>
> eventname = kmalloc(MAX_TEXT_EVENT, GFP_KERNEL);
> if (!eventname) {
> - printk(KERN_ERR "%s: ERROR - No Memory for event name\n ",
> + printk(KERN_ERR "%s: ERROR - No Memory for event name\n",
> __func__);
> return -EFAULT;
Let's change this to -ENOMEM as well.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-04-30 5:21 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-04-29 16:38 [PATCH][next] tpm: remove extraneous space after newline \n Colin Ian King
2025-04-29 17:00 ` Christophe JAILLET
2025-04-30 5:20 ` Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®