mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Joel Fernandes <joelagnelf@nvidia.com>
To: linux-kernel@vger.kernel.org, Ingo Molnar <mingo@redhat.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Juri Lelli <juri.lelli@redhat.com>,
	Vincent Guittot <vincent.guittot@linaro.org>,
	Dietmar Eggemann <dietmar.eggemann@arm.com>,
	Steven Rostedt <rostedt@goodmis.org>,
	Ben Segall <bsegall@google.com>, Mel Gorman <mgorman@suse.de>,
	Valentin Schneider <vschneid@redhat.com>
Cc: Joel Fernandes <joelagnelf@nvidia.com>, Tejun Heo <tj@kernel.org>,
	David Vernet <void@manifault.com>,
	Andrea Righi <arighi@nvidia.com>,
	Changwoo Min <changwoo@igalia.com>
Subject: [PATCH v2 08/10] sched/deadline: Add support to remove DL server bandwidth
Date: Mon,  2 Jun 2025 14:01:04 -0400	[thread overview]
Message-ID: <20250602180110.816225-9-joelagnelf@nvidia.com> (raw)
In-Reply-To: <20250602180110.816225-1-joelagnelf@nvidia.com>

The DL server for sched_ext will have its bandwidth removed when
sched_ext is unloaded. Add support to DEADLINE for this, so that the
sched_ext DL server may do so.

Signed-off-by: Joel Fernandes <joelagnelf@nvidia.com>
---
 kernel/sched/deadline.c | 57 +++++++++++++++++++++++++++++++++++++++++
 kernel/sched/sched.h    |  1 +
 2 files changed, 58 insertions(+)

diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c
index 4ed61266f3ea..e585ff39fcc3 100644
--- a/kernel/sched/deadline.c
+++ b/kernel/sched/deadline.c
@@ -1752,6 +1752,63 @@ int dl_server_apply_params(struct sched_dl_entity *dl_se, u64 runtime, u64 perio
 	return retval;
 }
 
+/**
+ * dl_server_remove_params - Remove bandwidth reservation for a DL server
+ * @dl_se: The DL server entity to remove bandwidth for
+ *
+ * This function removes the bandwidth reservation for a DL server entity,
+ * cleaning up all bandwidth accounting and server state.
+ *
+ * Returns: 0 on success, negative error code on failure
+ */
+int dl_server_remove_params(struct sched_dl_entity *dl_se)
+{
+	struct rq *rq = dl_se->rq;
+	int cpu = cpu_of(rq);
+	struct dl_bw *dl_b;
+	int cpus;
+
+	if (!dl_se->dl_runtime)
+		return 0;  /* Already disabled */
+
+	/*
+	 * First dequeue if still queued. It should not be queued since
+	 * we call this only after the last dl_server_stop().
+	 */
+	if (WARN_ON_ONCE(on_dl_rq(dl_se)))
+		dequeue_dl_entity(dl_se, DEQUEUE_SLEEP);
+
+	/* Cancel any pending timers */
+	hrtimer_try_to_cancel(&dl_se->dl_timer);
+	hrtimer_try_to_cancel(&dl_se->inactive_timer);
+
+	/* Remove bandwidth from both runqueue and root domain accounting */
+	dl_b = dl_bw_of(cpu);
+	guard(raw_spinlock)(&dl_b->lock);
+	cpus = dl_bw_cpus(cpu);
+	if (!cpus)
+		return 0;
+
+	sub_rq_bw(dl_se, &rq->dl);
+	__dl_sub(dl_b, dl_se->dl_bw, cpus);
+
+	/*
+	 * If server was active and consuming bandwidth, remove it from
+	 * running bandwidth accounting. This should not happen because
+	 * we call this only after the last dl_server_stop().
+	 */
+	if (WARN_ON_ONCE(!dl_se->dl_non_contending))
+		sub_running_bw(dl_se, &rq->dl);
+
+	/*
+	 * Clear all server parameters. This will also clear ->dl_server so
+	 * the next dl_server_apply_params() will reconfigure the server.
+	 */
+	__dl_clear_params(dl_se);
+
+	return 0;
+}
+
 /*
  * Update the current task's runtime statistics (provided it is still
  * a -deadline task and has not been removed from the dl_rq).
diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h
index d206421b1146..e6af0c1fc985 100644
--- a/kernel/sched/sched.h
+++ b/kernel/sched/sched.h
@@ -393,6 +393,7 @@ extern void ext_server_init(struct rq *rq);
 extern void __dl_server_attach_root(struct sched_dl_entity *dl_se, struct rq *rq);
 extern int dl_server_apply_params(struct sched_dl_entity *dl_se,
 		    u64 runtime, u64 period, bool init);
+extern int dl_server_remove_params(struct sched_dl_entity *dl_se);
 
 static inline bool dl_server_active(struct sched_dl_entity *dl_se)
 {
-- 
2.43.0


  parent reply	other threads:[~2025-06-02 18:01 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-02 18:00 [PATCH v2 00/10] Add a deadline server for sched_ext tasks Joel Fernandes
2025-06-02 18:00 ` [PATCH v2 01/10] sched: Add support to pick functions to take rf Joel Fernandes
2025-06-03  0:05   ` Tejun Heo
2025-06-03 13:38     ` Joel Fernandes
2025-06-03 18:18       ` Tejun Heo
2025-06-02 18:00 ` [PATCH v2 02/10] sched: Add a server arg to dl_server_update_idle_time() Joel Fernandes
2025-06-02 18:00 ` [PATCH v2 03/10] sched/ext: Add a DL server for sched_ext tasks Joel Fernandes
2025-06-03  0:23   ` Tejun Heo
2025-06-12 16:54     ` Joel Fernandes
2025-06-12 18:16       ` Tejun Heo
2025-06-02 18:01 ` [PATCH v2 04/10] sched/debug: Fix updating of ppos on server write ops Joel Fernandes
2025-06-04 10:04   ` Juri Lelli
2025-06-02 18:01 ` [PATCH v2 05/10] sched/debug: Stop and start server based on if it was active Joel Fernandes
2025-06-02 18:01 ` [PATCH v2 06/10] sched/debug: Add support to change sched_ext server params Joel Fernandes
2025-06-04 10:02   ` Juri Lelli
2025-06-04 18:40     ` Tejun Heo
2025-06-05 18:45       ` Joel Fernandes
2025-06-02 18:01 ` [PATCH v2 07/10] sched/deadline: Clear the defer params Joel Fernandes
2025-06-02 18:01 ` Joel Fernandes [this message]
2025-06-02 18:01 ` [PATCH v2 09/10] sched/ext: Relinquish DL server reservations when not needed Joel Fernandes
2025-06-03  4:29   ` Joel Fernandes
2025-06-02 18:01 ` [PATCH v2 10/10] selftests/sched_ext: Add test for sched_ext dl_server Joel Fernandes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250602180110.816225-9-joelagnelf@nvidia.com \
    --to=joelagnelf@nvidia.com \
    --cc=arighi@nvidia.com \
    --cc=bsegall@google.com \
    --cc=changwoo@igalia.com \
    --cc=dietmar.eggemann@arm.com \
    --cc=juri.lelli@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mgorman@suse.de \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=tj@kernel.org \
    --cc=vincent.guittot@linaro.org \
    --cc=void@manifault.com \
    --cc=vschneid@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®