mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Juri Lelli <juri.lelli@redhat.com>
To: Joel Fernandes <joelagnelf@nvidia.com>
Cc: linux-kernel@vger.kernel.org, Ingo Molnar <mingo@redhat.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Vincent Guittot <vincent.guittot@linaro.org>,
	Dietmar Eggemann <dietmar.eggemann@arm.com>,
	Steven Rostedt <rostedt@goodmis.org>,
	Ben Segall <bsegall@google.com>, Mel Gorman <mgorman@suse.de>,
	Valentin Schneider <vschneid@redhat.com>,
	Tejun Heo <tj@kernel.org>, David Vernet <void@manifault.com>,
	Andrea Righi <arighi@nvidia.com>,
	Changwoo Min <changwoo@igalia.com>
Subject: Re: [PATCH v2 04/10] sched/debug: Fix updating of ppos on server write ops
Date: Wed, 4 Jun 2025 12:04:01 +0200	[thread overview]
Message-ID: <aEAaEc0-WAnklXjh@jlelli-thinkpadt14gen4.remote.csb> (raw)
In-Reply-To: <20250602180110.816225-5-joelagnelf@nvidia.com>

Hi Joel,

On 02/06/25 14:01, Joel Fernandes wrote:
> Updating "ppos" on error conditions does not make much sense. The pattern
> is to return the error code directly without modifying the position, or
> modify the position on success and return the number of bytes written.
> 
> Since on success, the return value of apply is 0, there is no point in
> modifying ppos either. Fix it by removing all this and just returning
> error code or number of bytes written on success.

Looks like patches 04, 05 and 07 are standalone fixes. If that is indeed
the case maybe we could move them to the start of this series so that
they can picked up independently (or split them to a separate series)?

Thanks,
Juri


  reply	other threads:[~2025-06-04 10:04 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-02 18:00 [PATCH v2 00/10] Add a deadline server for sched_ext tasks Joel Fernandes
2025-06-02 18:00 ` [PATCH v2 01/10] sched: Add support to pick functions to take rf Joel Fernandes
2025-06-03  0:05   ` Tejun Heo
2025-06-03 13:38     ` Joel Fernandes
2025-06-03 18:18       ` Tejun Heo
2025-06-02 18:00 ` [PATCH v2 02/10] sched: Add a server arg to dl_server_update_idle_time() Joel Fernandes
2025-06-02 18:00 ` [PATCH v2 03/10] sched/ext: Add a DL server for sched_ext tasks Joel Fernandes
2025-06-03  0:23   ` Tejun Heo
2025-06-12 16:54     ` Joel Fernandes
2025-06-12 18:16       ` Tejun Heo
2025-06-02 18:01 ` [PATCH v2 04/10] sched/debug: Fix updating of ppos on server write ops Joel Fernandes
2025-06-04 10:04   ` Juri Lelli [this message]
2025-06-02 18:01 ` [PATCH v2 05/10] sched/debug: Stop and start server based on if it was active Joel Fernandes
2025-06-02 18:01 ` [PATCH v2 06/10] sched/debug: Add support to change sched_ext server params Joel Fernandes
2025-06-04 10:02   ` Juri Lelli
2025-06-04 18:40     ` Tejun Heo
2025-06-05 18:45       ` Joel Fernandes
2025-06-02 18:01 ` [PATCH v2 07/10] sched/deadline: Clear the defer params Joel Fernandes
2025-06-02 18:01 ` [PATCH v2 08/10] sched/deadline: Add support to remove DL server bandwidth Joel Fernandes
2025-06-02 18:01 ` [PATCH v2 09/10] sched/ext: Relinquish DL server reservations when not needed Joel Fernandes
2025-06-03  4:29   ` Joel Fernandes
2025-06-02 18:01 ` [PATCH v2 10/10] selftests/sched_ext: Add test for sched_ext dl_server Joel Fernandes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aEAaEc0-WAnklXjh@jlelli-thinkpadt14gen4.remote.csb \
    --to=juri.lelli@redhat.com \
    --cc=arighi@nvidia.com \
    --cc=bsegall@google.com \
    --cc=changwoo@igalia.com \
    --cc=dietmar.eggemann@arm.com \
    --cc=joelagnelf@nvidia.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mgorman@suse.de \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=tj@kernel.org \
    --cc=vincent.guittot@linaro.org \
    --cc=void@manifault.com \
    --cc=vschneid@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®