* [PATCHv2] media: venus: protect against spurious interrupts during probe
@ 2025-06-06 12:33 Jorge Ramirez-Ortiz
2025-06-06 14:43 ` Bryan O'Donoghue
0 siblings, 1 reply; 2+ messages in thread
From: Jorge Ramirez-Ortiz @ 2025-06-06 12:33 UTC (permalink / raw)
To: jorge.ramirez, quic_vgarodia, quic_dikshita, bryan.odonoghue, mchehab
Cc: linux-media, linux-arm-msm, linux-kernel
Make sure the interrupt handler is initialized before the interrupt is
registered.
If the IRQ is registered before hfi_create(), it's possible that an
interrupt fires before the handler setup is complete, leading to a NULL
dereference.
This error condition has been observed during system boot on Rb3Gen2.
Signed-off-by: Jorge Ramirez-Ortiz <jorge.ramirez@oss.qualcomm.com>
---
v2: fix authorship
fix spelling mistake
drivers/media/platform/qcom/venus/core.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/media/platform/qcom/venus/core.c b/drivers/media/platform/qcom/venus/core.c
index d305d74bb152..5bd99d0aafe4 100644
--- a/drivers/media/platform/qcom/venus/core.c
+++ b/drivers/media/platform/qcom/venus/core.c
@@ -424,13 +424,13 @@ static int venus_probe(struct platform_device *pdev)
INIT_DELAYED_WORK(&core->work, venus_sys_error_handler);
init_waitqueue_head(&core->sys_err_done);
- ret = devm_request_threaded_irq(dev, core->irq, hfi_isr, venus_isr_thread,
- IRQF_TRIGGER_HIGH | IRQF_ONESHOT,
- "venus", core);
+ ret = hfi_create(core, &venus_core_ops);
if (ret)
goto err_core_put;
- ret = hfi_create(core, &venus_core_ops);
+ ret = devm_request_threaded_irq(dev, core->irq, hfi_isr, venus_isr_thread,
+ IRQF_TRIGGER_HIGH | IRQF_ONESHOT,
+ "venus", core);
if (ret)
goto err_core_put;
--
2.34.1
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCHv2] media: venus: protect against spurious interrupts during probe
2025-06-06 12:33 [PATCHv2] media: venus: protect against spurious interrupts during probe Jorge Ramirez-Ortiz
@ 2025-06-06 14:43 ` Bryan O'Donoghue
0 siblings, 0 replies; 2+ messages in thread
From: Bryan O'Donoghue @ 2025-06-06 14:43 UTC (permalink / raw)
To: Jorge Ramirez-Ortiz, quic_vgarodia, quic_dikshita, mchehab
Cc: linux-media, linux-arm-msm, linux-kernel
On 06/06/2025 13:33, Jorge Ramirez-Ortiz wrote:
> Make sure the interrupt handler is initialized before the interrupt is
> registered.
>
> If the IRQ is registered before hfi_create(), it's possible that an
> interrupt fires before the handler setup is complete, leading to a NULL
> dereference.
>
> This error condition has been observed during system boot on Rb3Gen2.
>
> Signed-off-by: Jorge Ramirez-Ortiz <jorge.ramirez@oss.qualcomm.com>
> ---
> v2: fix authorship
> fix spelling mistake
>
> drivers/media/platform/qcom/venus/core.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/media/platform/qcom/venus/core.c b/drivers/media/platform/qcom/venus/core.c
> index d305d74bb152..5bd99d0aafe4 100644
> --- a/drivers/media/platform/qcom/venus/core.c
> +++ b/drivers/media/platform/qcom/venus/core.c
> @@ -424,13 +424,13 @@ static int venus_probe(struct platform_device *pdev)
> INIT_DELAYED_WORK(&core->work, venus_sys_error_handler);
> init_waitqueue_head(&core->sys_err_done);
>
> - ret = devm_request_threaded_irq(dev, core->irq, hfi_isr, venus_isr_thread,
> - IRQF_TRIGGER_HIGH | IRQF_ONESHOT,
> - "venus", core);
> + ret = hfi_create(core, &venus_core_ops);
> if (ret)
> goto err_core_put;
>
> - ret = hfi_create(core, &venus_core_ops);
> + ret = devm_request_threaded_irq(dev, core->irq, hfi_isr, venus_isr_thread,
> + IRQF_TRIGGER_HIGH | IRQF_ONESHOT,
> + "venus", core);
> if (ret)
> goto err_core_put;
>
Please add a Fixes: tag.
---
bod
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-06-06 14:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-06-06 12:33 [PATCHv2] media: venus: protect against spurious interrupts during probe Jorge Ramirez-Ortiz
2025-06-06 14:43 ` Bryan O'Donoghue
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®