* [PATCH v1] wifi: iwlegacy: convert to use secs_to_jiffies()
@ 2025-06-12 2:14 Yuesong Li
2025-06-13 16:11 ` Stanislaw Gruszka
0 siblings, 1 reply; 2+ messages in thread
From: Yuesong Li @ 2025-06-12 2:14 UTC (permalink / raw)
To: Stanislaw Gruszka, linux-wireless, linux-kernel
Cc: opensource.kernel, Yuesong Li
Since secs_to_jiffies()(commit:b35108a51cf7) has been introduced, we can
use it to avoid scaling the time to msec.
Signed-off-by: Yuesong Li <liyuesong@vivo.com>
---
drivers/net/wireless/intel/iwlegacy/4965-mac.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/intel/iwlegacy/4965-mac.c b/drivers/net/wireless/intel/iwlegacy/4965-mac.c
index 8e58e97a148f..24a39a968db0 100644
--- a/drivers/net/wireless/intel/iwlegacy/4965-mac.c
+++ b/drivers/net/wireless/intel/iwlegacy/4965-mac.c
@@ -1382,7 +1382,7 @@ il4965_hdl_stats(struct il_priv *il, struct il_rx_buf *rxb)
* we get a thermal update even if the uCode doesn't give us one
*/
mod_timer(&il->stats_periodic,
- jiffies + msecs_to_jiffies(recalib_seconds * 1000));
+ jiffies + secs_to_jiffies(recalib_seconds));
if (unlikely(!test_bit(S_SCANNING, &il->status)) &&
(pkt->hdr.cmd == N_STATS)) {
--
2.34.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH v1] wifi: iwlegacy: convert to use secs_to_jiffies()
2025-06-12 2:14 [PATCH v1] wifi: iwlegacy: convert to use secs_to_jiffies() Yuesong Li
@ 2025-06-13 16:11 ` Stanislaw Gruszka
0 siblings, 0 replies; 2+ messages in thread
From: Stanislaw Gruszka @ 2025-06-13 16:11 UTC (permalink / raw)
To: Yuesong Li; +Cc: linux-wireless, linux-kernel, opensource.kernel
On Thu, Jun 12, 2025 at 10:14:44AM +0800, Yuesong Li wrote:
> Since secs_to_jiffies()(commit:b35108a51cf7) has been introduced, we can
> use it to avoid scaling the time to msec.
>
> Signed-off-by: Yuesong Li <liyuesong@vivo.com>
Acked-by: Stanislaw Gruszka <stf_xl@wp.pl>
> ---
> drivers/net/wireless/intel/iwlegacy/4965-mac.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/intel/iwlegacy/4965-mac.c b/drivers/net/wireless/intel/iwlegacy/4965-mac.c
> index 8e58e97a148f..24a39a968db0 100644
> --- a/drivers/net/wireless/intel/iwlegacy/4965-mac.c
> +++ b/drivers/net/wireless/intel/iwlegacy/4965-mac.c
> @@ -1382,7 +1382,7 @@ il4965_hdl_stats(struct il_priv *il, struct il_rx_buf *rxb)
> * we get a thermal update even if the uCode doesn't give us one
> */
> mod_timer(&il->stats_periodic,
> - jiffies + msecs_to_jiffies(recalib_seconds * 1000));
> + jiffies + secs_to_jiffies(recalib_seconds));
>
> if (unlikely(!test_bit(S_SCANNING, &il->status)) &&
> (pkt->hdr.cmd == N_STATS)) {
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-06-13 16:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-06-12 2:14 [PATCH v1] wifi: iwlegacy: convert to use secs_to_jiffies() Yuesong Li
2025-06-13 16:11 ` Stanislaw Gruszka
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®