mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] spi: spi-fsl-dspi: Revert unintended dependency change in config SPI_FSL_DSPI
@ 2025-06-16  9:19 Lukas Bulwahn
  2025-06-16  9:34 ` James Clark
  2025-06-16 16:20 ` Mark Brown
  0 siblings, 2 replies; 3+ messages in thread
From: Lukas Bulwahn @ 2025-06-16  9:19 UTC (permalink / raw)
  To: Mark Brown, James Clark, Ciprian Marian Costea, Larisa Grigore,
	Stoica Cosmin-Stefan, linux-spi
  Cc: kernel-janitors, linux-kernel, Lukas Bulwahn

From: Lukas Bulwahn <lukas.bulwahn@redhat.com>

Commit 9a30e332c36c ("spi: spi-fsl-dspi: Enable support for S32G
platforms") reworks the dependencies of config SPI_FSL_DSPI, but introduces
a typo changing the dependency to M5441x to a dependency on a non-existing
config M54541x.

Revert the unintended change to depend on the config M5441x.

Fixes: 9a30e332c36c ("spi: spi-fsl-dspi: Enable support for S32G platforms")
Signed-off-by: Lukas Bulwahn <lukas.bulwahn@redhat.com>
---
 drivers/spi/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig
index 60eb65c927b1..f2d2295a5501 100644
--- a/drivers/spi/Kconfig
+++ b/drivers/spi/Kconfig
@@ -647,7 +647,7 @@ config SPI_FSL_SPI
 config SPI_FSL_DSPI
 	tristate "Freescale DSPI controller"
 	select REGMAP_MMIO
-	depends on ARCH_MXC || ARCH_NXP || M54541x || COMPILE_TEST
+	depends on ARCH_MXC || ARCH_NXP || M5441x || COMPILE_TEST
 	help
 	  This enables support for the Freescale DSPI controller in master
 	  mode. S32, VF610, LS1021A and ColdFire platforms uses the controller.
-- 
2.49.0


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] spi: spi-fsl-dspi: Revert unintended dependency change in config SPI_FSL_DSPI
  2025-06-16  9:19 [PATCH] spi: spi-fsl-dspi: Revert unintended dependency change in config SPI_FSL_DSPI Lukas Bulwahn
@ 2025-06-16  9:34 ` James Clark
  2025-06-16 16:20 ` Mark Brown
  1 sibling, 0 replies; 3+ messages in thread
From: James Clark @ 2025-06-16  9:34 UTC (permalink / raw)
  To: Lukas Bulwahn, Mark Brown, Ciprian Marian Costea, Larisa Grigore,
	Stoica Cosmin-Stefan, linux-spi
  Cc: kernel-janitors, linux-kernel, Lukas Bulwahn



On 16/06/2025 10:19 am, Lukas Bulwahn wrote:
> From: Lukas Bulwahn <lukas.bulwahn@redhat.com>
> 
> Commit 9a30e332c36c ("spi: spi-fsl-dspi: Enable support for S32G
> platforms") reworks the dependencies of config SPI_FSL_DSPI, but introduces
> a typo changing the dependency to M5441x to a dependency on a non-existing
> config M54541x.
> 
> Revert the unintended change to depend on the config M5441x.
> 
> Fixes: 9a30e332c36c ("spi: spi-fsl-dspi: Enable support for S32G platforms")
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@redhat.com>
> ---
>   drivers/spi/Kconfig | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig
> index 60eb65c927b1..f2d2295a5501 100644
> --- a/drivers/spi/Kconfig
> +++ b/drivers/spi/Kconfig
> @@ -647,7 +647,7 @@ config SPI_FSL_SPI
>   config SPI_FSL_DSPI
>   	tristate "Freescale DSPI controller"
>   	select REGMAP_MMIO
> -	depends on ARCH_MXC || ARCH_NXP || M54541x || COMPILE_TEST
> +	depends on ARCH_MXC || ARCH_NXP || M5441x || COMPILE_TEST
>   	help
>   	  This enables support for the Freescale DSPI controller in master
>   	  mode. S32, VF610, LS1021A and ColdFire platforms uses the controller.

How did that get there... Sorry for the breakage

Reviewed-by: James Clark <james.clark@linaro.org>


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] spi: spi-fsl-dspi: Revert unintended dependency change in config SPI_FSL_DSPI
  2025-06-16  9:19 [PATCH] spi: spi-fsl-dspi: Revert unintended dependency change in config SPI_FSL_DSPI Lukas Bulwahn
  2025-06-16  9:34 ` James Clark
@ 2025-06-16 16:20 ` Mark Brown
  1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2025-06-16 16:20 UTC (permalink / raw)
  To: James Clark, Ciprian Marian Costea, Larisa Grigore,
	Stoica Cosmin-Stefan, linux-spi, Lukas Bulwahn
  Cc: kernel-janitors, linux-kernel, Lukas Bulwahn

On Mon, 16 Jun 2025 11:19:55 +0200, Lukas Bulwahn wrote:
> Commit 9a30e332c36c ("spi: spi-fsl-dspi: Enable support for S32G
> platforms") reworks the dependencies of config SPI_FSL_DSPI, but introduces
> a typo changing the dependency to M5441x to a dependency on a non-existing
> config M54541x.
> 
> Revert the unintended change to depend on the config M5441x.
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next

Thanks!

[1/1] spi: spi-fsl-dspi: Revert unintended dependency change in config SPI_FSL_DSPI
      commit: dce4bc30f42d313b4dc5832316196411b7f07ad0

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2025-06-16 16:20 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-06-16  9:19 [PATCH] spi: spi-fsl-dspi: Revert unintended dependency change in config SPI_FSL_DSPI Lukas Bulwahn
2025-06-16  9:34 ` James Clark
2025-06-16 16:20 ` Mark Brown

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®