From: Khalid Ali <khaliidcaliy@gmail.com>
To: tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
dave.hansen@linux.intel.com
Cc: x86@kernel.org, hpa@zytor.com, ardb@kernel.org,
ubizjak@gmail.com, brgerst@gmail.com,
linux-kernel@vger.kernel.org, Khalid Ali <khaliidcaliy@gmail.com>
Subject: [PATCH v3] x86/boot: Avoid writing to cr4 twice in startup_64()
Date: Tue, 15 Jul 2025 18:16:10 +0000 [thread overview]
Message-ID: <20250715181709.1040-1-khaliidcaliy@gmail.com> (raw)
From: Khalid Ali <khaliidcaliy@gmail.com>
When Initializing cr4 bit PSE and PGE, cr4 is written twice for
each bit. This is redundancy.
Instead, set both bits first and write CR4 once, avoiding redundant
writes. This makes consistent with cr0 writes, which is set bits and
write once.
Signed-off-by: Khalid Ali <khaliidcaliy@gmail.com>
---
arch/x86/kernel/head_64.S | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/arch/x86/kernel/head_64.S b/arch/x86/kernel/head_64.S
index 4390a28f7dad..dfb5390e5c9a 100644
--- a/arch/x86/kernel/head_64.S
+++ b/arch/x86/kernel/head_64.S
@@ -222,12 +222,9 @@ SYM_INNER_LABEL(common_startup_64, SYM_L_LOCAL)
/* Even if ignored in long mode, set PSE uniformly on all logical CPUs. */
btsl $X86_CR4_PSE_BIT, %ecx
- movq %rcx, %cr4
-
- /*
- * Set CR4.PGE to re-enable global translations.
- */
+ /* Set CR4.PGE to re-enable global translations. */
btsl $X86_CR4_PGE_BIT, %ecx
+
movq %rcx, %cr4
#ifdef CONFIG_SMP
--
2.49.0
next reply other threads:[~2025-07-15 18:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-15 18:16 Khalid Ali [this message]
2025-07-15 18:45 ` Nikolay Borisov
2025-07-15 19:05 ` [tip: x86/cleanups] x86/boot: Avoid redundant %cr4 write " tip-bot2 for Khalid Ali
2025-07-15 20:30 ` [PATCH v3] x86/boot: Avoid writing to cr4 twice " H. Peter Anvin
2025-07-15 20:31 ` H. Peter Anvin
2025-07-15 21:21 ` Andrew Cooper
2025-07-16 1:45 ` Borislav Petkov
2025-07-16 9:07 ` Khalid Ali
2025-07-16 13:27 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250715181709.1040-1-khaliidcaliy@gmail.com \
--to=khaliidcaliy@gmail.com \
--cc=ardb@kernel.org \
--cc=bp@alien8.de \
--cc=brgerst@gmail.com \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=ubizjak@gmail.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®