From: Michael Straube <straube.linux@gmail.com>
To: gregkh@linuxfoundation.org
Cc: hdegoede@redhat.com, Larry.Finger@lwfinger.net,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
Michael Straube <straube.linux@gmail.com>
Subject: [PATCH 09/11] staging: rtl8723bs: remove function pointer hal_reset_security_engine
Date: Tue, 15 Jul 2025 20:28:12 +0200 [thread overview]
Message-ID: <20250715182814.212708-10-straube.linux@gmail.com> (raw)
In-Reply-To: <20250715182814.212708-1-straube.linux@gmail.com>
The function pointer hal_reset_security_engine is never set. As a
consequence, the function rtw_hal_reset_security_engine does nothing.
Remove both to reduce dead code.
Signed-off-by: Michael Straube <straube.linux@gmail.com>
---
drivers/staging/rtl8723bs/hal/hal_intf.c | 8 --------
drivers/staging/rtl8723bs/include/hal_intf.h | 2 --
2 files changed, 10 deletions(-)
diff --git a/drivers/staging/rtl8723bs/hal/hal_intf.c b/drivers/staging/rtl8723bs/hal/hal_intf.c
index 29e0610f72f1..dea38bb8424d 100644
--- a/drivers/staging/rtl8723bs/hal/hal_intf.c
+++ b/drivers/staging/rtl8723bs/hal/hal_intf.c
@@ -73,8 +73,6 @@ uint rtw_hal_init(struct adapter *padapter)
if (padapter->registrypriv.notch_filter == 1)
rtw_hal_notch_filter(padapter, 1);
- rtw_hal_reset_security_engine(padapter);
-
rtw_sec_restore_wep_key(dvobj->padapters);
init_hw_mlme_ext(padapter);
@@ -293,12 +291,6 @@ void rtw_hal_notch_filter(struct adapter *adapter, bool enable)
hal_notch_filter_8723b(adapter, enable);
}
-void rtw_hal_reset_security_engine(struct adapter *adapter)
-{
- if (adapter->HalFunc.hal_reset_security_engine)
- adapter->HalFunc.hal_reset_security_engine(adapter);
-}
-
bool rtw_hal_c2h_valid(struct adapter *adapter, u8 *buf)
{
return c2h_evt_valid((struct c2h_evt_hdr_88xx *)buf);
diff --git a/drivers/staging/rtl8723bs/include/hal_intf.h b/drivers/staging/rtl8723bs/include/hal_intf.h
index ce3c6de8a325..d6fd692aedc8 100644
--- a/drivers/staging/rtl8723bs/include/hal_intf.h
+++ b/drivers/staging/rtl8723bs/include/hal_intf.h
@@ -161,7 +161,6 @@ enum hal_intf_ps_func {
typedef s32 (*c2h_id_filter)(u8 *c2h_evt);
struct hal_ops {
- void (*hal_reset_security_engine)(struct adapter *adapter);
c2h_id_filter c2h_id_filter_ccx;
};
@@ -253,7 +252,6 @@ void rtw_hal_dm_watchdog_in_lps(struct adapter *padapter);
s32 rtw_hal_xmit_thread_handler(struct adapter *padapter);
void rtw_hal_notch_filter(struct adapter *adapter, bool enable);
-void rtw_hal_reset_security_engine(struct adapter *adapter);
bool rtw_hal_c2h_valid(struct adapter *adapter, u8 *buf);
s32 rtw_hal_c2h_handler(struct adapter *adapter, u8 *c2h_evt);
--
2.50.1
next prev parent reply other threads:[~2025-07-15 18:28 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-15 18:28 [PATCH 00/11] staging: rtl8723bs: get rid of struct hal_ops Michael Straube
2025-07-15 18:28 ` [PATCH 01/11] staging: rtl8723bs: remove function pointer SetHalODMVarHandler Michael Straube
2025-07-15 18:28 ` [PATCH 02/11] staging: rtl8723bs: remove wrapper rtl8723b_SetHalODMVar Michael Straube
2025-07-15 18:28 ` [PATCH 03/11] staging: rtl8723bs: remove function pointer hal_notch_filter Michael Straube
2025-07-15 18:28 ` [PATCH 04/11] staging: rtl8723bs: remove function pointer c2h_handler Michael Straube
2025-07-15 18:28 ` [PATCH 05/11] staging: rtl8723bs: remove macro FillH2CCmd Michael Straube
2025-07-15 18:28 ` [PATCH 06/11] staging: rtl8723bs: remove function pointer fill_h2c_cmd Michael Straube
2025-07-15 18:28 ` [PATCH 07/11] staging: rtl8723bs: remove macro hal_xmit_handler Michael Straube
2025-07-15 18:28 ` [PATCH 08/11] staging: rtl8723bs: remove function pointer xmit_thread_handler Michael Straube
2025-07-15 18:28 ` Michael Straube [this message]
2025-07-15 18:28 ` [PATCH 10/11] staging: rtl8723bs: remove function pointer c2h_id_filter Michael Straube
2025-07-15 18:28 ` [PATCH 11/11] staging: rtl8723bs: remove struct hal_ops Michael Straube
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250715182814.212708-10-straube.linux@gmail.com \
--to=straube.linux@gmail.com \
--cc=Larry.Finger@lwfinger.net \
--cc=gregkh@linuxfoundation.org \
--cc=hdegoede@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®