From: Michael Straube <straube.linux@gmail.com>
To: gregkh@linuxfoundation.org
Cc: hdegoede@redhat.com, Larry.Finger@lwfinger.net,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
Michael Straube <straube.linux@gmail.com>
Subject: [PATCH 04/11] staging: rtl8723bs: remove function pointer c2h_handler
Date: Tue, 15 Jul 2025 20:28:07 +0200 [thread overview]
Message-ID: <20250715182814.212708-5-straube.linux@gmail.com> (raw)
In-Reply-To: <20250715182814.212708-1-straube.linux@gmail.com>
Remove function pointer c2h_handler and use c2h_handler_8723b directly
to reduce code complexity.
Signed-off-by: Michael Straube <straube.linux@gmail.com>
---
drivers/staging/rtl8723bs/hal/hal_intf.c | 6 +-----
drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c | 1 -
drivers/staging/rtl8723bs/include/hal_intf.h | 1 -
3 files changed, 1 insertion(+), 7 deletions(-)
diff --git a/drivers/staging/rtl8723bs/hal/hal_intf.c b/drivers/staging/rtl8723bs/hal/hal_intf.c
index a168852cb6c7..beb4272a0992 100644
--- a/drivers/staging/rtl8723bs/hal/hal_intf.c
+++ b/drivers/staging/rtl8723bs/hal/hal_intf.c
@@ -308,11 +308,7 @@ bool rtw_hal_c2h_valid(struct adapter *adapter, u8 *buf)
s32 rtw_hal_c2h_handler(struct adapter *adapter, u8 *c2h_evt)
{
- s32 ret = _FAIL;
-
- if (adapter->HalFunc.c2h_handler)
- ret = adapter->HalFunc.c2h_handler(adapter, c2h_evt);
- return ret;
+ return c2h_handler_8723b(adapter, c2h_evt);
}
c2h_id_filter rtw_hal_c2h_id_filter_ccx(struct adapter *adapter)
diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c
index b746e3e05d16..10224d096886 100644
--- a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c
+++ b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c
@@ -1317,7 +1317,6 @@ void rtl8723b_set_hal_ops(struct hal_ops *pHalFunc)
{
pHalFunc->xmit_thread_handler = &hal_xmit_handler;
- pHalFunc->c2h_handler = c2h_handler_8723b;
pHalFunc->c2h_id_filter_ccx = c2h_id_filter_ccx_8723b;
pHalFunc->fill_h2c_cmd = &FillH2CCmd8723B;
diff --git a/drivers/staging/rtl8723bs/include/hal_intf.h b/drivers/staging/rtl8723bs/include/hal_intf.h
index 72ae4cdcf0dd..64f5d7b58258 100644
--- a/drivers/staging/rtl8723bs/include/hal_intf.h
+++ b/drivers/staging/rtl8723bs/include/hal_intf.h
@@ -163,7 +163,6 @@ typedef s32 (*c2h_id_filter)(u8 *c2h_evt);
struct hal_ops {
s32 (*xmit_thread_handler)(struct adapter *padapter);
void (*hal_reset_security_engine)(struct adapter *adapter);
- s32 (*c2h_handler)(struct adapter *padapter, u8 *c2h_evt);
c2h_id_filter c2h_id_filter_ccx;
s32 (*fill_h2c_cmd)(struct adapter *, u8 ElementID, u32 CmdLen, u8 *pCmdBuffer);
--
2.50.1
next prev parent reply other threads:[~2025-07-15 18:28 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-15 18:28 [PATCH 00/11] staging: rtl8723bs: get rid of struct hal_ops Michael Straube
2025-07-15 18:28 ` [PATCH 01/11] staging: rtl8723bs: remove function pointer SetHalODMVarHandler Michael Straube
2025-07-15 18:28 ` [PATCH 02/11] staging: rtl8723bs: remove wrapper rtl8723b_SetHalODMVar Michael Straube
2025-07-15 18:28 ` [PATCH 03/11] staging: rtl8723bs: remove function pointer hal_notch_filter Michael Straube
2025-07-15 18:28 ` Michael Straube [this message]
2025-07-15 18:28 ` [PATCH 05/11] staging: rtl8723bs: remove macro FillH2CCmd Michael Straube
2025-07-15 18:28 ` [PATCH 06/11] staging: rtl8723bs: remove function pointer fill_h2c_cmd Michael Straube
2025-07-15 18:28 ` [PATCH 07/11] staging: rtl8723bs: remove macro hal_xmit_handler Michael Straube
2025-07-15 18:28 ` [PATCH 08/11] staging: rtl8723bs: remove function pointer xmit_thread_handler Michael Straube
2025-07-15 18:28 ` [PATCH 09/11] staging: rtl8723bs: remove function pointer hal_reset_security_engine Michael Straube
2025-07-15 18:28 ` [PATCH 10/11] staging: rtl8723bs: remove function pointer c2h_id_filter Michael Straube
2025-07-15 18:28 ` [PATCH 11/11] staging: rtl8723bs: remove struct hal_ops Michael Straube
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250715182814.212708-5-straube.linux@gmail.com \
--to=straube.linux@gmail.com \
--cc=Larry.Finger@lwfinger.net \
--cc=gregkh@linuxfoundation.org \
--cc=hdegoede@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®