From: Michael Straube <straube.linux@gmail.com>
To: gregkh@linuxfoundation.org
Cc: hdegoede@redhat.com, Larry.Finger@lwfinger.net,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
Michael Straube <straube.linux@gmail.com>
Subject: [PATCH 02/11] staging: rtl8723bs: remove wrapper rtl8723b_SetHalODMVar
Date: Tue, 15 Jul 2025 20:28:05 +0200 [thread overview]
Message-ID: <20250715182814.212708-3-straube.linux@gmail.com> (raw)
In-Reply-To: <20250715182814.212708-1-straube.linux@gmail.com>
Remove the wrapper function rtl8723b_SetHalODMVar and use SetHalODMVar
directly to reduce code complexity.
Signed-off-by: Michael Straube <straube.linux@gmail.com>
---
drivers/staging/rtl8723bs/hal/hal_intf.c | 2 +-
drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c | 5 -----
drivers/staging/rtl8723bs/include/hal_intf.h | 1 -
3 files changed, 1 insertion(+), 7 deletions(-)
diff --git a/drivers/staging/rtl8723bs/hal/hal_intf.c b/drivers/staging/rtl8723bs/hal/hal_intf.c
index 84c64bd04598..eb34e39f3c64 100644
--- a/drivers/staging/rtl8723bs/hal/hal_intf.c
+++ b/drivers/staging/rtl8723bs/hal/hal_intf.c
@@ -129,7 +129,7 @@ u8 rtw_hal_get_def_var(struct adapter *padapter, enum hal_def_variable eVariable
void rtw_hal_set_odm_var(struct adapter *padapter, enum hal_odm_variable eVariable, void *pValue1, bool bSet)
{
- rtl8723b_SetHalODMVar(padapter, eVariable, pValue1, bSet);
+ SetHalODMVar(padapter, eVariable, pValue1, bSet);
}
void rtw_hal_enable_interrupt(struct adapter *padapter)
diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c
index 8b7816e47131..a6eab2819535 100644
--- a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c
+++ b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c
@@ -1267,11 +1267,6 @@ void rtl8723b_SetBeaconRelatedRegisters(struct adapter *padapter)
rtw_write8(padapter, bcn_ctrl_reg, val8);
}
-void rtl8723b_SetHalODMVar(struct adapter *Adapter, enum hal_odm_variable eVariable, void *pValue1, bool bSet)
-{
- SetHalODMVar(Adapter, eVariable, pValue1, bSet);
-}
-
static void hal_notch_filter_8723b(struct adapter *adapter, bool enable)
{
if (enable)
diff --git a/drivers/staging/rtl8723bs/include/hal_intf.h b/drivers/staging/rtl8723bs/include/hal_intf.h
index f9f169262fb4..3626e1505848 100644
--- a/drivers/staging/rtl8723bs/include/hal_intf.h
+++ b/drivers/staging/rtl8723bs/include/hal_intf.h
@@ -276,7 +276,6 @@ u8 GetHalDefVar8723BSDIO(struct adapter *Adapter, enum hal_def_variable eVariabl
u8 SetHalDefVar8723BSDIO(struct adapter *Adapter, enum hal_def_variable eVariable, void *pValue);
void UpdateHalRAMask8723B(struct adapter *padapter, u32 mac_id, u8 rssi_level);
void rtl8723b_SetBeaconRelatedRegisters(struct adapter *padapter);
-void rtl8723b_SetHalODMVar(struct adapter *Adapter, enum hal_odm_variable eVariable, void *pValue1, bool bSet);
void Hal_EfusePowerSwitch(struct adapter *padapter, u8 bWrite, u8 PwrState);
void Hal_ReadEFuse(struct adapter *padapter, u8 efuseType, u16 _offset,
u16 _size_byte, u8 *pbuf, bool bPseudoTest);
--
2.50.1
next prev parent reply other threads:[~2025-07-15 18:28 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-15 18:28 [PATCH 00/11] staging: rtl8723bs: get rid of struct hal_ops Michael Straube
2025-07-15 18:28 ` [PATCH 01/11] staging: rtl8723bs: remove function pointer SetHalODMVarHandler Michael Straube
2025-07-15 18:28 ` Michael Straube [this message]
2025-07-15 18:28 ` [PATCH 03/11] staging: rtl8723bs: remove function pointer hal_notch_filter Michael Straube
2025-07-15 18:28 ` [PATCH 04/11] staging: rtl8723bs: remove function pointer c2h_handler Michael Straube
2025-07-15 18:28 ` [PATCH 05/11] staging: rtl8723bs: remove macro FillH2CCmd Michael Straube
2025-07-15 18:28 ` [PATCH 06/11] staging: rtl8723bs: remove function pointer fill_h2c_cmd Michael Straube
2025-07-15 18:28 ` [PATCH 07/11] staging: rtl8723bs: remove macro hal_xmit_handler Michael Straube
2025-07-15 18:28 ` [PATCH 08/11] staging: rtl8723bs: remove function pointer xmit_thread_handler Michael Straube
2025-07-15 18:28 ` [PATCH 09/11] staging: rtl8723bs: remove function pointer hal_reset_security_engine Michael Straube
2025-07-15 18:28 ` [PATCH 10/11] staging: rtl8723bs: remove function pointer c2h_id_filter Michael Straube
2025-07-15 18:28 ` [PATCH 11/11] staging: rtl8723bs: remove struct hal_ops Michael Straube
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250715182814.212708-3-straube.linux@gmail.com \
--to=straube.linux@gmail.com \
--cc=Larry.Finger@lwfinger.net \
--cc=gregkh@linuxfoundation.org \
--cc=hdegoede@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®