From: Bjorn Helgaas <helgaas@kernel.org>
To: James Bottomley <James.Bottomley@hansenpartnership.com>
Cc: "Martin K . Petersen" <martin.petersen@oracle.com>,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
Bjorn Helgaas <bhelgaas@google.com>
Subject: Re: [PATCH] scsi: Fix typos
Date: Wed, 23 Jul 2025 15:47:04 -0500 [thread overview]
Message-ID: <20250723204704.GA2910768@bhelgaas> (raw)
In-Reply-To: <9c116cf4fbe4ba7515d265dd3a1a272dcfecccb1.camel@HansenPartnership.com>
On Wed, Jul 23, 2025 at 04:39:14PM -0400, James Bottomley wrote:
> On Wed, 2025-07-23 at 15:26 -0500, Bjorn Helgaas wrote:
> ...
> > * Device's PID has changed. We need to
> > cleanup
> > * and re-login. If there is another device
> > with
> > - * the the newly discovered pid, send an scn
> > notice
> > - * so that its new pid can be discovered.
> > + * the newly discovered PID, send an scn
> > notice
> > + * so that its new PID can be discovered.
> > */
>
> so pid was inconsistently capitalised in a comment, but now scn looks
> like it should be capitalised as well, so I think we can live with the
> inconsistency rather than have tonnes of patches trying to capitalise
> all the TLAs.
The motivator for this particular hunk was the doubled "the":
s/the the/the/
It looks like this comment is the only place in the file "PID" was
capitalized, so I probably should have left it or lowercased just that
one.
> I could go on, but I'm not sure it's worth the time.
No problem, I'll ignore drivers/scsi.
Bjorn
next prev parent reply other threads:[~2025-07-23 20:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-23 20:26 Bjorn Helgaas
2025-07-23 20:39 ` James Bottomley
2025-07-23 20:47 ` Bjorn Helgaas [this message]
2025-07-23 20:54 ` James Bottomley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250723204704.GA2910768@bhelgaas \
--to=helgaas@kernel.org \
--cc=James.Bottomley@hansenpartnership.com \
--cc=bhelgaas@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®