mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Bjorn Helgaas <helgaas@kernel.org>,
	"Martin K . Petersen" <martin.petersen@oracle.com>
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
	Bjorn Helgaas <bhelgaas@google.com>
Subject: Re: [PATCH] scsi: Fix typos
Date: Wed, 23 Jul 2025 16:39:14 -0400	[thread overview]
Message-ID: <9c116cf4fbe4ba7515d265dd3a1a272dcfecccb1.camel@HansenPartnership.com> (raw)
In-Reply-To: <20250723202608.2909276-1-helgaas@kernel.org>

On Wed, 2025-07-23 at 15:26 -0500, Bjorn Helgaas wrote:
> From: Bjorn Helgaas <bhelgaas@google.com>
> 
> Fix typos, most reported by "codespell drivers/scsi".  Mostly touches
> comments, no code changes except
> SCU_LINK_STATUS_DWORD_SYNC_AQUIRED_*,
> which is defined but never used.

Well, this really looks like huge churn for no reason.  Plus your
codespell thing has several quirks which look wrong.  For instance:

> -#define		CFSUPREM	0x0001	/* support all
> removeable drives */
> -#define		CFSUPREMB	0x0002	/* support
> removeable boot drives */
> +#define		CFSUPREM	0x0001	/* support all
> removable drives */
> +#define		CFSUPREMB	0x0002	/* support removable
> boot drives */

removeable is an acceptable variant spelling of removable:
https://www.collinsdictionary.com/us/dictionary/english/removeable

>  			/*
>  			 * Device's PID has changed. We need to
> cleanup
>  			 * and re-login. If there is another device
> with
> -			 * the the newly discovered pid, send an scn
> notice
> -			 * so that its new pid can be discovered.
> +			 * the newly discovered PID, send an scn
> notice
> +			 * so that its new PID can be discovered.
>  			 */

so pid was inconsistently capitalised in a comment, but now scn looks
like it should be capitalised as well, so I think we can live with the
inconsistency rather than have tonnes of patches trying to capitalise
all the TLAs.

I could go on, but I'm not sure it's worth the time.

Regards,

James


  reply	other threads:[~2025-07-23 20:39 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-23 20:26 Bjorn Helgaas
2025-07-23 20:39 ` James Bottomley [this message]
2025-07-23 20:47   ` Bjorn Helgaas
2025-07-23 20:54     ` James Bottomley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9c116cf4fbe4ba7515d265dd3a1a272dcfecccb1.camel@HansenPartnership.com \
    --to=james.bottomley@hansenpartnership.com \
    --cc=bhelgaas@google.com \
    --cc=helgaas@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®