From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: "Martin K . Petersen" <martin.petersen@oracle.com>,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
Bjorn Helgaas <bhelgaas@google.com>
Subject: Re: [PATCH] scsi: Fix typos
Date: Wed, 23 Jul 2025 16:54:24 -0400 [thread overview]
Message-ID: <f07fcf282934c1e6cd3984b9a386e77da637afb7.camel@HansenPartnership.com> (raw)
In-Reply-To: <20250723204704.GA2910768@bhelgaas>
On Wed, 2025-07-23 at 15:47 -0500, Bjorn Helgaas wrote:
> On Wed, Jul 23, 2025 at 04:39:14PM -0400, James Bottomley wrote:
> > On Wed, 2025-07-23 at 15:26 -0500, Bjorn Helgaas wrote:
> > ...
>
> > > * Device's PID has changed. We need to
> > > cleanup
> > > * and re-login. If there is another
> > > device
> > > with
> > > - * the the newly discovered pid, send an
> > > scn
> > > notice
> > > - * so that its new pid can be
> > > discovered.
> > > + * the newly discovered PID, send an scn
> > > notice
> > > + * so that its new PID can be
> > > discovered.
> > > */
> >
> > so pid was inconsistently capitalised in a comment, but now scn
> > looks like it should be capitalised as well, so I think we can live
> > with the inconsistency rather than have tonnes of patches trying to
> > capitalise all the TLAs.
>
> The motivator for this particular hunk was the doubled "the":
> s/the the/the/
Well, I get it, I really do; but if I have to live with less than 12
items in the supermarket instead of fewer, I'm sure the world can cope
with double the's in comments ... and don't get me started on the
difference between effect and affect.
Regards,
James
prev parent reply other threads:[~2025-07-23 20:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-23 20:26 Bjorn Helgaas
2025-07-23 20:39 ` James Bottomley
2025-07-23 20:47 ` Bjorn Helgaas
2025-07-23 20:54 ` James Bottomley [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f07fcf282934c1e6cd3984b9a386e77da637afb7.camel@HansenPartnership.com \
--to=james.bottomley@hansenpartnership.com \
--cc=bhelgaas@google.com \
--cc=helgaas@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®