[PATCH] ARM: s3c/gpio: complete the conversion to new GPIO value setters

[PATCH] ARM: s3c/gpio: complete the conversion to new GPIO value setters

[Bartosz Golaszewski]

From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>

Commit fb52f3226cab ("ARM: s3c/gpio: use new line value setter
callbacks") correctly changed the assignment of the callback but missed
the check one liner higher. Change it now too to using the recommended
callback as the legacy one is going away soon.

Fixes: fb52f3226cab ("ARM: s3c/gpio: use new line value setter callbacks")
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
---
Autobuilders pointed out only now that I missed the other line that
needs changing in my previous patch. I'd like to still queue this for
v6.17. Either through the SoC tree if it's not too late or through the
GPIO tree together with my second PR for this merge window. Please
kindly ack it.

 arch/arm/mach-s3c/gpio-samsung.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/mach-s3c/gpio-samsung.c b/arch/arm/mach-s3c/gpio-samsung.c
index 206a492fbaf5..3ee4ad969cc2 100644
--- a/arch/arm/mach-s3c/gpio-samsung.c
+++ b/arch/arm/mach-s3c/gpio-samsung.c
@@ -516,7 +516,7 @@ static void __init samsung_gpiolib_add(struct samsung_gpio_chip *chip)
 		gc->direction_input = samsung_gpiolib_2bit_input;
 	if (!gc->direction_output)
 		gc->direction_output = samsung_gpiolib_2bit_output;
-	if (!gc->set)
+	if (!gc->set_rv)
 		gc->set_rv = samsung_gpiolib_set;
 	if (!gc->get)
 		gc->get = samsung_gpiolib_get;
-- 
2.48.1

Re: [PATCH] ARM: s3c/gpio: complete the conversion to new GPIO value setters

[Krzysztof Kozlowski]

On 30/07/2025 09:14, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> 
> Commit fb52f3226cab ("ARM: s3c/gpio: use new line value setter
> callbacks") correctly changed the assignment of the callback but missed
> the check one liner higher. Change it now too to using the recommended
> callback as the legacy one is going away soon.
> 
> Fixes: fb52f3226cab ("ARM: s3c/gpio: use new line value setter callbacks")
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> ---
> Autobuilders pointed out only now that I missed the other line that
> needs changing in my previous patch. I'd like to still queue this for
> v6.17. Either through the SoC tree if it's not too late or through the
> GPIO tree together with my second PR for this merge window. Please
> kindly ack it.

This does not apply for current RC, so on top of v6.17-rc1.

Best regards,
Krzysztof

Re: [PATCH] ARM: s3c/gpio: complete the conversion to new GPIO value setters

[Bartosz Golaszewski]

On Mon, Aug 11, 2025 at 10:46 AM Krzysztof Kozlowski <krzk@kernel.org> wrote:
>
> On 30/07/2025 09:14, Bartosz Golaszewski wrote:
> > From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> >
> > Commit fb52f3226cab ("ARM: s3c/gpio: use new line value setter
> > callbacks") correctly changed the assignment of the callback but missed
> > the check one liner higher. Change it now too to using the recommended
> > callback as the legacy one is going away soon.
> >
> > Fixes: fb52f3226cab ("ARM: s3c/gpio: use new line value setter callbacks")
> > Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> > ---
> > Autobuilders pointed out only now that I missed the other line that
> > needs changing in my previous patch. I'd like to still queue this for
> > v6.17. Either through the SoC tree if it's not too late or through the
> > GPIO tree together with my second PR for this merge window. Please
> > kindly ack it.
>
> This does not apply for current RC, so on top of v6.17-rc1.
>
> Best regards,
> Krzysztof

This is no longer needed with v6.17-rc1. The callbacks have been
renamed back globally to the original names.

Bart