* [PATCH] drm/amdgpu: fix incorrect comment format
@ 2025-08-06 3:34 Cryolitia PukNgae via B4 Relay
2025-08-06 12:32 ` Christian König
0 siblings, 1 reply; 3+ messages in thread
From: Cryolitia PukNgae via B4 Relay @ 2025-08-06 3:34 UTC (permalink / raw)
To: Alex Deucher, Christian König, David Airlie, Simona Vetter
Cc: amd-gfx, dri-devel, linux-kernel, wangyuli, zhanjun, guanwentao,
Cryolitia PukNgae
From: Cryolitia PukNgae <cryolitia@uniontech.com>
Comments should not have a leading plus sign.
Signed-off-by: Cryolitia PukNgae <cryolitia@uniontech.com>
---
drivers/gpu/drm/amd/amdgpu/nbio_v7_4.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/nbio_v7_4.c b/drivers/gpu/drm/amd/amdgpu/nbio_v7_4.c
index d5002ff931d841994ca2c70cdf5b989f5b3c59d6..860bc5cb03c81b5346743b5fb46a7dcbe5a201a4 100644
--- a/drivers/gpu/drm/amd/amdgpu/nbio_v7_4.c
+++ b/drivers/gpu/drm/amd/amdgpu/nbio_v7_4.c
@@ -151,9 +151,9 @@ static void nbio_v7_4_sdma_doorbell_range(struct amdgpu_device *adev, int instan
* BIF_SDMA0_DOORBELL_RANGE: 0x3bc0
* BIF_SDMA1_DOORBELL_RANGE: 0x3bc4
* BIF_SDMA2_DOORBELL_RANGE: 0x3bd8
-+ * BIF_SDMA4_DOORBELL_RANGE:
-+ * ARCTURUS: 0x3be0
-+ * ALDEBARAN: 0x3be4
+ * BIF_SDMA4_DOORBELL_RANGE:
+ * ARCTURUS: 0x3be0
+ * ALDEBARAN: 0x3be4
*/
if (adev->asic_type == CHIP_ALDEBARAN && instance == 4)
reg = instance + 0x4 + 0x1 +
---
base-commit: 6bcdbd62bd56e6d7383f9e06d9d148935b3c9b73
change-id: 20250806-amdgpu_typo-80869b122c36
Best regards,
--
Cryolitia PukNgae <cryolitia@uniontech.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/amdgpu: fix incorrect comment format
2025-08-06 3:34 [PATCH] drm/amdgpu: fix incorrect comment format Cryolitia PukNgae via B4 Relay
@ 2025-08-06 12:32 ` Christian König
2025-08-08 15:28 ` Alex Deucher
0 siblings, 1 reply; 3+ messages in thread
From: Christian König @ 2025-08-06 12:32 UTC (permalink / raw)
To: cryolitia, Alex Deucher, David Airlie, Simona Vetter
Cc: amd-gfx, dri-devel, linux-kernel, wangyuli, zhanjun, guanwentao
On 06.08.25 05:34, Cryolitia PukNgae via B4 Relay wrote:
> From: Cryolitia PukNgae <cryolitia@uniontech.com>
>
> Comments should not have a leading plus sign.
Good catch, potentially a left over from a merge conflict or similar.
>
> Signed-off-by: Cryolitia PukNgae <cryolitia@uniontech.com>
Acked-by: Christian König <christian.koenig@amd.com>
> ---
> drivers/gpu/drm/amd/amdgpu/nbio_v7_4.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/nbio_v7_4.c b/drivers/gpu/drm/amd/amdgpu/nbio_v7_4.c
> index d5002ff931d841994ca2c70cdf5b989f5b3c59d6..860bc5cb03c81b5346743b5fb46a7dcbe5a201a4 100644
> --- a/drivers/gpu/drm/amd/amdgpu/nbio_v7_4.c
> +++ b/drivers/gpu/drm/amd/amdgpu/nbio_v7_4.c
> @@ -151,9 +151,9 @@ static void nbio_v7_4_sdma_doorbell_range(struct amdgpu_device *adev, int instan
> * BIF_SDMA0_DOORBELL_RANGE: 0x3bc0
> * BIF_SDMA1_DOORBELL_RANGE: 0x3bc4
> * BIF_SDMA2_DOORBELL_RANGE: 0x3bd8
> -+ * BIF_SDMA4_DOORBELL_RANGE:
> -+ * ARCTURUS: 0x3be0
> -+ * ALDEBARAN: 0x3be4
> + * BIF_SDMA4_DOORBELL_RANGE:
> + * ARCTURUS: 0x3be0
> + * ALDEBARAN: 0x3be4
> */
> if (adev->asic_type == CHIP_ALDEBARAN && instance == 4)
> reg = instance + 0x4 + 0x1 +
>
> ---
> base-commit: 6bcdbd62bd56e6d7383f9e06d9d148935b3c9b73
> change-id: 20250806-amdgpu_typo-80869b122c36
>
> Best regards,
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/amdgpu: fix incorrect comment format
2025-08-06 12:32 ` Christian König
@ 2025-08-08 15:28 ` Alex Deucher
0 siblings, 0 replies; 3+ messages in thread
From: Alex Deucher @ 2025-08-08 15:28 UTC (permalink / raw)
To: Christian König
Cc: cryolitia, Alex Deucher, David Airlie, Simona Vetter, amd-gfx,
dri-devel, linux-kernel, wangyuli, zhanjun, guanwentao
Applied. Thanks!
Alex
On Wed, Aug 6, 2025 at 8:38 AM Christian König <christian.koenig@amd.com> wrote:
>
> On 06.08.25 05:34, Cryolitia PukNgae via B4 Relay wrote:
> > From: Cryolitia PukNgae <cryolitia@uniontech.com>
> >
> > Comments should not have a leading plus sign.
>
> Good catch, potentially a left over from a merge conflict or similar.
>
> >
> > Signed-off-by: Cryolitia PukNgae <cryolitia@uniontech.com>
>
> Acked-by: Christian König <christian.koenig@amd.com>
>
> > ---
> > drivers/gpu/drm/amd/amdgpu/nbio_v7_4.c | 6 +++---
> > 1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/amd/amdgpu/nbio_v7_4.c b/drivers/gpu/drm/amd/amdgpu/nbio_v7_4.c
> > index d5002ff931d841994ca2c70cdf5b989f5b3c59d6..860bc5cb03c81b5346743b5fb46a7dcbe5a201a4 100644
> > --- a/drivers/gpu/drm/amd/amdgpu/nbio_v7_4.c
> > +++ b/drivers/gpu/drm/amd/amdgpu/nbio_v7_4.c
> > @@ -151,9 +151,9 @@ static void nbio_v7_4_sdma_doorbell_range(struct amdgpu_device *adev, int instan
> > * BIF_SDMA0_DOORBELL_RANGE: 0x3bc0
> > * BIF_SDMA1_DOORBELL_RANGE: 0x3bc4
> > * BIF_SDMA2_DOORBELL_RANGE: 0x3bd8
> > -+ * BIF_SDMA4_DOORBELL_RANGE:
> > -+ * ARCTURUS: 0x3be0
> > -+ * ALDEBARAN: 0x3be4
> > + * BIF_SDMA4_DOORBELL_RANGE:
> > + * ARCTURUS: 0x3be0
> > + * ALDEBARAN: 0x3be4
> > */
> > if (adev->asic_type == CHIP_ALDEBARAN && instance == 4)
> > reg = instance + 0x4 + 0x1 +
> >
> > ---
> > base-commit: 6bcdbd62bd56e6d7383f9e06d9d148935b3c9b73
> > change-id: 20250806-amdgpu_typo-80869b122c36
> >
> > Best regards,
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-08-08 15:28 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-08-06 3:34 [PATCH] drm/amdgpu: fix incorrect comment format Cryolitia PukNgae via B4 Relay
2025-08-06 12:32 ` Christian König
2025-08-08 15:28 ` Alex Deucher
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®