* [PATCH] media: imx296: Remove redundant semicolons
@ 2025-08-13 9:47 Liao Yuanhong
2025-08-13 10:18 ` Kieran Bingham
0 siblings, 1 reply; 3+ messages in thread
From: Liao Yuanhong @ 2025-08-13 9:47 UTC (permalink / raw)
To: Sakari Ailus, Laurent Pinchart, Manivannan Sadhasivam,
Mauro Carvalho Chehab, open list:V4L2 CAMERA SENSOR DRIVERS,
open list
Cc: Liao Yuanhong
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=y, Size: 660 bytes --]
Remove unnecessary semicolons.
Signed-off-by: Liao Yuanhong <liaoyuanhong@vivo.com>
---
drivers/media/i2c/imx296.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/i2c/imx296.c b/drivers/media/i2c/imx296.c
index f3bec16b527c..cbbe0e7a37a9 100644
--- a/drivers/media/i2c/imx296.c
+++ b/drivers/media/i2c/imx296.c
@@ -922,7 +922,7 @@ static int imx296_read_temperature(struct imx296 *sensor, int *temp)
tmdout &= IMX296_TMDOUT_MASK;
- /* T(°C) = 246.312 - 0.304 * TMDOUT */;
+ /* T(°C) = 246.312 - 0.304 * TMDOUT */
*temp = 246312 - 304 * tmdout;
return imx296_write(sensor, IMX296_TMDCTRL, 0, NULL);
--
2.34.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] media: imx296: Remove redundant semicolons
2025-08-13 9:47 [PATCH] media: imx296: Remove redundant semicolons Liao Yuanhong
@ 2025-08-13 10:18 ` Kieran Bingham
2025-08-13 10:38 ` Laurent Pinchart
0 siblings, 1 reply; 3+ messages in thread
From: Kieran Bingham @ 2025-08-13 10:18 UTC (permalink / raw)
To: Laurent Pinchart, Liao Yuanhong, Manivannan Sadhasivam,
Mauro Carvalho Chehab, Sakari Ailus, linux-kernel, linux-media
Cc: Liao Yuanhong
Quoting Liao Yuanhong (2025-08-13 10:47:46)
> Remove unnecessary semicolons.
Well ... there's only one so it's not plural ;-) but indeed this is very
redundant!
Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
>
> Signed-off-by: Liao Yuanhong <liaoyuanhong@vivo.com>
> ---
> drivers/media/i2c/imx296.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/i2c/imx296.c b/drivers/media/i2c/imx296.c
> index f3bec16b527c..cbbe0e7a37a9 100644
> --- a/drivers/media/i2c/imx296.c
> +++ b/drivers/media/i2c/imx296.c
> @@ -922,7 +922,7 @@ static int imx296_read_temperature(struct imx296 *sensor, int *temp)
>
> tmdout &= IMX296_TMDOUT_MASK;
>
> - /* T(��C) = 246.312 - 0.304 * TMDOUT */;
> + /* T(��C) = 246.312 - 0.304 * TMDOUT */
> *temp = 246312 - 304 * tmdout;
>
> return imx296_write(sensor, IMX296_TMDCTRL, 0, NULL);
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] media: imx296: Remove redundant semicolons
2025-08-13 10:18 ` Kieran Bingham
@ 2025-08-13 10:38 ` Laurent Pinchart
0 siblings, 0 replies; 3+ messages in thread
From: Laurent Pinchart @ 2025-08-13 10:38 UTC (permalink / raw)
To: Kieran Bingham
Cc: Liao Yuanhong, Manivannan Sadhasivam, Mauro Carvalho Chehab,
Sakari Ailus, linux-kernel, linux-media
On Wed, Aug 13, 2025 at 11:18:16AM +0100, Kieran Bingham wrote:
> Quoting Liao Yuanhong (2025-08-13 10:47:46)
> > Remove unnecessary semicolons.
>
> Well ... there's only one so it's not plural ;-) but indeed this is very
> redundant!
>
> Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> >
> > Signed-off-by: Liao Yuanhong <liaoyuanhong@vivo.com>
> > ---
> > drivers/media/i2c/imx296.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/media/i2c/imx296.c b/drivers/media/i2c/imx296.c
> > index f3bec16b527c..cbbe0e7a37a9 100644
> > --- a/drivers/media/i2c/imx296.c
> > +++ b/drivers/media/i2c/imx296.c
> > @@ -922,7 +922,7 @@ static int imx296_read_temperature(struct imx296 *sensor, int *temp)
> >
> > tmdout &= IMX296_TMDOUT_MASK;
> >
> > - /* T(��C) = 246.312 - 0.304 * TMDOUT */;
> > + /* T(��C) = 246.312 - 0.304 * TMDOUT */
> > *temp = 246312 - 304 * tmdout;
> >
> > return imx296_write(sensor, IMX296_TMDCTRL, 0, NULL);
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-08-13 10:39 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-08-13 9:47 [PATCH] media: imx296: Remove redundant semicolons Liao Yuanhong
2025-08-13 10:18 ` Kieran Bingham
2025-08-13 10:38 ` Laurent Pinchart
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®