From: Hillf Danton <hdanton@sina.com>
To: Chen Ridong <chenridong@huaweicloud.com>
Cc: Michal Koutny <mkoutny@suse.com>,
tj@kernel.org, cgroups@vger.kernel.org,
linux-kernel@vger.kernel.org, lujialin4@huawei.com,
chenridong@huawei.com, gaoyingjie@uniontech.com
Subject: Re: [PATCH v2 -next] cgroup: remove offline draining in root destruction to avoid hung_tasks
Date: Sat, 16 Aug 2025 08:57:21 +0800 [thread overview]
Message-ID: <20250816005723.4672-1-hdanton@sina.com> (raw)
In-Reply-To: <3f6feb92-0496-416b-bf0c-4391e0d4426d@huaweicloud.com>
On Sat, 16 Aug 2025 08:33:55 +0800 Chen Ridong wrote:
> On 2025/8/15 19:54, Hillf Danton wrote:
> > On Fri, 15 Aug 2025 18:28:53 +0800 Chen Ridong wrote:
> >>
> >> To clarify, when you mentioned "cut max_active off", did you mean setting max_active of
> >> cgroup_destroy_wq to 1?
> >>
> > cgroup_destroy_wq = alloc_workqueue("cgroup_destroy", 0, 0);
>
> Thank you for the additional clarification.
>
> While this modification is functional, I’m concerned it might spawn a significant number of cgroup
> destruction tasks—most of which would contend for cgroup_mutex. Could this waste system resources?
>
No win comes from nothing, so you need to pay $.02 for example at least
for curing the task hung by erasing the root cause.
next prev parent reply other threads:[~2025-08-16 0:57 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-22 11:27 Chen Ridong
2025-07-24 13:35 ` Michal Koutný
2025-07-25 1:42 ` Chen Ridong
2025-07-25 17:17 ` Michal Koutný
2025-07-26 0:52 ` Chen Ridong
2025-07-31 11:53 ` Chen Ridong
2025-08-14 15:17 ` Michal Koutný
2025-08-15 0:30 ` Chen Ridong
2025-08-15 2:40 ` Hillf Danton
2025-08-15 7:29 ` Chen Ridong
2025-08-15 10:02 ` Hillf Danton
2025-08-15 10:28 ` Chen Ridong
2025-08-15 11:54 ` Hillf Danton
2025-08-16 0:33 ` Chen Ridong
2025-08-16 0:57 ` Hillf Danton [this message]
2025-08-15 7:24 ` Chen Ridong
2025-07-25 1:48 ` Chen Ridong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250816005723.4672-1-hdanton@sina.com \
--to=hdanton@sina.com \
--cc=cgroups@vger.kernel.org \
--cc=chenridong@huawei.com \
--cc=chenridong@huaweicloud.com \
--cc=gaoyingjie@uniontech.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lujialin4@huawei.com \
--cc=mkoutny@suse.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®