From: Chen Ridong <chenridong@huaweicloud.com>
To: tj@kernel.org, hannes@cmpxchg.org, mkoutny@suse.com, lizefan@huawei.com
Cc: cgroups@vger.kernel.org, linux-kernel@vger.kernel.org,
lujialin4@huawei.com, chenridong@huawei.com,
gaoyingjie@uniontech.com
Subject: Re: [PATCH v2 -next] cgroup: remove offline draining in root destruction to avoid hung_tasks
Date: Fri, 25 Jul 2025 09:48:09 +0800 [thread overview]
Message-ID: <a5fc83e3-4d4a-49da-8dc8-8bf3973bc851@huaweicloud.com> (raw)
In-Reply-To: <20250722112733.4113237-1-chenridong@huaweicloud.com>
On 2025/7/22 19:27, Chen Ridong wrote:
> From: Chen Ridong <chenridong@huawei.com>
>
> A hung task can occur during [1] LTP cgroup testing when repeatedly
> mounting/unmounting perf_event and net_prio controllers with
> systemd.unified_cgroup_hierarchy=1. The hang manifests in
> cgroup_lock_and_drain_offline() during root destruction.
>
> Related case:
> cgroup_fj_function_perf_event cgroup_fj_function.sh perf_event
> cgroup_fj_function_net_prio cgroup_fj_function.sh net_prio
This can be easily reproduced by the process(offered by Yingjie):
#include <stdio.h>
#include <stdlib.h>
#include <string.h>
#include <errno.h>
#include <sys/mount.h>
#include <sys/stat.h>
#include <unistd.h>
#define LOOPS 10000
#define TMPDIR "/tmp"
#define CGROUP_BASE "ltp_cgtest"
#define CONTROLLERS_COUNT 2
const char *controllers[CONTROLLERS_COUNT] = {"perf_event", "net_prio"};
void safe_mkdir(const char *path) {
if (mkdir(path, 0777) == -1 && errno != EEXIST) {
fprintf(stderr, "mkdir(%s) failed: %s\n", path, strerror(errno));
exit(1);
}
}
void safe_rmdir(const char *path) {
if (rmdir(path) == -1 && errno != ENOENT) {
fprintf(stderr, "rmdir(%s) failed: %s\n", path, strerror(errno));
}
}
int is_mounted(const char *mnt) {
FILE *fp = fopen("/proc/mounts", "r");
if (!fp) return 0;
char line[512];
int found = 0;
while (fgets(line, sizeof(line), fp)) {
if (strstr(line, mnt)) {
found = 1;
break;
}
}
fclose(fp);
return found;
}
int main(void) {
if (getuid() != 0) {
fprintf(stderr, "This program must be run as root\n");
return 1;
}
FILE *fcg = fopen("/proc/cgroups", "r");
if (!fcg) {
fprintf(stderr, "Kernel does not support cgroups\n");
return 1;
}
fclose(fcg);
char mnt[256];
for (int i = 1; i <= LOOPS; ++i) {
for (int c = 0; c < CONTROLLERS_COUNT; ++c) {
snprintf(mnt, sizeof(mnt), "%s/cgroup_%s", TMPDIR, controllers[c]);
printf("=== Loop %d: %s ===\n", i, controllers[c]);
fflush(stdout);
safe_mkdir(mnt);
if (!is_mounted(mnt)) {
if (mount(controllers[c], mnt, "cgroup", 0, controllers[c]) == -1) {
fprintf(stderr, "Failed to mount cgroup v1 for %s at %s: %s\n",
controllers[c], mnt, strerror(errno));
safe_rmdir(mnt);
continue;
}
}
if (umount2(mnt, 0) == -1) {
fprintf(stderr, "umount(%s) failed: %s\n", mnt, strerror(errno));
}
safe_rmdir(mnt);
}
}
return 0;
}
prev parent reply other threads:[~2025-07-25 1:48 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-22 11:27 Chen Ridong
2025-07-24 13:35 ` Michal Koutný
2025-07-25 1:42 ` Chen Ridong
2025-07-25 17:17 ` Michal Koutný
2025-07-26 0:52 ` Chen Ridong
2025-07-31 11:53 ` Chen Ridong
2025-08-14 15:17 ` Michal Koutný
2025-08-15 0:30 ` Chen Ridong
2025-08-15 2:40 ` Hillf Danton
2025-08-15 7:29 ` Chen Ridong
2025-08-15 10:02 ` Hillf Danton
2025-08-15 10:28 ` Chen Ridong
2025-08-15 11:54 ` Hillf Danton
2025-08-16 0:33 ` Chen Ridong
2025-08-16 0:57 ` Hillf Danton
2025-08-15 7:24 ` Chen Ridong
2025-07-25 1:48 ` Chen Ridong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a5fc83e3-4d4a-49da-8dc8-8bf3973bc851@huaweicloud.com \
--to=chenridong@huaweicloud.com \
--cc=cgroups@vger.kernel.org \
--cc=chenridong@huawei.com \
--cc=gaoyingjie@uniontech.com \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan@huawei.com \
--cc=lujialin4@huawei.com \
--cc=mkoutny@suse.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®