mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: Shrikanth Hegde <sshegde@linux.ibm.com>
Cc: Christophe Leroy <christophe.leroy@csgroup.eu>,
	K Prateek Nayak <kprateek.nayak@amd.com>,
	Madhavan Srinivasan <maddy@linux.ibm.com>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Nicholas Piggin <npiggin@gmail.com>,
	Heiko Carstens <hca@linux.ibm.com>,
	Vasily Gorbik <gor@linux.ibm.com>,
	Alexander Gordeev <agordeev@linux.ibm.com>,
	Christian Borntraeger <borntraeger@linux.ibm.com>,
	Sven Schnelle <svens@linux.ibm.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
	Juri Lelli <juri.lelli@redhat.com>,
	Vincent Guittot <vincent.guittot@linaro.org>,
	linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
	linux-s390@vger.kernel.org,
	Dietmar Eggemann <dietmar.eggemann@arm.com>,
	Steven Rostedt <rostedt@goodmis.org>,
	Ben Segall <bsegall@google.com>, Mel Gorman <mgorman@suse.de>,
	Valentin Schneider <vschneid@redhat.com>,
	thomas.weissschuh@linutronix.de,
	Li Chen <chenl311@chinatelecom.cn>,
	Bibo Mao <maobibo@loongson.cn>, Mete Durlu <meted@linux.ibm.com>,
	Tobias Huschle <huschle@linux.ibm.com>,
	Easwar Hariharan <easwar.hariharan@linux.microsoft.com>,
	Guo Weikang <guoweikang.kernel@gmail.com>,
	"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
	Brian Gerst <brgerst@gmail.com>,
	Patryk Wlazlyn <patryk.wlazlyn@linux.intel.com>,
	Swapnil Sapkal <swapnil.sapkal@amd.com>,
	"Yury Norov [NVIDIA]" <yury.norov@gmail.com>,
	Sudeep Holla <sudeep.holla@arm.com>,
	Jonathan Cameron <Jonathan.Cameron@huawei.com>,
	Andrea Righi <arighi@nvidia.com>,
	Yicong Yang <yangyicong@hisilicon.com>,
	Ricardo Neri <ricardo.neri-calderon@linux.intel.com>,
	Tim Chen <tim.c.chen@linux.intel.com>,
	Vinicius Costa Gomes <vinicius.gomes@intel.com>
Subject: Re: [PATCH v7 4/8] powerpc/smp: Introduce CONFIG_SCHED_MC to guard MC scheduling bits
Date: Mon, 1 Sep 2025 10:52:36 +0200	[thread overview]
Message-ID: <20250901085236.GK4068168@noisy.programming.kicks-ass.net> (raw)
In-Reply-To: <20250901083507.GD4067720@noisy.programming.kicks-ass.net>

On Mon, Sep 01, 2025 at 10:35:07AM +0200, Peter Zijlstra wrote:
> On Thu, Aug 28, 2025 at 08:13:51PM +0530, Shrikanth Hegde wrote:
> 
> > > --- a/arch/powerpc/Kconfig
> > > +++ b/arch/powerpc/Kconfig
> > > @@ -170,6 +170,9 @@ config PPC
> > >   	select ARCH_STACKWALK
> > >   	select ARCH_SUPPORTS_ATOMIC_RMW
> > >   	select ARCH_SUPPORTS_DEBUG_PAGEALLOC	if PPC_BOOK3S || PPC_8xx
> > > +	select ARCH_SUPPORTS_SCHED_SMT		if PPC64 && SMP
> > > +	select ARCH_SUPPORTS_SCHED_MC		if PPC64 && SMP
> > > +	select SCHED_MC				if ARCH_SUPPORTS_SCHED_MC
> > 
> > Wondering if this SCHED_MC is necessary here? shouldn't it be set by arch/Kconfig?
> 
> Ah, so without this SCHED_MC becomes a user selectable option, with this
> it is an always on option (for ppc64) -- no user prompt.
> 
> That is, this is the only way I found to have similar semantics to this:
> 
> > > -config SCHED_MC
> > > -	def_bool y
> > > -	depends on PPC64 && SMP
> > > -
> 
> Which is also not a user selectable option.
> 
> > nit: Also, can we have so they are still sorted?
> > 	select ARCH_SUPPORTS_SCHED_MC		if PPC64 && SMP
> > 	select ARCH_SUPPORTS_SCHED_SMT		if PPC64 && SMP
> 
> Sure, let me flip them. I need to prod that that patch anyway, built
> robot still ain'ted happy.

Looks like 44x/iss476-smp_defconfig (iow 32bit power) also wants
SCHED_MC, so it should be:

config SCHED_MC
	def_bool y
	depends on SMP

Its just SMT that's a PPC64 special.

  reply	other threads:[~2025-09-01  8:53 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-26  4:13 [PATCH v7 0/8] sched/fair: Get rid of sched_domains_curr_level hack for tl->cpumask() K Prateek Nayak
2025-08-26  4:13 ` [PATCH v7 1/8] " K Prateek Nayak
2025-08-28 23:06   ` Tim Chen
2025-08-26  4:13 ` [PATCH v7 2/8] powerpc/smp: Rename cpu_corgroup_* to cpu_corgrp_* K Prateek Nayak
2025-08-26  5:02   ` Christophe Leroy
2025-09-01  3:05     ` K Prateek Nayak
2025-08-26  4:13 ` [PATCH v7 3/8] powerpc/smp: Export cpu_coregroup_mask() K Prateek Nayak
2025-08-26  4:54   ` Christophe Leroy
2025-08-26  4:13 ` [PATCH v7 4/8] powerpc/smp: Introduce CONFIG_SCHED_MC to guard MC scheduling bits K Prateek Nayak
2025-08-26  4:49   ` Christophe Leroy
2025-08-26  8:07     ` Peter Zijlstra
2025-08-26  9:43       ` Peter Zijlstra
2025-08-26  9:59         ` Peter Zijlstra
2025-08-28 14:43         ` Shrikanth Hegde
2025-09-01  8:35           ` Peter Zijlstra
2025-09-01  8:52             ` Peter Zijlstra [this message]
2025-09-03  8:05         ` [tip: sched/core] sched: Unify the SCHED_{SMT,CLUSTER,MC} Kconfig tip-bot2 for Peter Zijlstra
2025-10-14  9:25         ` [PATCH v7 4/8] powerpc/smp: Introduce CONFIG_SCHED_MC to guard MC scheduling bits Geert Uytterhoeven
2025-10-14  9:42           ` Peter Zijlstra
2025-10-14 12:37             ` Geert Uytterhoeven
2025-10-14 14:17               ` Peter Zijlstra
2025-10-14 15:04                 ` Geert Uytterhoeven
2025-08-26  9:27   ` Shrikanth Hegde
2025-09-01  3:57     ` K Prateek Nayak
2025-09-01  4:50     ` K Prateek Nayak
2025-08-26  4:13 ` [PATCH v7 5/8] sched/topology: Unify tl_smt_mask() across core and all arch K Prateek Nayak
2025-08-26  5:13   ` Christophe Leroy
2025-08-26  8:01   ` Peter Zijlstra
2025-08-26  8:11     ` Christophe Leroy
2025-08-26  8:24       ` Peter Zijlstra
2025-08-26  4:13 ` [PATCH v7 6/8] sched/topology: Unify tl_cls_mask() across core and x86 K Prateek Nayak
2025-08-26  5:14   ` Christophe Leroy
2025-08-26  4:13 ` [PATCH v7 7/8] sched/topology: Unify tl_mc_mask() across core and all arch K Prateek Nayak
2025-08-26  5:15   ` Christophe Leroy
2025-08-26  4:13 ` [PATCH v7 8/8] sched/topology: Unify tl_pkg_mask() " K Prateek Nayak
2025-08-26  5:16   ` Christophe Leroy
2025-08-26 10:05 ` [PATCH v7 0/8] sched/fair: Get rid of sched_domains_curr_level hack for tl->cpumask() Shrikanth Hegde
2025-08-26 10:13   ` Peter Zijlstra
2025-08-29  7:53     ` Valentin Schneider
2025-08-29  8:53       ` Shrikanth Hegde
2025-09-01  4:39         ` K Prateek Nayak
2025-09-01  8:58         ` Peter Zijlstra
2025-09-01 17:06           ` Shrikanth Hegde

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250901085236.GK4068168@noisy.programming.kicks-ass.net \
    --to=peterz@infradead.org \
    --cc=Jonathan.Cameron@huawei.com \
    --cc=agordeev@linux.ibm.com \
    --cc=arighi@nvidia.com \
    --cc=borntraeger@linux.ibm.com \
    --cc=bp@alien8.de \
    --cc=brgerst@gmail.com \
    --cc=bsegall@google.com \
    --cc=chenl311@chinatelecom.cn \
    --cc=christophe.leroy@csgroup.eu \
    --cc=dave.hansen@linux.intel.com \
    --cc=dietmar.eggemann@arm.com \
    --cc=easwar.hariharan@linux.microsoft.com \
    --cc=gor@linux.ibm.com \
    --cc=guoweikang.kernel@gmail.com \
    --cc=hca@linux.ibm.com \
    --cc=hpa@zytor.com \
    --cc=huschle@linux.ibm.com \
    --cc=juri.lelli@redhat.com \
    --cc=kprateek.nayak@amd.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=maddy@linux.ibm.com \
    --cc=maobibo@loongson.cn \
    --cc=meted@linux.ibm.com \
    --cc=mgorman@suse.de \
    --cc=mingo@redhat.com \
    --cc=mpe@ellerman.id.au \
    --cc=npiggin@gmail.com \
    --cc=patryk.wlazlyn@linux.intel.com \
    --cc=rafael.j.wysocki@intel.com \
    --cc=ricardo.neri-calderon@linux.intel.com \
    --cc=rostedt@goodmis.org \
    --cc=sshegde@linux.ibm.com \
    --cc=sudeep.holla@arm.com \
    --cc=svens@linux.ibm.com \
    --cc=swapnil.sapkal@amd.com \
    --cc=tglx@linutronix.de \
    --cc=thomas.weissschuh@linutronix.de \
    --cc=tim.c.chen@linux.intel.com \
    --cc=vincent.guittot@linaro.org \
    --cc=vinicius.gomes@intel.com \
    --cc=vschneid@redhat.com \
    --cc=x86@kernel.org \
    --cc=yangyicong@hisilicon.com \
    --cc=yury.norov@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®