mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH v2 0/2]  Remove HS400 support from common
@ 2025-09-08 17:38 Judith Mendez
  2025-09-08 17:38 ` [PATCH v2 1/2] arm64: dts: ti: k3-am62p/j722s: " Judith Mendez
  2025-09-08 17:38 ` [PATCH v2 2/2] arm64: dts: ti: k3-am62p: Update eMMC HS400 STRB value Judith Mendez
  0 siblings, 2 replies; 5+ messages in thread
From: Judith Mendez @ 2025-09-08 17:38 UTC (permalink / raw)
  To: Judith Mendez, Nishanth Menon
  Cc: Moteen Shah, Vignesh Raghavendra, Tero Kristo, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, linux-arm-kernel, devicetree,
	linux-kernel

Since eMMC HS400 has been descoped for j722s due to errata i2478 [0]
and is supported by default for AM62Px device, remove sdhci0 node from
common-main.dtsi and include instead only for AM62Px in am62p-main.dtsi.

Also, update the STRB value for am62p eMMC sdhci0 node.

Tested on am62p SK board.

[0] https://www.ti.com/lit/pdf/sprz575

Link to v1:
https://lore.kernel.org/linux-arm-kernel/20250904004723.2856005-1-jm@ti.com/

Changes from v1:
- Keep the common node and only remove hs400 support from the common
  node. Enable instead HS400 support only for AM62Px in am62p-main.dtsi.
- Fixup commit mesages according to new changes.

Judith Mendez (2):
  arm64: dts: ti: k3-am62p/j722s: Remove HS400 support from common
  arm64: dts: ti: k3-am62p: Update eMMC HS400 STRB value

 arch/arm64/boot/dts/ti/k3-am62p-j722s-common-main.dtsi | 3 ---
 arch/arm64/boot/dts/ti/k3-am62p-main.dtsi              | 6 ++++++
 2 files changed, 6 insertions(+), 3 deletions(-)

-- 
2.51.0


^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH v2 1/2] arm64: dts: ti: k3-am62p/j722s: Remove HS400 support from common
  2025-09-08 17:38 [PATCH v2 0/2] Remove HS400 support from common Judith Mendez
@ 2025-09-08 17:38 ` Judith Mendez
  2025-09-08 20:44   ` Andrew Davis
  2025-09-08 17:38 ` [PATCH v2 2/2] arm64: dts: ti: k3-am62p: Update eMMC HS400 STRB value Judith Mendez
  1 sibling, 1 reply; 5+ messages in thread
From: Judith Mendez @ 2025-09-08 17:38 UTC (permalink / raw)
  To: Judith Mendez, Nishanth Menon
  Cc: Moteen Shah, Vignesh Raghavendra, Tero Kristo, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, linux-arm-kernel, devicetree,
	linux-kernel

Since eMMC HS400 has been descoped for J722s due to errata i2478 [0]
and is supported for AM62Px device, remove eMMC HS400 support from
common-main.dtsi and include only in am62p-main.dtsi.

[0] https://www.ti.com/lit/pdf/sprz575
Signed-off-by: Judith Mendez <jm@ti.com>
---
 arch/arm64/boot/dts/ti/k3-am62p-j722s-common-main.dtsi | 3 ---
 arch/arm64/boot/dts/ti/k3-am62p-main.dtsi              | 6 ++++++
 2 files changed, 6 insertions(+), 3 deletions(-)

diff --git a/arch/arm64/boot/dts/ti/k3-am62p-j722s-common-main.dtsi b/arch/arm64/boot/dts/ti/k3-am62p-j722s-common-main.dtsi
index 4427b12058a6..0c05bcf1d776 100644
--- a/arch/arm64/boot/dts/ti/k3-am62p-j722s-common-main.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-am62p-j722s-common-main.dtsi
@@ -576,15 +576,12 @@ sdhci0: mmc@fa10000 {
 		bus-width = <8>;
 		mmc-ddr-1_8v;
 		mmc-hs200-1_8v;
-		mmc-hs400-1_8v;
 		ti,clkbuf-sel = <0x7>;
-		ti,strobe-sel = <0x77>;
 		ti,trm-icp = <0x8>;
 		ti,otap-del-sel-legacy = <0x1>;
 		ti,otap-del-sel-mmc-hs = <0x1>;
 		ti,otap-del-sel-ddr52 = <0x6>;
 		ti,otap-del-sel-hs200 = <0x8>;
-		ti,otap-del-sel-hs400 = <0x5>;
 		ti,itap-del-sel-legacy = <0x10>;
 		ti,itap-del-sel-mmc-hs = <0xa>;
 		ti,itap-del-sel-ddr52 = <0x3>;
diff --git a/arch/arm64/boot/dts/ti/k3-am62p-main.dtsi b/arch/arm64/boot/dts/ti/k3-am62p-main.dtsi
index 6aea9d3f134e..90afe21e972b 100644
--- a/arch/arm64/boot/dts/ti/k3-am62p-main.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-am62p-main.dtsi
@@ -31,6 +31,12 @@ usb1: usb@31100000 {
 			snps,usb2-lpm-disable;
 		};
 	};
+
+	sdhci0: mmc@fa10000 {
+		mmc-hs400-1_8v;
+		ti,strobe-sel = <0x77>;
+		ti,otap-del-sel-hs400 = <0x5>;
+	};
 };
 
 &oc_sram {
-- 
2.51.0


^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH v2 2/2] arm64: dts: ti: k3-am62p: Update eMMC HS400 STRB value
  2025-09-08 17:38 [PATCH v2 0/2] Remove HS400 support from common Judith Mendez
  2025-09-08 17:38 ` [PATCH v2 1/2] arm64: dts: ti: k3-am62p/j722s: " Judith Mendez
@ 2025-09-08 17:38 ` Judith Mendez
  1 sibling, 0 replies; 5+ messages in thread
From: Judith Mendez @ 2025-09-08 17:38 UTC (permalink / raw)
  To: Judith Mendez, Nishanth Menon
  Cc: Moteen Shah, Vignesh Raghavendra, Tero Kristo, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, linux-arm-kernel, devicetree,
	linux-kernel

STRB setting for eMMC HS400 have been updated in device datasheet [0],
so update for am62p in k3-am62p-main.

[0] https://www.ti.com/lit/gpn/am62p
Signed-off-by: Judith Mendez <jm@ti.com>
---
 arch/arm64/boot/dts/ti/k3-am62p-main.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/ti/k3-am62p-main.dtsi b/arch/arm64/boot/dts/ti/k3-am62p-main.dtsi
index 90afe21e972b..a1ce2fc8d947 100644
--- a/arch/arm64/boot/dts/ti/k3-am62p-main.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-am62p-main.dtsi
@@ -34,7 +34,7 @@ usb1: usb@31100000 {
 
 	sdhci0: mmc@fa10000 {
 		mmc-hs400-1_8v;
-		ti,strobe-sel = <0x77>;
+		ti,strobe-sel = <0x66>;
 		ti,otap-del-sel-hs400 = <0x5>;
 	};
 };
-- 
2.51.0


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH v2 1/2] arm64: dts: ti: k3-am62p/j722s: Remove HS400 support from common
  2025-09-08 17:38 ` [PATCH v2 1/2] arm64: dts: ti: k3-am62p/j722s: " Judith Mendez
@ 2025-09-08 20:44   ` Andrew Davis
  2025-09-08 23:25     ` Judith Mendez
  0 siblings, 1 reply; 5+ messages in thread
From: Andrew Davis @ 2025-09-08 20:44 UTC (permalink / raw)
  To: Judith Mendez, Nishanth Menon
  Cc: Moteen Shah, Vignesh Raghavendra, Tero Kristo, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, linux-arm-kernel, devicetree,
	linux-kernel

On 9/8/25 12:38 PM, Judith Mendez wrote:
> Since eMMC HS400 has been descoped for J722s due to errata i2478 [0]
> and is supported for AM62Px device, remove eMMC HS400 support from
> common-main.dtsi and include only in am62p-main.dtsi.
> 
> [0] https://www.ti.com/lit/pdf/sprz575
> Signed-off-by: Judith Mendez <jm@ti.com>
> ---
>   arch/arm64/boot/dts/ti/k3-am62p-j722s-common-main.dtsi | 3 ---
>   arch/arm64/boot/dts/ti/k3-am62p-main.dtsi              | 6 ++++++
>   2 files changed, 6 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/ti/k3-am62p-j722s-common-main.dtsi b/arch/arm64/boot/dts/ti/k3-am62p-j722s-common-main.dtsi
> index 4427b12058a6..0c05bcf1d776 100644
> --- a/arch/arm64/boot/dts/ti/k3-am62p-j722s-common-main.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-am62p-j722s-common-main.dtsi
> @@ -576,15 +576,12 @@ sdhci0: mmc@fa10000 {
>   		bus-width = <8>;
>   		mmc-ddr-1_8v;
>   		mmc-hs200-1_8v;
> -		mmc-hs400-1_8v;
>   		ti,clkbuf-sel = <0x7>;
> -		ti,strobe-sel = <0x77>;
>   		ti,trm-icp = <0x8>;
>   		ti,otap-del-sel-legacy = <0x1>;
>   		ti,otap-del-sel-mmc-hs = <0x1>;
>   		ti,otap-del-sel-ddr52 = <0x6>;
>   		ti,otap-del-sel-hs200 = <0x8>;
> -		ti,otap-del-sel-hs400 = <0x5>;
>   		ti,itap-del-sel-legacy = <0x10>;
>   		ti,itap-del-sel-mmc-hs = <0xa>;
>   		ti,itap-del-sel-ddr52 = <0x3>;
> diff --git a/arch/arm64/boot/dts/ti/k3-am62p-main.dtsi b/arch/arm64/boot/dts/ti/k3-am62p-main.dtsi
> index 6aea9d3f134e..90afe21e972b 100644
> --- a/arch/arm64/boot/dts/ti/k3-am62p-main.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-am62p-main.dtsi
> @@ -31,6 +31,12 @@ usb1: usb@31100000 {
>   			snps,usb2-lpm-disable;
>   		};
>   	};
> +
> +	sdhci0: mmc@fa10000 {

The node already has a label where it is defined, so you could just use:

&sdhci0 {
    ...

here at the base level, and not have it inside cbass_main.

Andrew

> +		mmc-hs400-1_8v;
> +		ti,strobe-sel = <0x77>;
> +		ti,otap-del-sel-hs400 = <0x5>;
> +	};
>   };
>   
>   &oc_sram {


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH v2 1/2] arm64: dts: ti: k3-am62p/j722s: Remove HS400 support from common
  2025-09-08 20:44   ` Andrew Davis
@ 2025-09-08 23:25     ` Judith Mendez
  0 siblings, 0 replies; 5+ messages in thread
From: Judith Mendez @ 2025-09-08 23:25 UTC (permalink / raw)
  To: Andrew Davis, Nishanth Menon
  Cc: Moteen Shah, Vignesh Raghavendra, Tero Kristo, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, linux-arm-kernel, devicetree,
	linux-kernel

Hi,

On 9/8/25 3:44 PM, Andrew Davis wrote:
> On 9/8/25 12:38 PM, Judith Mendez wrote:
>> Since eMMC HS400 has been descoped for J722s due to errata i2478 [0]
>> and is supported for AM62Px device, remove eMMC HS400 support from
>> common-main.dtsi and include only in am62p-main.dtsi.
>>
>> [0] https://www.ti.com/lit/pdf/sprz575
>> Signed-off-by: Judith Mendez <jm@ti.com>
>> ---
>>   arch/arm64/boot/dts/ti/k3-am62p-j722s-common-main.dtsi | 3 ---
>>   arch/arm64/boot/dts/ti/k3-am62p-main.dtsi              | 6 ++++++
>>   2 files changed, 6 insertions(+), 3 deletions(-)
>>
>> diff --git a/arch/arm64/boot/dts/ti/k3-am62p-j722s-common-main.dtsi b/ 
>> arch/arm64/boot/dts/ti/k3-am62p-j722s-common-main.dtsi
>> index 4427b12058a6..0c05bcf1d776 100644
>> --- a/arch/arm64/boot/dts/ti/k3-am62p-j722s-common-main.dtsi
>> +++ b/arch/arm64/boot/dts/ti/k3-am62p-j722s-common-main.dtsi
>> @@ -576,15 +576,12 @@ sdhci0: mmc@fa10000 {
>>           bus-width = <8>;
>>           mmc-ddr-1_8v;
>>           mmc-hs200-1_8v;
>> -        mmc-hs400-1_8v;
>>           ti,clkbuf-sel = <0x7>;
>> -        ti,strobe-sel = <0x77>;
>>           ti,trm-icp = <0x8>;
>>           ti,otap-del-sel-legacy = <0x1>;
>>           ti,otap-del-sel-mmc-hs = <0x1>;
>>           ti,otap-del-sel-ddr52 = <0x6>;
>>           ti,otap-del-sel-hs200 = <0x8>;
>> -        ti,otap-del-sel-hs400 = <0x5>;
>>           ti,itap-del-sel-legacy = <0x10>;
>>           ti,itap-del-sel-mmc-hs = <0xa>;
>>           ti,itap-del-sel-ddr52 = <0x3>;
>> diff --git a/arch/arm64/boot/dts/ti/k3-am62p-main.dtsi b/arch/arm64/ 
>> boot/dts/ti/k3-am62p-main.dtsi
>> index 6aea9d3f134e..90afe21e972b 100644
>> --- a/arch/arm64/boot/dts/ti/k3-am62p-main.dtsi
>> +++ b/arch/arm64/boot/dts/ti/k3-am62p-main.dtsi
>> @@ -31,6 +31,12 @@ usb1: usb@31100000 {
>>               snps,usb2-lpm-disable;
>>           };
>>       };
>> +
>> +    sdhci0: mmc@fa10000 {
> 
> The node already has a label where it is defined, so you could just use:
> 
> &sdhci0 {
>     ...
> 
> here at the base level, and not have it inside cbass_main.
> 

Oops, missed that detail, thanks Andrew. Will fix for v3.

~ Judith


^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2025-09-08 23:25 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-09-08 17:38 [PATCH v2 0/2] Remove HS400 support from common Judith Mendez
2025-09-08 17:38 ` [PATCH v2 1/2] arm64: dts: ti: k3-am62p/j722s: " Judith Mendez
2025-09-08 20:44   ` Andrew Davis
2025-09-08 23:25     ` Judith Mendez
2025-09-08 17:38 ` [PATCH v2 2/2] arm64: dts: ti: k3-am62p: Update eMMC HS400 STRB value Judith Mendez

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®