mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Sven Peter <sven@kernel.org>
To: Heikki Krogerus <heikki.krogerus@linux.intel.com>,
	 Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Janne Grunau <j@jannau.net>, Neal Gompa <neal@gompa.dev>,
	 linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
	 asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
	 Sven Peter <sven@kernel.org>, Hector Martin <marcan@marcan.st>
Subject: [PATCH 08/11] usb: typec: tipd: Update partner identity when power status was updated
Date: Sun, 14 Sep 2025 12:56:13 +0000	[thread overview]
Message-ID: <20250914-apple-usb3-tipd-v1-8-4e99c8649024@kernel.org> (raw)
In-Reply-To: <20250914-apple-usb3-tipd-v1-0-4e99c8649024@kernel.org>

From: Hector Martin <marcan@marcan.st>

Whenever the power status is changed make sure to also update the
partner identity to be able to detect changes once de-bouncing and mode
changes are added for CD321x.

Signed-off-by: Hector Martin <marcan@marcan.st>
Reviewed-by: Neal Gompa <neal@gompa.dev>
Signed-off-by: Sven Peter <sven@kernel.org>
---
 drivers/usb/typec/tipd/core.c | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/drivers/usb/typec/tipd/core.c b/drivers/usb/typec/tipd/core.c
index c7cf936e5a61a331271c05b68ff1b77b89c0f643..e16c6c07c72a3e285f1fc94db72bed8dc3217a1d 100644
--- a/drivers/usb/typec/tipd/core.c
+++ b/drivers/usb/typec/tipd/core.c
@@ -635,9 +635,16 @@ static irqreturn_t cd321x_interrupt(int irq, void *data)
 	if (!tps6598x_read_status(tps, &status))
 		goto err_unlock;
 
-	if (event & APPLE_CD_REG_INT_POWER_STATUS_UPDATE)
+	if (event & APPLE_CD_REG_INT_POWER_STATUS_UPDATE) {
 		if (!tps6598x_read_power_status(tps))
 			goto err_unlock;
+		if (TPS_POWER_STATUS_PWROPMODE(tps->pwr_status) == TYPEC_PWR_MODE_PD) {
+			if (tps6598x_read_partner_identity(tps)) {
+				dev_err(tps->dev, "failed to read partner identity\n");
+				tps->partner_identity = (struct usb_pd_identity) {0};
+			}
+		}
+	}
 
 	if (event & APPLE_CD_REG_INT_DATA_STATUS_UPDATE)
 		if (!tps->data->read_data_status(tps))

-- 
2.34.1



  parent reply	other threads:[~2025-09-14 12:56 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-14 12:56 [PATCH 00/11] Apple Silicon USB3 support - TIPD changes Sven Peter
2025-09-14 12:56 ` [PATCH 01/11] usb: typec: tipd: Clear interrupts first Sven Peter
2025-09-14 12:56 ` [PATCH 02/11] usb: typec: tipd: Move initial irq mask to tipd_data Sven Peter
2025-09-14 12:56 ` [PATCH 03/11] usb: typec: tipd: Move switch_power_state " Sven Peter
2025-09-14 12:56 ` [PATCH 04/11] usb: typec: tipd: Trace data status for CD321x correctly Sven Peter
2025-09-14 12:56 ` [PATCH 05/11] usb: typec: tipd: Add cd321x struct with separate size Sven Peter
2025-09-14 12:56 ` [PATCH 06/11] usb: typec: tipd: Read USB4, Thunderbolt and DisplayPort status for cd321x Sven Peter
2025-09-14 12:56 ` [PATCH 07/11] usb: typec: tipd: Register DisplayPort and Thunderbolt altmodes " Sven Peter
2025-09-14 12:56 ` Sven Peter [this message]
2025-09-15 13:14   ` [PATCH 08/11] usb: typec: tipd: Update partner identity when power status was updated Heikki Krogerus
2025-09-14 12:56 ` [PATCH 09/11] usb: typec: tipd: Use read_power_status function in probe Sven Peter
2025-09-14 12:56 ` [PATCH 10/11] usb: typec: tipd: Read data status in probe and cache its value Sven Peter
2025-09-14 12:56 ` [PATCH 11/11] usb: typec: tipd: Handle mode transitions for CD321x Sven Peter
2025-09-14 13:29   ` Janne Grunau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250914-apple-usb3-tipd-v1-8-4e99c8649024@kernel.org \
    --to=sven@kernel.org \
    --cc=asahi@lists.linux.dev \
    --cc=gregkh@linuxfoundation.org \
    --cc=heikki.krogerus@linux.intel.com \
    --cc=j@jannau.net \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=marcan@marcan.st \
    --cc=neal@gompa.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®