From: Sven Peter <sven@kernel.org>
To: Heikki Krogerus <heikki.krogerus@linux.intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Janne Grunau <j@jannau.net>, Neal Gompa <neal@gompa.dev>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
Sven Peter <sven@kernel.org>, Hector Martin <marcan@marcan.st>
Subject: [PATCH 09/11] usb: typec: tipd: Use read_power_status function in probe
Date: Sun, 14 Sep 2025 12:56:14 +0000 [thread overview]
Message-ID: <20250914-apple-usb3-tipd-v1-9-4e99c8649024@kernel.org> (raw)
In-Reply-To: <20250914-apple-usb3-tipd-v1-0-4e99c8649024@kernel.org>
From: Hector Martin <marcan@marcan.st>
We need the initial power status to be able to reliably detect connector
changes once we introduce de-bouncing for CD321x next. read_power_status
takes care of this and also forwards the status to the trace subsystem
so let's use that instead of open-coding it inside probe.
Signed-off-by: Hector Martin <marcan@marcan.st>
Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Reviewed-by: Neal Gompa <neal@gompa.dev>
Signed-off-by: Sven Peter <sven@kernel.org>
---
drivers/usb/typec/tipd/core.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/usb/typec/tipd/core.c b/drivers/usb/typec/tipd/core.c
index e16c6c07c72a3e285f1fc94db72bed8dc3217a1d..f546f4ae563af3d411ec6591fe9c3b122e4efaab 100644
--- a/drivers/usb/typec/tipd/core.c
+++ b/drivers/usb/typec/tipd/core.c
@@ -1549,11 +1549,8 @@ static int tps6598x_probe(struct i2c_client *client)
goto err_role_put;
if (status & TPS_STATUS_PLUG_PRESENT) {
- ret = tps6598x_read16(tps, TPS_REG_POWER_STATUS, &tps->pwr_status);
- if (ret < 0) {
- dev_err(tps->dev, "failed to read power status: %d\n", ret);
+ if (!tps6598x_read_power_status(tps))
goto err_unregister_port;
- }
ret = tps6598x_connect(tps, status);
if (ret)
dev_err(&client->dev, "failed to register partner\n");
--
2.34.1
next prev parent reply other threads:[~2025-09-14 12:56 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-14 12:56 [PATCH 00/11] Apple Silicon USB3 support - TIPD changes Sven Peter
2025-09-14 12:56 ` [PATCH 01/11] usb: typec: tipd: Clear interrupts first Sven Peter
2025-09-14 12:56 ` [PATCH 02/11] usb: typec: tipd: Move initial irq mask to tipd_data Sven Peter
2025-09-14 12:56 ` [PATCH 03/11] usb: typec: tipd: Move switch_power_state " Sven Peter
2025-09-14 12:56 ` [PATCH 04/11] usb: typec: tipd: Trace data status for CD321x correctly Sven Peter
2025-09-14 12:56 ` [PATCH 05/11] usb: typec: tipd: Add cd321x struct with separate size Sven Peter
2025-09-14 12:56 ` [PATCH 06/11] usb: typec: tipd: Read USB4, Thunderbolt and DisplayPort status for cd321x Sven Peter
2025-09-14 12:56 ` [PATCH 07/11] usb: typec: tipd: Register DisplayPort and Thunderbolt altmodes " Sven Peter
2025-09-14 12:56 ` [PATCH 08/11] usb: typec: tipd: Update partner identity when power status was updated Sven Peter
2025-09-15 13:14 ` Heikki Krogerus
2025-09-14 12:56 ` Sven Peter [this message]
2025-09-14 12:56 ` [PATCH 10/11] usb: typec: tipd: Read data status in probe and cache its value Sven Peter
2025-09-14 12:56 ` [PATCH 11/11] usb: typec: tipd: Handle mode transitions for CD321x Sven Peter
2025-09-14 13:29 ` Janne Grunau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250914-apple-usb3-tipd-v1-9-4e99c8649024@kernel.org \
--to=sven@kernel.org \
--cc=asahi@lists.linux.dev \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=j@jannau.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=marcan@marcan.st \
--cc=neal@gompa.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®