mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH v3 0/5] riscv: Use __riscv_has_extension_{likely,unlikely}
@ 2025-10-10 23:35 Vivian Wang
  2025-10-10 23:35 ` [PATCH v3 1/5] riscv: pgtable: Use __riscv_has_extension_unlikely Vivian Wang
                   ` (6 more replies)
  0 siblings, 7 replies; 9+ messages in thread
From: Vivian Wang @ 2025-10-10 23:35 UTC (permalink / raw)
  To: Paul Walmsley, Palmer Dabbelt, Albert Ou, Alexandre Ghiti,
	Yury Norov, Rasmus Villemoes, Paul Walmsley
  Cc: Charlie Jenkins, Xiao Wang, Christoph Müllner, Vivian Wang,
	Vivian Wang, linux-riscv, linux-kernel

There are about a dozen uses of asm goto in arch/riscv just to select
between two code paths with the alternative mechanism. Convert them to
the existing helpers __riscv_has_extension_{likely,unlikely}.

In each case, I have preserved the existing code's choice of asm goto
pattern while picking between "likely" and "unlikely", namely:

  ALTERNATIVE("j %l[no]", "nop", ...)   -> "likely"
  ALTERNATIVE("nop", "j %l[yes]", ...)  -> "unlikely"

Since the helpers are just implementations of these patterns, the
performance should be the same as before.

These patches are also available at:

https://github.com/dramforever/linux/tree/riscv/altn-helper/v2

---
Changes in v3:
- Rebased on riscv for-next
  - Resolve conflict, use ALT_RISCV_PAUSE() in moved lines
- Link to v2: https://lore.kernel.org/r/20250821-riscv-altn-helper-wip-v2-0-9586fa702f78@iscas.ac.cn

Changes in v2:
- Cc'd authors who initially introduced the asm goto blocks
- Use existing __riscv_has_extension_{likely,unlikely} instead
- Remove bogus comment for Zbb being likely (checksum)
- Restructured patch to minimize diff (bitops, hweight, cmpxchg)
- Link to v1: https://lore.kernel.org/r/20250820-riscv-altn-helper-wip-v1-0-c3c626c1f7e6@iscas.ac.cn

---
Vivian Wang (5):
      riscv: pgtable: Use __riscv_has_extension_unlikely
      riscv: checksum: Use __riscv_has_extension_likely
      riscv: hweight: Use __riscv_has_extension_likely
      riscv: bitops: Use __riscv_has_extension_likely
      riscv: cmpxchg: Use __riscv_has_extension_likely

 arch/riscv/include/asm/arch_hweight.h | 24 ++++++----------
 arch/riscv/include/asm/bitops.h       | 32 ++++++---------------
 arch/riscv/include/asm/checksum.h     | 13 +++------
 arch/riscv/include/asm/cmpxchg.h      | 12 +++-----
 arch/riscv/include/asm/pgtable.h      | 15 +++++-----
 arch/riscv/lib/csum.c                 | 53 ++++++++---------------------------
 arch/riscv/mm/pgtable.c               | 22 +++++++--------
 7 files changed, 53 insertions(+), 118 deletions(-)
---
base-commit: cd5a0afbdf8033dc83786315d63f8b325bdba2fd
change-id: 20250820-riscv-altn-helper-wip-00af3a552c37

Best regards,
-- 
Vivian "dramforever" Wang


^ permalink raw reply	[flat|nested] 9+ messages in thread
end of thread, other threads:[~2025-10-11 22:21 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-10-10 23:35 [PATCH v3 0/5] riscv: Use __riscv_has_extension_{likely,unlikely} Vivian Wang
2025-10-10 23:35 ` [PATCH v3 1/5] riscv: pgtable: Use __riscv_has_extension_unlikely Vivian Wang
2025-10-10 23:35 ` [PATCH v3 2/5] riscv: checksum: Use __riscv_has_extension_likely Vivian Wang
2025-10-10 23:35 ` [PATCH v3 3/5] riscv: hweight: " Vivian Wang
2025-10-10 23:35 ` [PATCH v3 4/5] riscv: bitops: " Vivian Wang
2025-10-10 23:35 ` [PATCH v3 5/5] riscv: cmpxchg: " Vivian Wang
2025-10-10 23:38 ` [PATCH v3 0/5] riscv: Use __riscv_has_extension_{likely,unlikely} Vivian Wang
2025-10-11 11:28 ` Conor Dooley
2025-10-11 22:21   ` Vivian Wang

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®