mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH 1/2] PM: EM: Remove an unused variable in em_notify_pd_deleted()
@ 2025-10-20  8:44 Changwoo Min
  2025-10-20  8:44 ` [PATCH 2/2] PM: EM: Include the iterator/accessor code for the performance domain conditionally Changwoo Min
  2025-10-20 12:17 ` [PATCH 1/2] PM: EM: Remove an unused variable in em_notify_pd_deleted() Rafael J. Wysocki
  0 siblings, 2 replies; 4+ messages in thread
From: Changwoo Min @ 2025-10-20  8:44 UTC (permalink / raw)
  To: lukasz.luba, rafael, len.brown, pavel
  Cc: christian.loehle, tj, kernel-dev, linux-pm, sched-ext,
	linux-kernel, Changwoo Min, kernel test robot

The variable `ret` in em_notify_pd_deleted() is set but not used, so
that it causes the following warning:

>> kernel/power/em_netlink.c:228:6: warning: variable 'ret' set but
   not used [-Wunused-but-set-variable]

So, let's remove the unused `ret` to avoid the warning.

Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202510151223.THlBK6QR-lkp@intel.com/
Signed-off-by: Changwoo Min <changwoo@igalia.com>
---
 kernel/power/em_netlink.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/kernel/power/em_netlink.c b/kernel/power/em_netlink.c
index 2c55c758de6b..48752189a07b 100644
--- a/kernel/power/em_netlink.c
+++ b/kernel/power/em_netlink.c
@@ -269,7 +269,6 @@ static int __em_notify_pd_deleted_size(const struct em_perf_domain *pd)
 void em_notify_pd_deleted(const struct em_perf_domain *pd)
 {
 	struct sk_buff *msg;
-	int ret = -EMSGSIZE;
 	void *hdr;
 	int msg_sz;
 
@@ -287,7 +286,6 @@ void em_notify_pd_deleted(const struct em_perf_domain *pd)
 		goto out_free_msg;
 
 	if (nla_put_u32(msg, EM_A_PD_TABLE_PD_ID, pd->id)) {
-		ret = -EMSGSIZE;
 		goto out_free_msg;
 	}
 
-- 
2.51.1.dirty


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2025-10-20 21:27 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-10-20  8:44 [PATCH 1/2] PM: EM: Remove an unused variable in em_notify_pd_deleted() Changwoo Min
2025-10-20  8:44 ` [PATCH 2/2] PM: EM: Include the iterator/accessor code for the performance domain conditionally Changwoo Min
2025-10-20 12:17 ` [PATCH 1/2] PM: EM: Remove an unused variable in em_notify_pd_deleted() Rafael J. Wysocki
2025-10-20 21:27   ` Changwoo Min

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®