mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Thomas Weißschuh" <linux@weissschuh.net>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	 "Rafael J. Wysocki" <rafael@kernel.org>,
	Danilo Krummrich <dakr@kernel.org>
Cc: linux-kernel@vger.kernel.org, "Thomas Weißschuh" <linux@weissschuh.net>
Subject: [PATCH v5 3/7] sysfs: introduce __SYSFS_FUNCTION_ALTERNATIVE()
Date: Wed, 29 Oct 2025 09:12:12 +0100	[thread overview]
Message-ID: <20251029-sysfs-const-attr-prep-v5-3-ea7d745acff4@weissschuh.net> (raw)
In-Reply-To: <20251029-sysfs-const-attr-prep-v5-0-ea7d745acff4@weissschuh.net>

For the constification phase of 'struct attribute' various callback
struct members will need to exist in both const and non-const variants.
Keeping both members in a union avoids memory and CPU overhead but will
be detected and trapped by Control Flow Integrity (CFI). By deciding
between a struct and a union depending whether CFI is enabled, most
configurations can avoid this overhead. Code using these callbacks will
still need to be updated to handle both members explicitly.
In the union case the compiler will recognize that testing for one union
member is enough and optimize away the code for the other one.

Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
---
 include/linux/sysfs.h | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/include/linux/sysfs.h b/include/linux/sysfs.h
index 92f82cee5f11..9cef5bf24ba7 100644
--- a/include/linux/sysfs.h
+++ b/include/linux/sysfs.h
@@ -58,6 +58,12 @@ do {							\
 #define sysfs_attr_init(attr) do {} while (0)
 #endif
 
+#ifdef CONFIG_CFI
+#define __SYSFS_FUNCTION_ALTERNATIVE(MEMBERS...) struct { MEMBERS }
+#else
+#define __SYSFS_FUNCTION_ALTERNATIVE(MEMBERS...) union { MEMBERS }
+#endif
+
 /**
  * struct attribute_group - data structure used to declare an attribute group.
  * @name:	Optional: Attribute group name

-- 
2.51.1.dirty


  parent reply	other threads:[~2025-10-29  8:12 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-29  8:12 [PATCH v5 0/7] sysfs: prepare the constification of struct attribute Thomas Weißschuh
2025-10-29  8:12 ` [PATCH v5 1/7] sysfs: attribute_group: allow registration of const attribute Thomas Weißschuh
2025-10-29  8:12 ` [PATCH v5 2/7] sysfs: transparently handle const pointers in ATTRIBUTE_GROUPS() Thomas Weißschuh
2025-10-29  8:12 ` Thomas Weißschuh [this message]
2025-10-29  8:12 ` [PATCH v5 4/7] sysfs: attribute_group: enable const variants of is_visible() Thomas Weißschuh
2025-10-29  8:12 ` [PATCH v5 5/7] samples/kobject: add is_visible() callback to attribute group Thomas Weißschuh
2025-10-29  8:12 ` [PATCH v5 6/7] samples/kobject: constify 'struct foo_attribute' Thomas Weißschuh
2025-10-29  8:12 ` [PATCH v5 7/7] sysfs: simplify attribute definition macros Thomas Weißschuh
2025-11-26 14:17 ` [PATCH v5 0/7] sysfs: prepare the constification of struct attribute Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251029-sysfs-const-attr-prep-v5-3-ea7d745acff4@weissschuh.net \
    --to=linux@weissschuh.net \
    --cc=dakr@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rafael@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®