* [PATCH] regmap: sdw-mbq: Reorder regmap_mbq_context struct for better packing
@ 2025-11-06 14:54 Charles Keepax
2025-11-06 15:08 ` Mark Brown
0 siblings, 1 reply; 2+ messages in thread
From: Charles Keepax @ 2025-11-06 14:54 UTC (permalink / raw)
To: broonie; +Cc: linux-kernel, patches
Reduce the packing by reordering the regmap_mbq_context structure.
Signed-off-by: Charles Keepax <ckeepax@opensource.cirrus.com>
---
drivers/base/regmap/regmap-sdw-mbq.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/base/regmap/regmap-sdw-mbq.c b/drivers/base/regmap/regmap-sdw-mbq.c
index 86644bbd07100..225c158d7f9d7 100644
--- a/drivers/base/regmap/regmap-sdw-mbq.c
+++ b/drivers/base/regmap/regmap-sdw-mbq.c
@@ -16,10 +16,11 @@
struct regmap_mbq_context {
struct device *dev;
+ bool (*readable_reg)(struct device *dev, unsigned int reg);
+
struct regmap_sdw_mbq_cfg cfg;
int val_size;
- bool (*readable_reg)(struct device *dev, unsigned int reg);
};
static int regmap_sdw_mbq_size(struct regmap_mbq_context *ctx, unsigned int reg)
--
2.47.3
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] regmap: sdw-mbq: Reorder regmap_mbq_context struct for better packing
2025-11-06 14:54 [PATCH] regmap: sdw-mbq: Reorder regmap_mbq_context struct for better packing Charles Keepax
@ 2025-11-06 15:08 ` Mark Brown
0 siblings, 0 replies; 2+ messages in thread
From: Mark Brown @ 2025-11-06 15:08 UTC (permalink / raw)
To: Charles Keepax; +Cc: linux-kernel, patches
[-- Attachment #1: Type: text/plain, Size: 292 bytes --]
On Thu, Nov 06, 2025 at 02:54:02PM +0000, Charles Keepax wrote:
> Reduce the packing by reordering the regmap_mbq_context structure.
Surely increase/improve the packing? Usually I'd expect a patch like
this to quote some data showing the improvement (eg, pahole output or
structure size).
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-11-06 15:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-11-06 14:54 [PATCH] regmap: sdw-mbq: Reorder regmap_mbq_context struct for better packing Charles Keepax
2025-11-06 15:08 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®