[PATCH] regmap: sdw-mbq: Reorder regmap_mbq_context struct for better packing

[PATCH] regmap: sdw-mbq: Reorder regmap_mbq_context struct for better packing

[Charles Keepax]

Reduce the packing by reordering the regmap_mbq_context structure.

Signed-off-by: Charles Keepax <ckeepax@opensource.cirrus.com>
---
 drivers/base/regmap/regmap-sdw-mbq.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/base/regmap/regmap-sdw-mbq.c b/drivers/base/regmap/regmap-sdw-mbq.c
index 86644bbd07100..225c158d7f9d7 100644
--- a/drivers/base/regmap/regmap-sdw-mbq.c
+++ b/drivers/base/regmap/regmap-sdw-mbq.c
@@ -16,10 +16,11 @@
 struct regmap_mbq_context {
 	struct device *dev;
 
+	bool (*readable_reg)(struct device *dev, unsigned int reg);
+
 	struct regmap_sdw_mbq_cfg cfg;
 
 	int val_size;
-	bool (*readable_reg)(struct device *dev, unsigned int reg);
 };
 
 static int regmap_sdw_mbq_size(struct regmap_mbq_context *ctx, unsigned int reg)
-- 
2.47.3

Re: [PATCH] regmap: sdw-mbq: Reorder regmap_mbq_context struct for better packing

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 292 bytes --]

On Thu, Nov 06, 2025 at 02:54:02PM +0000, Charles Keepax wrote:

> Reduce the packing by reordering the regmap_mbq_context structure.

Surely increase/improve the packing?  Usually I'd expect a patch like
this to quote some data showing the improvement (eg, pahole output or
structure size).

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]