* [PATCH] usb: typec: tipd: mark as orientation aware
@ 2025-11-07 15:13 Peter Korsgaard
2025-11-10 8:21 ` Heikki Krogerus
0 siblings, 1 reply; 2+ messages in thread
From: Peter Korsgaard @ 2025-11-07 15:13 UTC (permalink / raw)
To: javier.carrasco, heikki.krogerus, neal, gregkh, linux-usb
Cc: Peter Korsgaard, linux-kernel
The driver contains orientation detection logic and correctly calls
typec_set_orientation(), but forgets to set the orientation_aware
capability, so the orientation value is not visible in sysfs - Fix that.
Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
---
drivers/usb/typec/tipd/core.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/usb/typec/tipd/core.c b/drivers/usb/typec/tipd/core.c
index 2b1049c9a6f3..d561032a2970 100644
--- a/drivers/usb/typec/tipd/core.c
+++ b/drivers/usb/typec/tipd/core.c
@@ -1695,6 +1695,7 @@ tps25750_register_port(struct tps6598x *tps, struct fwnode_handle *fwnode)
typec_cap.data = ret;
typec_cap.revision = USB_TYPEC_REV_1_3;
typec_cap.pd_revision = 0x300;
+ typec_cap.orientation_aware = true;
typec_cap.driver_data = tps;
typec_cap.ops = &tps6598x_ops;
typec_cap.fwnode = fwnode;
--
2.39.5
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] usb: typec: tipd: mark as orientation aware
2025-11-07 15:13 [PATCH] usb: typec: tipd: mark as orientation aware Peter Korsgaard
@ 2025-11-10 8:21 ` Heikki Krogerus
0 siblings, 0 replies; 2+ messages in thread
From: Heikki Krogerus @ 2025-11-10 8:21 UTC (permalink / raw)
To: Peter Korsgaard; +Cc: javier.carrasco, neal, gregkh, linux-usb, linux-kernel
Fri, Nov 07, 2025 at 04:13:10PM +0100, Peter Korsgaard kirjoitti:
> The driver contains orientation detection logic and correctly calls
> typec_set_orientation(), but forgets to set the orientation_aware
> capability, so the orientation value is not visible in sysfs - Fix that.
>
> Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> ---
> drivers/usb/typec/tipd/core.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/usb/typec/tipd/core.c b/drivers/usb/typec/tipd/core.c
> index 2b1049c9a6f3..d561032a2970 100644
> --- a/drivers/usb/typec/tipd/core.c
> +++ b/drivers/usb/typec/tipd/core.c
> @@ -1695,6 +1695,7 @@ tps25750_register_port(struct tps6598x *tps, struct fwnode_handle *fwnode)
> typec_cap.data = ret;
> typec_cap.revision = USB_TYPEC_REV_1_3;
> typec_cap.pd_revision = 0x300;
> + typec_cap.orientation_aware = true;
> typec_cap.driver_data = tps;
> typec_cap.ops = &tps6598x_ops;
> typec_cap.fwnode = fwnode;
> --
> 2.39.5
--
heikki
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-11-10 8:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-11-07 15:13 [PATCH] usb: typec: tipd: mark as orientation aware Peter Korsgaard
2025-11-10 8:21 ` Heikki Krogerus
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®