mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: Will Deacon <will@kernel.org>
Cc: James Clark <james.clark@linaro.org>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Jonathan Corbet <corbet@lwn.net>, Marc Zyngier <maz@kernel.org>,
	Oliver Upton <oliver.upton@linux.dev>,
	Joey Gouly <joey.gouly@arm.com>,
	Suzuki K Poulose <suzuki.poulose@arm.com>,
	Zenghui Yu <yuzenghui@huawei.com>, Ingo Molnar <mingo@redhat.com>,
	Arnaldo Carvalho de Melo <acme@kernel.org>,
	Namhyung Kim <namhyung@kernel.org>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Jiri Olsa <jolsa@kernel.org>, Ian Rogers <irogers@google.com>,
	Adrian Hunter <adrian.hunter@intel.com>,
	Leo Yan <leo.yan@arm.com>,
	Anshuman Khandual <anshuman.khandual@arm.com>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
	linux-doc@vger.kernel.org, kvmarm@lists.linux.dev
Subject: Re: [PATCH v9 1/5] perf: Add perf_event_attr::config4
Date: Tue, 11 Nov 2025 11:55:45 +0100	[thread overview]
Message-ID: <20251111105545.GJ278048@noisy.programming.kicks-ass.net> (raw)
In-Reply-To: <aQi9MstZTsloKmeo@willie-the-truck>

On Mon, Nov 03, 2025 at 02:33:22PM +0000, Will Deacon wrote:
> On Wed, Oct 29, 2025 at 03:46:01PM +0000, James Clark wrote:
> > Arm FEAT_SPE_FDS adds the ability to filter on the data source of a
> > packet using another 64-bits of event filtering control. As the existing
> > perf_event_attr::configN fields are all used up for SPE PMU, an
> > additional field is needed. Add a new 'config4' field.
> > 
> > Reviewed-by: Leo Yan <leo.yan@arm.com>
> > Tested-by: Leo Yan <leo.yan@arm.com>
> > Reviewed-by: Ian Rogers <irogers@google.com>
> > Signed-off-by: James Clark <james.clark@linaro.org>
> > ---
> >  include/uapi/linux/perf_event.h | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/include/uapi/linux/perf_event.h b/include/uapi/linux/perf_event.h
> > index 78a362b80027..0d0ed85ad8cb 100644
> > --- a/include/uapi/linux/perf_event.h
> > +++ b/include/uapi/linux/perf_event.h
> > @@ -382,6 +382,7 @@ enum perf_event_read_format {
> >  #define PERF_ATTR_SIZE_VER6			120	/* Add: aux_sample_size */
> >  #define PERF_ATTR_SIZE_VER7			128	/* Add: sig_data */
> >  #define PERF_ATTR_SIZE_VER8			136	/* Add: config3 */
> > +#define PERF_ATTR_SIZE_VER9			144	/* add: config4 */
> >  
> >  /*
> >   * 'struct perf_event_attr' contains various attributes that define
> > @@ -543,6 +544,7 @@ struct perf_event_attr {
> >  	__u64	sig_data;
> >  
> >  	__u64	config3; /* extension of config2 */
> > +	__u64	config4; /* extension of config3 */
> 
> Please can one of the core perf maintainers ack/nak this extension?

Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org>

  reply	other threads:[~2025-11-11 10:55 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-29 15:46 [PATCH v9 0/5] perf: arm_spe: Armv8.8 SPE features James Clark
2025-10-29 15:46 ` [PATCH v9 1/5] perf: Add perf_event_attr::config4 James Clark
2025-11-03 14:33   ` Will Deacon
2025-11-11 10:55     ` Peter Zijlstra [this message]
2025-10-29 15:46 ` [PATCH v9 2/5] perf: arm_spe: Add support for filtering on data source James Clark
2025-11-10 15:48   ` Peter Zijlstra
2025-11-11 10:51     ` James Clark
2025-11-11 10:55       ` Peter Zijlstra
2025-10-29 15:46 ` [PATCH v9 3/5] tools headers UAPI: Sync linux/perf_event.h with the kernel sources James Clark
2025-10-29 15:46 ` [PATCH v9 4/5] perf tools: Add support for perf_event_attr::config4 James Clark
2025-10-29 15:46 ` [PATCH v9 5/5] perf docs: arm-spe: Document new SPE filtering features James Clark

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251111105545.GJ278048@noisy.programming.kicks-ass.net \
    --to=peterz@infradead.org \
    --cc=acme@kernel.org \
    --cc=adrian.hunter@intel.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=anshuman.khandual@arm.com \
    --cc=catalin.marinas@arm.com \
    --cc=corbet@lwn.net \
    --cc=irogers@google.com \
    --cc=james.clark@linaro.org \
    --cc=joey.gouly@arm.com \
    --cc=jolsa@kernel.org \
    --cc=kvmarm@lists.linux.dev \
    --cc=leo.yan@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=maz@kernel.org \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=oliver.upton@linux.dev \
    --cc=suzuki.poulose@arm.com \
    --cc=will@kernel.org \
    --cc=yuzenghui@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®