* [PATCH] drm/panel: jadard-jd9365da-h3: Use dev_err_probe() instead of DRM_DEV_ERROR() during probing
@ 2025-11-17 6:47 Abhishek Rajput
2025-11-18 8:44 ` neil.armstrong
2025-11-19 16:49 ` Neil Armstrong
0 siblings, 2 replies; 3+ messages in thread
From: Abhishek Rajput @ 2025-11-17 6:47 UTC (permalink / raw)
To: jagan, neil.armstrong, jessica.zhang, maarten.lankhorst, mripard,
tzimmermann, airlied, simona
Cc: dri-devel, linux-kernel, abhiraj21put
The DRM_DEV_ERROR() has been deprecated, and use dev_err_probe()
can be better. The other reason is that dev_err_probe() help avoid
unexpected repeated err logs during defered probing.
Signed-off-by: Abhishek Rajput <abhiraj21put@gmail.com>
diff --git a/drivers/gpu/drm/panel/panel-jadard-jd9365da-h3.c b/drivers/gpu/drm/panel/panel-jadard-jd9365da-h3.c
index 5c2530598ddb..aa05316dc57b 100644
--- a/drivers/gpu/drm/panel/panel-jadard-jd9365da-h3.c
+++ b/drivers/gpu/drm/panel/panel-jadard-jd9365da-h3.c
@@ -1132,22 +1132,19 @@ static int jadard_dsi_probe(struct mipi_dsi_device *dsi)
dsi->lanes = desc->lanes;
jadard->reset = devm_gpiod_get(dev, "reset", GPIOD_OUT_HIGH);
- if (IS_ERR(jadard->reset)) {
- DRM_DEV_ERROR(&dsi->dev, "failed to get our reset GPIO\n");
- return PTR_ERR(jadard->reset);
- }
+ if (IS_ERR(jadard->reset))
+ return dev_err_probe(&dsi->dev, PTR_ERR(jadard->reset),
+ "failed to get our reset GPIO\n");
jadard->vdd = devm_regulator_get(dev, "vdd");
- if (IS_ERR(jadard->vdd)) {
- DRM_DEV_ERROR(&dsi->dev, "failed to get vdd regulator\n");
- return PTR_ERR(jadard->vdd);
- }
+ if (IS_ERR(jadard->vdd))
+ return dev_err_probe(&dsi->dev, PTR_ERR(jadard->vdd),
+ "failed to get vdd regulator\n");
jadard->vccio = devm_regulator_get(dev, "vccio");
- if (IS_ERR(jadard->vccio)) {
- DRM_DEV_ERROR(&dsi->dev, "failed to get vccio regulator\n");
- return PTR_ERR(jadard->vccio);
- }
+ if (IS_ERR(jadard->vccio))
+ return dev_err_probe(&dsi->dev, PTR_ERR(jadard->vccio),
+ "failed to get vccio regulator\n");
ret = of_drm_get_panel_orientation(dev->of_node, &jadard->orientation);
if (ret < 0)
--
2.43.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/panel: jadard-jd9365da-h3: Use dev_err_probe() instead of DRM_DEV_ERROR() during probing
2025-11-17 6:47 [PATCH] drm/panel: jadard-jd9365da-h3: Use dev_err_probe() instead of DRM_DEV_ERROR() during probing Abhishek Rajput
@ 2025-11-18 8:44 ` neil.armstrong
2025-11-19 16:49 ` Neil Armstrong
1 sibling, 0 replies; 3+ messages in thread
From: neil.armstrong @ 2025-11-18 8:44 UTC (permalink / raw)
To: Abhishek Rajput, jagan, jessica.zhang, maarten.lankhorst,
mripard, tzimmermann, airlied, simona
Cc: dri-devel, linux-kernel
On 11/17/25 07:47, Abhishek Rajput wrote:
> The DRM_DEV_ERROR() has been deprecated, and use dev_err_probe()
> can be better. The other reason is that dev_err_probe() help avoid
> unexpected repeated err logs during defered probing.
>
> Signed-off-by: Abhishek Rajput <abhiraj21put@gmail.com>
>
> diff --git a/drivers/gpu/drm/panel/panel-jadard-jd9365da-h3.c b/drivers/gpu/drm/panel/panel-jadard-jd9365da-h3.c
> index 5c2530598ddb..aa05316dc57b 100644
> --- a/drivers/gpu/drm/panel/panel-jadard-jd9365da-h3.c
> +++ b/drivers/gpu/drm/panel/panel-jadard-jd9365da-h3.c
> @@ -1132,22 +1132,19 @@ static int jadard_dsi_probe(struct mipi_dsi_device *dsi)
> dsi->lanes = desc->lanes;
>
> jadard->reset = devm_gpiod_get(dev, "reset", GPIOD_OUT_HIGH);
> - if (IS_ERR(jadard->reset)) {
> - DRM_DEV_ERROR(&dsi->dev, "failed to get our reset GPIO\n");
> - return PTR_ERR(jadard->reset);
> - }
> + if (IS_ERR(jadard->reset))
> + return dev_err_probe(&dsi->dev, PTR_ERR(jadard->reset),
> + "failed to get our reset GPIO\n");
>
> jadard->vdd = devm_regulator_get(dev, "vdd");
> - if (IS_ERR(jadard->vdd)) {
> - DRM_DEV_ERROR(&dsi->dev, "failed to get vdd regulator\n");
> - return PTR_ERR(jadard->vdd);
> - }
> + if (IS_ERR(jadard->vdd))
> + return dev_err_probe(&dsi->dev, PTR_ERR(jadard->vdd),
> + "failed to get vdd regulator\n");
>
> jadard->vccio = devm_regulator_get(dev, "vccio");
> - if (IS_ERR(jadard->vccio)) {
> - DRM_DEV_ERROR(&dsi->dev, "failed to get vccio regulator\n");
> - return PTR_ERR(jadard->vccio);
> - }
> + if (IS_ERR(jadard->vccio))
> + return dev_err_probe(&dsi->dev, PTR_ERR(jadard->vccio),
> + "failed to get vccio regulator\n");
>
> ret = of_drm_get_panel_orientation(dev->of_node, &jadard->orientation);
> if (ret < 0)
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/panel: jadard-jd9365da-h3: Use dev_err_probe() instead of DRM_DEV_ERROR() during probing
2025-11-17 6:47 [PATCH] drm/panel: jadard-jd9365da-h3: Use dev_err_probe() instead of DRM_DEV_ERROR() during probing Abhishek Rajput
2025-11-18 8:44 ` neil.armstrong
@ 2025-11-19 16:49 ` Neil Armstrong
1 sibling, 0 replies; 3+ messages in thread
From: Neil Armstrong @ 2025-11-19 16:49 UTC (permalink / raw)
To: jagan, jessica.zhang, maarten.lankhorst, mripard, tzimmermann,
airlied, simona, Abhishek Rajput
Cc: dri-devel, linux-kernel
Hi,
On Mon, 17 Nov 2025 12:17:02 +0530, Abhishek Rajput wrote:
> The DRM_DEV_ERROR() has been deprecated, and use dev_err_probe()
> can be better. The other reason is that dev_err_probe() help avoid
> unexpected repeated err logs during defered probing.
>
>
Thanks, Applied to https://gitlab.freedesktop.org/drm/misc/kernel.git (drm-misc-next)
[1/1] drm/panel: jadard-jd9365da-h3: Use dev_err_probe() instead of DRM_DEV_ERROR() during probing
https://gitlab.freedesktop.org/drm/misc/kernel/-/commit/c8fd04c0e73370486fcb9203a1c90c244b7fa1ed
--
Neil
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-11-19 16:49 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-11-17 6:47 [PATCH] drm/panel: jadard-jd9365da-h3: Use dev_err_probe() instead of DRM_DEV_ERROR() during probing Abhishek Rajput
2025-11-18 8:44 ` neil.armstrong
2025-11-19 16:49 ` Neil Armstrong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®