[PATCH] EDAC/amd64: Add support for family 19h, models 40h-4fh

[PATCH] EDAC/amd64: Add support for family 19h, models 40h-4fh

[Devang Vyas]

Co-developed-by: Ramesh Garidapuri <ramesh.garidapuri@amd.com>
Signed-off-by: Ramesh Garidapuri <ramesh.garidapuri@amd.com>
Signed-off-by: Devang Vyas <devangnayanbhai.vyas@amd.com>
---
 drivers/edac/amd64_edac.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/edac/amd64_edac.c b/drivers/edac/amd64_edac.c
index a17f3c0cdfa6..2f6c3c4ed557 100644
--- a/drivers/edac/amd64_edac.c
+++ b/drivers/edac/amd64_edac.c
@@ -3878,6 +3878,10 @@ static int per_family_init(struct amd64_pvt *pvt)
 				pvt->max_mcs		= 8;
 			}
 			break;
+		case 0x40 ... 0x4f:
+			pvt->ctl_name                   = "F19h_M40h";
+			pvt->max_mcs                    = 4;
+			break;
 		case 0x50 ... 0x5f:
 			pvt->ctl_name			= "F19h_M50h";
 			break;
-- 
2.25.1

Re: [PATCH] EDAC/amd64: Add support for family 19h, models 40h-4fh

[Borislav Petkov]

On Sun, Nov 23, 2025 at 07:57:45PM +0530, Devang Vyas wrote:

-ENOCOMMITMESSAGE

Use the commit message to explain why those need to load the EDAC driver at
all.

> Co-developed-by: Ramesh Garidapuri <ramesh.garidapuri@amd.com>
> Signed-off-by: Ramesh Garidapuri <ramesh.garidapuri@amd.com>
> Signed-off-by: Devang Vyas <devangnayanbhai.vyas@amd.com>
> ---
>  drivers/edac/amd64_edac.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/edac/amd64_edac.c b/drivers/edac/amd64_edac.c
> index a17f3c0cdfa6..2f6c3c4ed557 100644
> --- a/drivers/edac/amd64_edac.c
> +++ b/drivers/edac/amd64_edac.c
> @@ -3878,6 +3878,10 @@ static int per_family_init(struct amd64_pvt *pvt)
>  				pvt->max_mcs		= 8;
>  			}
>  			break;
> +		case 0x40 ... 0x4f:
> +			pvt->ctl_name                   = "F19h_M40h";
> +			pvt->max_mcs                    = 4;
> +			break;
>  		case 0x50 ... 0x5f:
>  			pvt->ctl_name			= "F19h_M50h";
>  			break;
> -- 

EDAC patches need to be done against:

https://git.kernel.org/pub/scm/linux/kernel/git/ras/ras.git

the edac-for-next branch.

Thx.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette

RE: [PATCH] EDAC/amd64: Add support for family 19h, models 40h-4fh

[Vyas, Devang nayanbhai]

[AMD Official Use Only - AMD Internal Distribution Only]

Hello,

Do I need to raise the patch at below?

https://git.kernel.org/pub/scm/linux/kernel/git/ras/ras.git

edac-for-next branch

Please confirm?

Thanks & Regards,
Devang Vyas

-----Original Message-----
From: Borislav Petkov <bp@alien8.de>
Sent: Sunday, November 23, 2025 9:03 PM
To: Vyas, Devang nayanbhai <Devangnayanbhai.Vyas@amd.com>
Cc: Ghannam, Yazen <Yazen.Ghannam@amd.com>; tony.luck@intel.com; james.morse@arm.com; mchehab@kernel.org; rric@kernel.org; linux-edac@vger.kernel.org; linux-kernel@vger.kernel.org; Garidapuri, Ramesh <Ramesh.Garidapuri@amd.com>; Limonciello, Mario <Mario.Limonciello@amd.com>
Subject: Re: [PATCH] EDAC/amd64: Add support for family 19h, models 40h-4fh

On Sun, Nov 23, 2025 at 07:57:45PM +0530, Devang Vyas wrote:

-ENOCOMMITMESSAGE

Use the commit message to explain why those need to load the EDAC driver at all.

> Co-developed-by: Ramesh Garidapuri <ramesh.garidapuri@amd.com>
> Signed-off-by: Ramesh Garidapuri <ramesh.garidapuri@amd.com>
> Signed-off-by: Devang Vyas <devangnayanbhai.vyas@amd.com>
> ---
>  drivers/edac/amd64_edac.c | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/drivers/edac/amd64_edac.c b/drivers/edac/amd64_edac.c
> index a17f3c0cdfa6..2f6c3c4ed557 100644
> --- a/drivers/edac/amd64_edac.c
> +++ b/drivers/edac/amd64_edac.c
> @@ -3878,6 +3878,10 @@ static int per_family_init(struct amd64_pvt *pvt)
>                               pvt->max_mcs            = 8;
>                       }
>                       break;
> +             case 0x40 ... 0x4f:
> +                     pvt->ctl_name                   = "F19h_M40h";
> +                     pvt->max_mcs                    = 4;
> +                     break;
>               case 0x50 ... 0x5f:
>                       pvt->ctl_name                   = "F19h_M50h";
>                       break;
> --

EDAC patches need to be done against:

https://git.kernel.org/pub/scm/linux/kernel/git/ras/ras.git

the edac-for-next branch.

Thx.

--
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette

Re: [PATCH] EDAC/amd64: Add support for family 19h, models 40h-4fh

[Borislav Petkov]

Hi,

On Sun, Nov 23, 2025 at 04:41:25PM +0000, Vyas, Devang nayanbhai wrote:
> [AMD Official Use Only - AMD Internal Distribution Only]

This is clearly not internal distribution only.
 
> Do I need to raise the patch at below?
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/ras/ras.git
> 
> edac-for-next branch
> 
> Please confirm?

I just told you exactly that, wasn't that clear?

Also, please do not top-post - this is not internal email. The proper
etiquette on public mailing lists is to put your reply *below* the mail text
you're replying to.

There's a quick howto which I'm carrying in my signature exactly for newbies
to kernel development:

https://people.kernel.org/tglx/notes-about-netiquette

Please educate yourself.

Also, as previously mentioned:

> On Sun, Nov 23, 2025 at 07:57:45PM +0530, Devang Vyas wrote:
> 
> -ENOCOMMITMESSAGE
> 
> Use the commit message to explain why those need to load the EDAC driver at all.

Make sure your patch has a commit message.

Thx.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette

Re: [PATCH] EDAC/amd64: Add support for family 19h, models 40h-4fh

[Borislav Petkov]

On Mon, Nov 24, 2025 at 11:43:35PM +0530, Devang Vyas wrote:
> This patch updates the EDAC driver to include support

Avoid having "This patch" or "This commit" in the commit message. It is
tautologically useless.

Also, do

$ git grep 'This patch' Documentation/process

for more details.

> for AMD SoC family 19h models 40h-4fh to support
> Ryzen 6000 CPUs/APUs ("Rembrandt").
> 
> The added changes enhance the ability to detect and
> report memory errors on systems that utilize AMD SoCs
> from the specified family.

Lemme repeat my comment from last time:

"Use the commit message to explain why those need to load the EDAC driver at
all."

Your text still doesn't explain why amd64_edac should load on a client CPU:

https://en.wikipedia.org/wiki/Zen_3#Rembrandt

Thx.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette

[PATCH] EDAC/amd64: Add support for family 19h, models 40h-4fh

[Devang Vyas]

This patch updates the EDAC driver to include support
for AMD SoC family 19h models 40h-4fh to support
Ryzen 6000 CPUs/APUs ("Rembrandt").

The added changes enhance the ability to detect and
report memory errors on systems that utilize AMD SoCs
from the specified family.

Co-developed-by: Ramesh Garidapuri <ramesh.garidapuri@amd.com>
Signed-off-by: Ramesh Garidapuri <ramesh.garidapuri@amd.com>
Signed-off-by: Devang Vyas <devangnayanbhai.vyas@amd.com>
---
 drivers/edac/amd64_edac.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/edac/amd64_edac.c b/drivers/edac/amd64_edac.c
index 2391f3469961..6cf0b6d7b5ec 100644
--- a/drivers/edac/amd64_edac.c
+++ b/drivers/edac/amd64_edac.c
@@ -3863,6 +3863,9 @@ static int per_family_init(struct amd64_pvt *pvt)
 				pvt->max_mcs		= 8;
 			}
 			break;
+		case 0x40 ... 0x4f:
+			pvt->max_mcs			= 4;
+			break;
 		case 0x60 ... 0x6f:
 			pvt->flags.zn_regs_v2		= 1;
 			break;
-- 
2.25.1