* [PATCH 1/4] arm64: dts: apm/shadowcat: More clock clean-ups
2025-12-16 20:27 [PATCH 0/4] arm64: dts: apm: Fix remaining warnings Rob Herring (Arm)
@ 2025-12-16 20:27 ` Rob Herring (Arm)
2025-12-16 20:27 ` [PATCH 2/4] arm64: dts: apm: Use recommended i2c node names Rob Herring (Arm)
` (3 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Rob Herring (Arm) @ 2025-12-16 20:27 UTC (permalink / raw)
To: soc, Khuong Dinh, Krzysztof Kozlowski, Conor Dooley
Cc: devicetree, linux-kernel
A fixed-factor-clock only provides 1 clock, so "#clock-cells" must be 0.
The "snps,designware-i2c" node is not a clock provider, so drop
"#clock-cells.
Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
---
arch/arm64/boot/dts/apm/apm-shadowcat.dtsi | 17 ++++++++---------
1 file changed, 8 insertions(+), 9 deletions(-)
diff --git a/arch/arm64/boot/dts/apm/apm-shadowcat.dtsi b/arch/arm64/boot/dts/apm/apm-shadowcat.dtsi
index 5bbedb0a7107..032d37a32193 100644
--- a/arch/arm64/boot/dts/apm/apm-shadowcat.dtsi
+++ b/arch/arm64/boot/dts/apm/apm-shadowcat.dtsi
@@ -295,7 +295,7 @@ socpll: socpll@17000120 {
socplldiv2: socplldiv2 {
compatible = "fixed-factor-clock";
- #clock-cells = <1>;
+ #clock-cells = <0>;
clocks = <&socpll 0>;
clock-mult = <1>;
clock-div = <2>;
@@ -305,7 +305,7 @@ socplldiv2: socplldiv2 {
ahbclk: ahbclk@17000000 {
compatible = "apm,xgene-device-clock";
#clock-cells = <1>;
- clocks = <&socplldiv2 0>;
+ clocks = <&socplldiv2>;
reg = <0x0 0x17000000 0x0 0x2000>;
reg-names = "div-reg";
divider-offset = <0x164>;
@@ -329,7 +329,7 @@ sbapbclk: sbapbclk@1704c000 {
sdioclk: sdioclk@1f2ac000 {
compatible = "apm,xgene-device-clock";
#clock-cells = <1>;
- clocks = <&socplldiv2 0>;
+ clocks = <&socplldiv2>;
reg = <0x0 0x1f2ac000 0x0 0x1000
0x0 0x17000000 0x0 0x2000>;
reg-names = "csr-reg", "div-reg";
@@ -346,7 +346,7 @@ sdioclk: sdioclk@1f2ac000 {
pcie0clk: pcie0clk@1f2bc000 {
compatible = "apm,xgene-device-clock";
#clock-cells = <1>;
- clocks = <&socplldiv2 0>;
+ clocks = <&socplldiv2>;
reg = <0x0 0x1f2bc000 0x0 0x1000>;
reg-names = "csr-reg";
clock-output-names = "pcie0clk";
@@ -355,7 +355,7 @@ pcie0clk: pcie0clk@1f2bc000 {
pcie1clk: pcie1clk@1f2cc000 {
compatible = "apm,xgene-device-clock";
#clock-cells = <1>;
- clocks = <&socplldiv2 0>;
+ clocks = <&socplldiv2>;
reg = <0x0 0x1f2cc000 0x0 0x1000>;
reg-names = "csr-reg";
clock-output-names = "pcie1clk";
@@ -364,7 +364,7 @@ pcie1clk: pcie1clk@1f2cc000 {
xge0clk: xge0clk@1f61c000 {
compatible = "apm,xgene-device-clock";
#clock-cells = <1>;
- clocks = <&socplldiv2 0>;
+ clocks = <&socplldiv2>;
reg = <0x0 0x1f61c000 0x0 0x1000>;
reg-names = "csr-reg";
enable-mask = <0x3>;
@@ -375,7 +375,7 @@ xge0clk: xge0clk@1f61c000 {
xge1clk: xge1clk@1f62c000 {
compatible = "apm,xgene-device-clock";
#clock-cells = <1>;
- clocks = <&socplldiv2 0>;
+ clocks = <&socplldiv2>;
reg = <0x0 0x1f62c000 0x0 0x1000>;
reg-names = "csr-reg";
enable-mask = <0x3>;
@@ -386,7 +386,7 @@ xge1clk: xge1clk@1f62c000 {
rngpkaclk: rngpkaclk@17000000 {
compatible = "apm,xgene-device-clock";
#clock-cells = <1>;
- clocks = <&socplldiv2 0>;
+ clocks = <&socplldiv2>;
reg = <0x0 0x17000000 0x0 0x2000>;
reg-names = "csr-reg";
csr-offset = <0xc>;
@@ -799,7 +799,6 @@ i2c1: i2c@10511000 {
compatible = "snps,designware-i2c";
reg = <0x0 0x10511000 0x0 0x1000>;
interrupts = <0 0x45 0x4>;
- #clock-cells = <1>;
clocks = <&sbapbclk 0>;
};
--
2.51.0
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH 2/4] arm64: dts: apm: Use recommended i2c node names
2025-12-16 20:27 [PATCH 0/4] arm64: dts: apm: Fix remaining warnings Rob Herring (Arm)
2025-12-16 20:27 ` [PATCH 1/4] arm64: dts: apm/shadowcat: More clock clean-ups Rob Herring (Arm)
@ 2025-12-16 20:27 ` Rob Herring (Arm)
2025-12-16 20:27 ` [PATCH 3/4] arm64: dts: apm: Add "reg" to "syscon-reboot" and "syscon-poweroff" Rob Herring (Arm)
` (2 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Rob Herring (Arm) @ 2025-12-16 20:27 UTC (permalink / raw)
To: soc, Khuong Dinh, Krzysztof Kozlowski, Conor Dooley
Cc: devicetree, linux-kernel
Use the recommended node name of 'i2c' for the 'i2cslimpro' nodes.
Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
---
arch/arm64/boot/dts/apm/apm-shadowcat.dtsi | 2 +-
arch/arm64/boot/dts/apm/apm-storm.dtsi | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/apm/apm-shadowcat.dtsi b/arch/arm64/boot/dts/apm/apm-shadowcat.dtsi
index 032d37a32193..95281268fb7f 100644
--- a/arch/arm64/boot/dts/apm/apm-shadowcat.dtsi
+++ b/arch/arm64/boot/dts/apm/apm-shadowcat.dtsi
@@ -224,7 +224,7 @@ timer {
clock-frequency = <50000000>;
};
- i2cslimpro {
+ i2c {
compatible = "apm,xgene-slimpro-i2c";
mboxes = <&mailbox 0>;
};
diff --git a/arch/arm64/boot/dts/apm/apm-storm.dtsi b/arch/arm64/boot/dts/apm/apm-storm.dtsi
index 4ca0ead120c1..85ad18b63038 100644
--- a/arch/arm64/boot/dts/apm/apm-storm.dtsi
+++ b/arch/arm64/boot/dts/apm/apm-storm.dtsi
@@ -134,7 +134,7 @@ pmu {
interrupts = <1 12 0xff04>;
};
- i2cslimpro {
+ i2c {
compatible = "apm,xgene-slimpro-i2c";
mboxes = <&mailbox 0>;
};
--
2.51.0
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH 3/4] arm64: dts: apm: Add "reg" to "syscon-reboot" and "syscon-poweroff"
2025-12-16 20:27 [PATCH 0/4] arm64: dts: apm: Fix remaining warnings Rob Herring (Arm)
2025-12-16 20:27 ` [PATCH 1/4] arm64: dts: apm/shadowcat: More clock clean-ups Rob Herring (Arm)
2025-12-16 20:27 ` [PATCH 2/4] arm64: dts: apm: Use recommended i2c node names Rob Herring (Arm)
@ 2025-12-16 20:27 ` Rob Herring (Arm)
2025-12-16 20:27 ` [PATCH 4/4] arm64: dts: apm: Drop "dma" device_type Rob Herring (Arm)
2025-12-22 10:05 ` [PATCH 0/4] arm64: dts: apm: Fix remaining warnings Krzysztof Kozlowski
4 siblings, 0 replies; 6+ messages in thread
From: Rob Herring (Arm) @ 2025-12-16 20:27 UTC (permalink / raw)
To: soc, Khuong Dinh, Krzysztof Kozlowski, Conor Dooley
Cc: devicetree, linux-kernel
As the nodes already have a unit-address, add the corresponding "reg"
entry which is preferred over "offset".
Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
---
arch/arm64/boot/dts/apm/apm-merlin.dts | 1 +
arch/arm64/boot/dts/apm/apm-mustang.dts | 1 +
arch/arm64/boot/dts/apm/apm-shadowcat.dtsi | 1 +
arch/arm64/boot/dts/apm/apm-storm.dtsi | 1 +
4 files changed, 4 insertions(+)
diff --git a/arch/arm64/boot/dts/apm/apm-merlin.dts b/arch/arm64/boot/dts/apm/apm-merlin.dts
index b1160780a2a6..4ec05886dd41 100644
--- a/arch/arm64/boot/dts/apm/apm-merlin.dts
+++ b/arch/arm64/boot/dts/apm/apm-merlin.dts
@@ -38,6 +38,7 @@ poweroff_mbox: poweroff_mbox@10548000 {
poweroff: poweroff@10548010 {
compatible = "syscon-poweroff";
+ reg = <0x0 0x10548010 0x0 0x4>;
regmap = <&poweroff_mbox>;
offset = <0x10>;
mask = <0x1>;
diff --git a/arch/arm64/boot/dts/apm/apm-mustang.dts b/arch/arm64/boot/dts/apm/apm-mustang.dts
index 2ef658796746..8f7eeba56dc4 100644
--- a/arch/arm64/boot/dts/apm/apm-mustang.dts
+++ b/arch/arm64/boot/dts/apm/apm-mustang.dts
@@ -38,6 +38,7 @@ poweroff_mbox: poweroff_mbox@10548000 {
poweroff: poweroff@10548010 {
compatible = "syscon-poweroff";
+ reg = <0x0 0x10548010 0x0 0x4>;
regmap = <&poweroff_mbox>;
offset = <0x10>;
mask = <0x1>;
diff --git a/arch/arm64/boot/dts/apm/apm-shadowcat.dtsi b/arch/arm64/boot/dts/apm/apm-shadowcat.dtsi
index 95281268fb7f..e930f2f26f4b 100644
--- a/arch/arm64/boot/dts/apm/apm-shadowcat.dtsi
+++ b/arch/arm64/boot/dts/apm/apm-shadowcat.dtsi
@@ -417,6 +417,7 @@ scu: system-clk-controller@17000000 {
reboot: reboot@17000014 {
compatible = "syscon-reboot";
+ reg = <0x0 0x17000014 0x0 0x4>;
regmap = <&scu>;
offset = <0x14>;
mask = <0x1>;
diff --git a/arch/arm64/boot/dts/apm/apm-storm.dtsi b/arch/arm64/boot/dts/apm/apm-storm.dtsi
index 85ad18b63038..3bb59704fcb2 100644
--- a/arch/arm64/boot/dts/apm/apm-storm.dtsi
+++ b/arch/arm64/boot/dts/apm/apm-storm.dtsi
@@ -462,6 +462,7 @@ scu: system-clk-controller@17000000 {
reboot: reboot@17000014 {
compatible = "syscon-reboot";
+ reg = <0x0 0x17000014 0x0 0x4>;
regmap = <&scu>;
offset = <0x14>;
mask = <0x1>;
--
2.51.0
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH 4/4] arm64: dts: apm: Drop "dma" device_type
2025-12-16 20:27 [PATCH 0/4] arm64: dts: apm: Fix remaining warnings Rob Herring (Arm)
` (2 preceding siblings ...)
2025-12-16 20:27 ` [PATCH 3/4] arm64: dts: apm: Add "reg" to "syscon-reboot" and "syscon-poweroff" Rob Herring (Arm)
@ 2025-12-16 20:27 ` Rob Herring (Arm)
2025-12-22 10:05 ` [PATCH 0/4] arm64: dts: apm: Fix remaining warnings Krzysztof Kozlowski
4 siblings, 0 replies; 6+ messages in thread
From: Rob Herring (Arm) @ 2025-12-16 20:27 UTC (permalink / raw)
To: soc, Khuong Dinh, Krzysztof Kozlowski, Conor Dooley
Cc: devicetree, linux-kernel
The only supported cases of otherwise deprecated for FDT "device_type"
property are memory, cpu, and pci. "dma" is not valid, so drop it.
Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
---
arch/arm64/boot/dts/apm/apm-storm.dtsi | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/arm64/boot/dts/apm/apm-storm.dtsi b/arch/arm64/boot/dts/apm/apm-storm.dtsi
index 3bb59704fcb2..4c4938faffb1 100644
--- a/arch/arm64/boot/dts/apm/apm-storm.dtsi
+++ b/arch/arm64/boot/dts/apm/apm-storm.dtsi
@@ -1083,7 +1083,6 @@ rng: rng@10520000 {
dma: dma@1f270000 {
compatible = "apm,xgene-storm-dma";
- device_type = "dma";
reg = <0x0 0x1f270000 0x0 0x10000>,
<0x0 0x1f200000 0x0 0x10000>,
<0x0 0x1b000000 0x0 0x400000>,
--
2.51.0
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH 0/4] arm64: dts: apm: Fix remaining warnings
2025-12-16 20:27 [PATCH 0/4] arm64: dts: apm: Fix remaining warnings Rob Herring (Arm)
` (3 preceding siblings ...)
2025-12-16 20:27 ` [PATCH 4/4] arm64: dts: apm: Drop "dma" device_type Rob Herring (Arm)
@ 2025-12-22 10:05 ` Krzysztof Kozlowski
4 siblings, 0 replies; 6+ messages in thread
From: Krzysztof Kozlowski @ 2025-12-22 10:05 UTC (permalink / raw)
To: soc, Khuong Dinh, Krzysztof Kozlowski, Conor Dooley, Rob Herring (Arm)
Cc: devicetree, linux-kernel
On Tue, 16 Dec 2025 14:27:47 -0600, Rob Herring (Arm) wrote:
> This series (along with separately sent binding changes) fixes the
> remaining DT warnings for APM platforms with the exception the
> non-standard use of the "phy-handle" property having 2 phys. I'm not
> sure what is the right fix there. It looks like the same phy is defined
> twice on different MDIO buses though the "apm,xgene-mdio-rgmii" MDIO
> registers overlap with the "apm,xgene-enet" registers which also defines
> a MDIO bus...
>
> [...]
Applied, thanks!
[1/4] arm64: dts: apm/shadowcat: More clock clean-ups
https://git.kernel.org/krzk/linux-dt/c/21bd5fb461eb485768cef99e0ff531a6b84b67d8
[2/4] arm64: dts: apm: Use recommended i2c node names
https://git.kernel.org/krzk/linux-dt/c/cae405d73986579a88bfb956f1ae9b514c23a7bc
[3/4] arm64: dts: apm: Add "reg" to "syscon-reboot" and "syscon-poweroff"
https://git.kernel.org/krzk/linux-dt/c/a1176f7c5b990244e9a0ee2bdd93c9a36e5fe666
[4/4] arm64: dts: apm: Drop "dma" device_type
https://git.kernel.org/krzk/linux-dt/c/5cd532f7f017460395836d8f129ad3ee5ae63110
Best regards,
--
Krzysztof Kozlowski <krzk@kernel.org>
^ permalink raw reply [flat|nested] 6+ messages in thread