* [PATCH] staging: media: atomisp: fix block comment coding style
@ 2025-12-27 10:55 Karthikey D Kadati
2026-04-18 22:12 ` Sakari Ailus
0 siblings, 1 reply; 3+ messages in thread
From: Karthikey D Kadati @ 2025-12-27 10:55 UTC (permalink / raw)
To: Hans de Goede
Cc: Mauro Carvalho Chehab, linux-media, linux-staging, linux-kernel,
Karthikey D Kadati
Fix the checkpatch.pl warning:
WARNING: Block comments use a trailing */ on a separate line
This change aligns the block comment at line 1384 with the standard
Linux kernel coding style for better readability.
Signed-off-by: Karthikey D Kadati <karthikey3608@gmail.com>
---
drivers/staging/media/atomisp/pci/atomisp_cmd.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/media/atomisp/pci/atomisp_cmd.c b/drivers/staging/media/atomisp/pci/atomisp_cmd.c
index 3a4eb4f6d..327836372 100644
--- a/drivers/staging/media/atomisp/pci/atomisp_cmd.c
+++ b/drivers/staging/media/atomisp/pci/atomisp_cmd.c
@@ -1380,8 +1380,10 @@ static void atomisp_update_grid_info(struct atomisp_sub_device *asd,
if (atomisp_css_get_grid_info(asd, pipe_id))
return;
- /* We must free all buffers because they no longer match
- the grid size. */
+ /*
+ * We must free all buffers because they no longer match
+ * the grid size.
+ */
atomisp_css_free_stat_buffers(asd);
err = atomisp_alloc_css_stat_bufs(asd, ATOMISP_INPUT_STREAM_GENERAL);
--
2.43.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] staging: media: atomisp: fix block comment coding style
2025-12-27 10:55 [PATCH] staging: media: atomisp: fix block comment coding style Karthikey D Kadati
@ 2026-04-18 22:12 ` Sakari Ailus
0 siblings, 0 replies; 3+ messages in thread
From: Sakari Ailus @ 2026-04-18 22:12 UTC (permalink / raw)
To: Karthikey D Kadati
Cc: Hans de Goede, Mauro Carvalho Chehab, linux-media, linux-staging,
linux-kernel
Hi Kerthikey,
On Sat, Dec 27, 2025 at 04:25:20PM +0530, Karthikey D Kadati wrote:
> Fix the checkpatch.pl warning:
> WARNING: Block comments use a trailing */ on a separate line
>
> This change aligns the block comment at line 1384 with the standard
> Linux kernel coding style for better readability.
>
> Signed-off-by: Karthikey D Kadati <karthikey3608@gmail.com>
Thanks for the patch.
It no longer applies to my atomisp branch. In general, it'd be good to fix
a few more issues of the same kind.
> ---
> drivers/staging/media/atomisp/pci/atomisp_cmd.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/media/atomisp/pci/atomisp_cmd.c b/drivers/staging/media/atomisp/pci/atomisp_cmd.c
> index 3a4eb4f6d..327836372 100644
> --- a/drivers/staging/media/atomisp/pci/atomisp_cmd.c
> +++ b/drivers/staging/media/atomisp/pci/atomisp_cmd.c
> @@ -1380,8 +1380,10 @@ static void atomisp_update_grid_info(struct atomisp_sub_device *asd,
> if (atomisp_css_get_grid_info(asd, pipe_id))
> return;
>
> - /* We must free all buffers because they no longer match
> - the grid size. */
> + /*
> + * We must free all buffers because they no longer match
> + * the grid size.
> + */
> atomisp_css_free_stat_buffers(asd);
>
> err = atomisp_alloc_css_stat_bufs(asd, ATOMISP_INPUT_STREAM_GENERAL);
--
Kind regards,
Sakari Ailus
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] staging: media: atomisp: fix block comment coding style
@ 2025-12-27 10:56 Karthikey D Kadati
0 siblings, 0 replies; 3+ messages in thread
From: Karthikey D Kadati @ 2025-12-27 10:56 UTC (permalink / raw)
To: Hans de Goede
Cc: Mauro Carvalho Chehab, linux-media, linux-staging, linux-kernel,
Karthikey D Kadati
Fix the checkpatch.pl warning:
WARNING: Block comments use a trailing */ on a separate line
This change aligns the block comment at line 1384 with the standard
Linux kernel coding style for better readability.
Signed-off-by: Karthikey D Kadati <karthikey3608@gmail.com>
---
drivers/staging/media/atomisp/pci/atomisp_cmd.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/media/atomisp/pci/atomisp_cmd.c b/drivers/staging/media/atomisp/pci/atomisp_cmd.c
index 3a4eb4f6d..327836372 100644
--- a/drivers/staging/media/atomisp/pci/atomisp_cmd.c
+++ b/drivers/staging/media/atomisp/pci/atomisp_cmd.c
@@ -1380,8 +1380,10 @@ static void atomisp_update_grid_info(struct atomisp_sub_device *asd,
if (atomisp_css_get_grid_info(asd, pipe_id))
return;
- /* We must free all buffers because they no longer match
- the grid size. */
+ /*
+ * We must free all buffers because they no longer match
+ * the grid size.
+ */
atomisp_css_free_stat_buffers(asd);
err = atomisp_alloc_css_stat_bufs(asd, ATOMISP_INPUT_STREAM_GENERAL);
--
2.43.0
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-04-18 22:13 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-12-27 10:55 [PATCH] staging: media: atomisp: fix block comment coding style Karthikey D Kadati
2026-04-18 22:12 ` Sakari Ailus
2025-12-27 10:56 Karthikey D Kadati
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®