From: Hans de Goede <johannes.goede@oss.qualcomm.com>
To: Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Sakari Ailus <sakari.ailus@linux.intel.com>
Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Hans de Goede <johannes.goede@oss.qualcomm.com>
Subject: [PATCH v5 00/14] media: mt9m114: Changes to make it work with atomisp devices
Date: Tue, 30 Dec 2025 18:02:57 +0100 [thread overview]
Message-ID: <20251230-mt9m114-atomisp-v5-0-763539e76094@oss.qualcomm.com> (raw)
Hi All,
Here is v5 of my series to make the "mainline" mt9m114 driver work
on devices with an atomisp CSI2 receiver / ISP. This has been tested on
an Asus T100TA.
All patches have a Reviewed-by from Laurent now, so I believe that this
is ready for merging now.
Changes in v5:
- Move PLL-setup comment to mt9m114.c and squash it into
"[PATCH v5 02/14] media: mt9m114: Use aptina-PLL helper to get PLL values"
- Use sensor->pll.ext_clock instead of calling clk_get_rate()
- Drop "and identify it " from comment in probe()
- Link to v4: https://lore.kernel.org/r/20251224-mt9m114-atomisp-v4-0-60b25da7a1bc@oss.qualcomm.com
Changes in v4:
- Drop "media: mt9m114: Add support for clock-frequency property" this is
not longer necessary with the new vl2_sensor_clk_get() helper
- Add "media: aptina-pll: Add comment documenting the PLL chain"
- Rework "media: mt9m114: Drop start-, stop-streaming sequence from
initialize" moving mt9m114_initialize() to mt9m114_start_streaming() and
dropping the config_change_pending flag
- Address comments from Laurent about commit message and comment wording
- Some small code tweaks based on suggestions from Laurent
Changes in v3:
- Document that using 768Mhz for out_clock_max does not work
- Improve "media: mt9m114: Put sensor in reset on power down" commit message
- Drop setting of the MT9M114_CAM_OUTPUT_FORMAT_BT656_CROP_SCALE_DISABLE bit
- Split "media: mt9m114: Fix scaler bypass mode" into multiple patches,
addressing various review comments as part of this
Changes in v2:
- Rebase on top of sailus/media_tree.git/fixes which now has 4 of
the patches from Mathis': "MT9M114 driver bugfix and improvements"
series, this avoids most of the conlicts between the 2 series
- Add Laurent's Reviewed-by to some of the patches
- Add select VIDEO_APTINA_PLL to Kconfig
- Use correct aptina_pll_limits
- After setting reset high wait 20 clk cycles before disabling
the clk and regulators
- When bypassing the scalar make ifp_get_selection() / ifp_set_selection()
fill sel->r with a rectangle of (0,0)/wxh and return 0 instead of
returning -EINVAL
Regards,
Hans
---
Hans de Goede (14):
media: aptina-pll: Debug log p1 min and max values
media: mt9m114: Use aptina-PLL helper to get PLL values
media: mt9m114: Lower minimum vblank value
media: mt9m114: Fix default hblank and vblank values
media: mt9m114: Tweak default hblank and vblank for more accurate fps
media: mt9m114: Avoid a reset low spike during probe()
media: mt9m114: Put sensor in reset on power down
media: mt9m114: Add and use mt9m114_ifp_get_border() helper function
media: mt9m114: Adjust IFP selections and source format when source format changes to/from RAW10
media: mt9m114: Update source pad selection and format when sink pad format changes
media: mt9m114: Don't allow changing the IFP crop/compose selections when bypassing the scaler
media: mt9m114: Drop start-, stop-streaming sequence from initialize
media: mt9m114: Return -EPROBE_DEFER if no endpoint is found
media: mt9m114: Add ACPI enumeration support
drivers/media/i2c/Kconfig | 1 +
drivers/media/i2c/aptina-pll.c | 2 +
drivers/media/i2c/mt9m114.c | 271 +++++++++++++++++++++++++++++------------
3 files changed, 193 insertions(+), 81 deletions(-)
---
base-commit: b70886ff5833cf499e77af77d2324ce8f68b60ce
change-id: 20251224-mt9m114-atomisp-31a4d366328a
Best regards,
--
Hans de Goede <johannes.goede@oss.qualcomm.com>
next reply other threads:[~2025-12-30 17:03 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-30 17:02 Hans de Goede [this message]
2025-12-30 17:02 ` [PATCH v5 01/14] media: aptina-pll: Debug log p1 min and max values Hans de Goede
2025-12-30 17:02 ` [PATCH v5 02/14] media: mt9m114: Use aptina-PLL helper to get PLL values Hans de Goede
2025-12-31 0:29 ` Laurent Pinchart
2025-12-30 17:03 ` [PATCH v5 03/14] media: mt9m114: Lower minimum vblank value Hans de Goede
2025-12-30 17:03 ` [PATCH v5 04/14] media: mt9m114: Fix default hblank and vblank values Hans de Goede
2025-12-30 17:03 ` [PATCH v5 05/14] media: mt9m114: Tweak default hblank and vblank for more accurate fps Hans de Goede
2025-12-30 17:03 ` [PATCH v5 06/14] media: mt9m114: Avoid a reset low spike during probe() Hans de Goede
2025-12-30 17:03 ` [PATCH v5 07/14] media: mt9m114: Put sensor in reset on power down Hans de Goede
2025-12-30 17:03 ` [PATCH v5 08/14] media: mt9m114: Add and use mt9m114_ifp_get_border() helper function Hans de Goede
2025-12-30 17:03 ` [PATCH v5 09/14] media: mt9m114: Adjust IFP selections and source format when source format changes to/from RAW10 Hans de Goede
2025-12-30 17:03 ` [PATCH v5 10/14] media: mt9m114: Update source pad selection and format when sink pad format changes Hans de Goede
2025-12-30 17:03 ` [PATCH v5 11/14] media: mt9m114: Don't allow changing the IFP crop/compose selections when bypassing the scaler Hans de Goede
2025-12-30 17:03 ` [PATCH v5 12/14] media: mt9m114: Drop start-, stop-streaming sequence from initialize Hans de Goede
2025-12-30 17:03 ` [PATCH v5 13/14] media: mt9m114: Return -EPROBE_DEFER if no endpoint is found Hans de Goede
2025-12-30 17:03 ` [PATCH v5 14/14] media: mt9m114: Add ACPI enumeration support Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251230-mt9m114-atomisp-v5-0-763539e76094@oss.qualcomm.com \
--to=johannes.goede@oss.qualcomm.com \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®