mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Hans de Goede <johannes.goede@oss.qualcomm.com>
To: Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Sakari Ailus <sakari.ailus@linux.intel.com>
Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	Hans de Goede <johannes.goede@oss.qualcomm.com>
Subject: [PATCH v5 03/14] media: mt9m114: Lower minimum vblank value
Date: Tue, 30 Dec 2025 18:03:00 +0100	[thread overview]
Message-ID: <20251230-mt9m114-atomisp-v5-3-763539e76094@oss.qualcomm.com> (raw)
In-Reply-To: <20251230-mt9m114-atomisp-v5-0-763539e76094@oss.qualcomm.com>

As the comment above the defines says, the minimum values are undocumented
so the lowest values seen in register lists are used.

The version of the mt9m114 driver shipped together with the atomisp code
uses 21 for vblank in its register lists, lower MT9M114_MIN_VBLANK
accordingly.

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Hans de Goede <johannes.goede@oss.qualcomm.com>
---
 drivers/media/i2c/mt9m114.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/media/i2c/mt9m114.c b/drivers/media/i2c/mt9m114.c
index bbac5fd9b2ad85a1ab56a7e36de16659bc38a369..d9cc260a13bd9f7dc76b69696ce18b953f43e3d0 100644
--- a/drivers/media/i2c/mt9m114.c
+++ b/drivers/media/i2c/mt9m114.c
@@ -329,13 +329,13 @@
 
 /*
  * The minimum amount of horizontal and vertical blanking is undocumented. The
- * minimum values that have been seen in register lists are 303 and 38, use
+ * minimum values that have been seen in register lists are 303 and 21, use
  * them.
  *
  * Set the default to achieve 1280x960 at 30fps with a 48 MHz pixclock.
  */
 #define MT9M114_MIN_HBLANK				303
-#define MT9M114_MIN_VBLANK				38
+#define MT9M114_MIN_VBLANK				21
 #define MT9M114_DEF_HBLANK				323
 #define MT9M114_DEF_VBLANK				39
 

-- 
2.52.0


  parent reply	other threads:[~2025-12-30 17:03 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-30 17:02 [PATCH v5 00/14] media: mt9m114: Changes to make it work with atomisp devices Hans de Goede
2025-12-30 17:02 ` [PATCH v5 01/14] media: aptina-pll: Debug log p1 min and max values Hans de Goede
2025-12-30 17:02 ` [PATCH v5 02/14] media: mt9m114: Use aptina-PLL helper to get PLL values Hans de Goede
2025-12-31  0:29   ` Laurent Pinchart
2025-12-30 17:03 ` Hans de Goede [this message]
2025-12-30 17:03 ` [PATCH v5 04/14] media: mt9m114: Fix default hblank and vblank values Hans de Goede
2025-12-30 17:03 ` [PATCH v5 05/14] media: mt9m114: Tweak default hblank and vblank for more accurate fps Hans de Goede
2025-12-30 17:03 ` [PATCH v5 06/14] media: mt9m114: Avoid a reset low spike during probe() Hans de Goede
2025-12-30 17:03 ` [PATCH v5 07/14] media: mt9m114: Put sensor in reset on power down Hans de Goede
2025-12-30 17:03 ` [PATCH v5 08/14] media: mt9m114: Add and use mt9m114_ifp_get_border() helper function Hans de Goede
2025-12-30 17:03 ` [PATCH v5 09/14] media: mt9m114: Adjust IFP selections and source format when source format changes to/from RAW10 Hans de Goede
2025-12-30 17:03 ` [PATCH v5 10/14] media: mt9m114: Update source pad selection and format when sink pad format changes Hans de Goede
2025-12-30 17:03 ` [PATCH v5 11/14] media: mt9m114: Don't allow changing the IFP crop/compose selections when bypassing the scaler Hans de Goede
2025-12-30 17:03 ` [PATCH v5 12/14] media: mt9m114: Drop start-, stop-streaming sequence from initialize Hans de Goede
2025-12-30 17:03 ` [PATCH v5 13/14] media: mt9m114: Return -EPROBE_DEFER if no endpoint is found Hans de Goede
2025-12-30 17:03 ` [PATCH v5 14/14] media: mt9m114: Add ACPI enumeration support Hans de Goede

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251230-mt9m114-atomisp-v5-3-763539e76094@oss.qualcomm.com \
    --to=johannes.goede@oss.qualcomm.com \
    --cc=Laurent.pinchart@ideasonboard.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=sakari.ailus@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®