[PATCH 0/2] qnap-mcu: Add TS133 support

[PATCH 0/2] qnap-mcu: Add TS133 support

[Heiko Stuebner]

The completionist in me made me grab a TS133 1-bay variant for cheap.
Not yet sure what to do with it, but at least once one understands the
basic layout, adding support for more variants gets easy :-) .

So this small series adds support for 1-bay consumer variant of
the QNAP NAS series based on Rockchip RK3566/RK3568 SoCs.


The last remaining type of this series is the TS433eu 1HE rackmount
variant. There are people wanting to add support for this, so they
also get to do the MCU support for it - which is a tiny bit more
involved as the TS433eU has 3 independently controllable fans.


Heiko Stuebner (2):
  dt-bindings: mfd: qnap,ts433-mcu: Add qnap,ts133-mcu compatible
  mfd: qnap-mcu: Add driver data for TS133 variant

 .../devicetree/bindings/mfd/qnap,ts433-mcu.yaml          | 1 +
 drivers/mfd/qnap-mcu.c                                   | 9 +++++++++
 2 files changed, 10 insertions(+)

-- 
2.47.2

[PATCH 1/2] dt-bindings: mfd: qnap,ts433-mcu: Add qnap,ts133-mcu compatible

[Heiko Stuebner]

The same MCU is used on a number of devices, each with a slightly
different set of features, like the number of LEDs.

Add a compatible for the MCU used in the TS133 variant.
This is the 1-disk consumer variant of the RK356x-based family.

Signed-off-by: Heiko Stuebner <heiko@sntech.de>
---
 Documentation/devicetree/bindings/mfd/qnap,ts433-mcu.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/mfd/qnap,ts433-mcu.yaml b/Documentation/devicetree/bindings/mfd/qnap,ts433-mcu.yaml
index 5454d9403cad..12e738b1270a 100644
--- a/Documentation/devicetree/bindings/mfd/qnap,ts433-mcu.yaml
+++ b/Documentation/devicetree/bindings/mfd/qnap,ts433-mcu.yaml
@@ -16,6 +16,7 @@ description:
 properties:
   compatible:
     enum:
+      - qnap,ts133-mcu
       - qnap,ts233-mcu
       - qnap,ts433-mcu
 
-- 
2.47.2

Re: [PATCH 1/2] dt-bindings: mfd: qnap,ts433-mcu: Add qnap,ts133-mcu compatible

[Rob Herring (Arm)]

On Sun, 04 Jan 2026 18:33:09 +0100, Heiko Stuebner wrote:
> The same MCU is used on a number of devices, each with a slightly
> different set of features, like the number of LEDs.
> 
> Add a compatible for the MCU used in the TS133 variant.
> This is the 1-disk consumer variant of the RK356x-based family.
> 
> Signed-off-by: Heiko Stuebner <heiko@sntech.de>
> ---
>  Documentation/devicetree/bindings/mfd/qnap,ts433-mcu.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 

Acked-by: Rob Herring (Arm) <robh@kernel.org>

[PATCH 2/2] mfd: qnap-mcu: Add driver data for TS133 variant

[Heiko Stuebner]

Add the TS133 compatible and affiliated driver data to qnap-mcu.
The TS133 is mostly similar to the TS233/TS433, except only having
one drive and no USB-LED.

The fan pwm-limits from the vendor-configuration also are the same
as for the TS233/TS433 variants.

Signed-off-by: Heiko Stuebner <heiko@sntech.de>
---
 drivers/mfd/qnap-mcu.c | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/drivers/mfd/qnap-mcu.c b/drivers/mfd/qnap-mcu.c
index 08e55ff24012..556bc5bb43d9 100644
--- a/drivers/mfd/qnap-mcu.c
+++ b/drivers/mfd/qnap-mcu.c
@@ -444,6 +444,14 @@ static int qnap_mcu_power_off(struct sys_off_data *data)
 	return NOTIFY_DONE;
 }
 
+static const struct qnap_mcu_variant qnap_ts133_mcu = {
+	.baud_rate = 115200,
+	.num_drives = 1,
+	.fan_pwm_min = 51,  /* Specified in original model.conf */
+	.fan_pwm_max = 255,
+	.usb_led = false,
+};
+
 static const struct qnap_mcu_variant qnap_ts233_mcu = {
 	.baud_rate = 115200,
 	.num_drives = 2,
@@ -529,6 +537,7 @@ static int qnap_mcu_probe(struct serdev_device *serdev)
 }
 
 static const struct of_device_id qnap_mcu_dt_ids[] = {
+	{ .compatible = "qnap,ts133-mcu", .data = &qnap_ts133_mcu },
 	{ .compatible = "qnap,ts233-mcu", .data = &qnap_ts233_mcu },
 	{ .compatible = "qnap,ts433-mcu", .data = &qnap_ts433_mcu },
 	{ /* sentinel */ }
-- 
2.47.2

Re: [PATCH 0/2] qnap-mcu: Add TS133 support

[Lee Jones]

On Sun, 04 Jan 2026 18:33:08 +0100, Heiko Stuebner wrote:
> The completionist in me made me grab a TS133 1-bay variant for cheap.
> Not yet sure what to do with it, but at least once one understands the
> basic layout, adding support for more variants gets easy :-) .
> 
> So this small series adds support for 1-bay consumer variant of
> the QNAP NAS series based on Rockchip RK3566/RK3568 SoCs.
> 
> [...]

Applied, thanks!

[1/2] dt-bindings: mfd: qnap,ts433-mcu: Add qnap,ts133-mcu compatible
      commit: 7093a9f58cd759fcb9bf77a6a4c93a06c00f9c3c
[2/2] mfd: qnap-mcu: Add driver data for TS133 variant
      commit: 5380ce6d573059ae840e846a643a06521ef2cee3

--
Lee Jones [李琼斯]