[PATCH] gpio: line-mux: remove bits already handled by GPIO core

[PATCH] gpio: line-mux: remove bits already handled by GPIO core

[Bartosz Golaszewski]

GPIO core already handles checking the offset against the number of
GPIOs as well as missing any of the GPIO chip callbacks. Remove the
unnecessary bits.

Also, the offset check was off-by-one as reported by Dan.

Fixes: 2b03d9a40cd1 ("gpio: add gpio-line-mux driver")
Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
Closes: https://lore.kernel.org/all/aV4b6GAGz1zyf8Xy@stanley.mountain/
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
---
 drivers/gpio/gpio-line-mux.c | 10 ----------
 1 file changed, 10 deletions(-)

diff --git a/drivers/gpio/gpio-line-mux.c b/drivers/gpio/gpio-line-mux.c
index a4f384306218..62548fbd3ca0 100644
--- a/drivers/gpio/gpio-line-mux.c
+++ b/drivers/gpio/gpio-line-mux.c
@@ -29,9 +29,6 @@ static int gpio_lmux_gpio_get(struct gpio_chip *gc, unsigned int offset)
 	struct gpio_lmux *glm = gpiochip_get_data(gc);
 	int ret;
 
-	if (offset > gc->ngpio)
-		return -EINVAL;
-
 	ret = mux_control_select_delay(glm->mux, glm->gpio_mux_states[offset],
 				       MUX_SELECT_DELAY_US);
 	if (ret < 0)
@@ -42,12 +39,6 @@ static int gpio_lmux_gpio_get(struct gpio_chip *gc, unsigned int offset)
 	return ret;
 }
 
-static int gpio_lmux_gpio_set(struct gpio_chip *gc, unsigned int offset,
-			      int value)
-{
-	return -EOPNOTSUPP;
-}
-
 static int gpio_lmux_gpio_get_direction(struct gpio_chip *gc,
 					unsigned int offset)
 {
@@ -80,7 +71,6 @@ static int gpio_lmux_probe(struct platform_device *pdev)
 	glm->gc.parent = dev;
 
 	glm->gc.get = gpio_lmux_gpio_get;
-	glm->gc.set = gpio_lmux_gpio_set;
 	glm->gc.get_direction = gpio_lmux_gpio_get_direction;
 
 	glm->mux = devm_mux_control_get(dev, NULL);
-- 
2.47.3

Re: [PATCH] gpio: line-mux: remove bits already handled by GPIO core

[Jonas Jelonek]

Hi Bartosz,

On 07.01.26 09:58, Bartosz Golaszewski wrote:
> GPIO core already handles checking the offset against the number of
> GPIOs as well as missing any of the GPIO chip callbacks. Remove the
> unnecessary bits.
>
> Also, the offset check was off-by-one as reported by Dan.
>
> Fixes: 2b03d9a40cd1 ("gpio: add gpio-line-mux driver")
> Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
> Closes: https://lore.kernel.org/all/aV4b6GAGz1zyf8Xy@stanley.mountain/
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
> ---
>  drivers/gpio/gpio-line-mux.c | 10 ----------
>  1 file changed, 10 deletions(-)
>
> diff --git a/drivers/gpio/gpio-line-mux.c b/drivers/gpio/gpio-line-mux.c
> index a4f384306218..62548fbd3ca0 100644
> --- a/drivers/gpio/gpio-line-mux.c
> +++ b/drivers/gpio/gpio-line-mux.c
> @@ -29,9 +29,6 @@ static int gpio_lmux_gpio_get(struct gpio_chip *gc, unsigned int offset)
>  	struct gpio_lmux *glm = gpiochip_get_data(gc);
>  	int ret;
>  
> -	if (offset > gc->ngpio)
> -		return -EINVAL;
> -
>  	ret = mux_control_select_delay(glm->mux, glm->gpio_mux_states[offset],
>  				       MUX_SELECT_DELAY_US);
>  	if (ret < 0)
> @@ -42,12 +39,6 @@ static int gpio_lmux_gpio_get(struct gpio_chip *gc, unsigned int offset)
>  	return ret;
>  }
>  
> -static int gpio_lmux_gpio_set(struct gpio_chip *gc, unsigned int offset,
> -			      int value)
> -{
> -	return -EOPNOTSUPP;
> -}
> -
>  static int gpio_lmux_gpio_get_direction(struct gpio_chip *gc,
>  					unsigned int offset)
>  {
> @@ -80,7 +71,6 @@ static int gpio_lmux_probe(struct platform_device *pdev)
>  	glm->gc.parent = dev;
>  
>  	glm->gc.get = gpio_lmux_gpio_get;
> -	glm->gc.set = gpio_lmux_gpio_set;
>  	glm->gc.get_direction = gpio_lmux_gpio_get_direction;
>  
>  	glm->mux = devm_mux_control_get(dev, NULL);

Thanks a lot for taking care of that!

Tested-by: Jonas Jelonek <jelonek.jonas@gmail.com>
Reviewed-by: Jonas Jelonek <jelonek.jonas@gmail.com>

Best,
Jonas

Re: [PATCH] gpio: line-mux: remove bits already handled by GPIO core

[Bartosz Golaszewski]

On Wed, 07 Jan 2026 09:58:33 +0100, Bartosz Golaszewski wrote:
> GPIO core already handles checking the offset against the number of
> GPIOs as well as missing any of the GPIO chip callbacks. Remove the
> unnecessary bits.
> 
> Also, the offset check was off-by-one as reported by Dan.
> 
> 
> [...]

Applied, thanks!

[1/1] gpio: line-mux: remove bits already handled by GPIO core
      commit: e034e058897a12bc856f8b22d1796964c742f732

Best regards,
-- 
Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>