mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Chi Zhiling <chizhiling@163.com>
To: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Namjae Jeon <linkinjeon@kernel.org>,
	Sungjong Seo <sj1557.seo@samsung.com>,
	Yuezhang Mo <yuezhang.mo@sony.com>,
	Chi Zhiling <chizhiling@kylinos.cn>,
	Yuezhang Mo <Yuezhang.Mo@sony.com>
Subject: [PATCH v2 09/13] exfat: remove handling of non-file types in exfat_map_cluster
Date: Thu,  8 Jan 2026 15:49:25 +0800	[thread overview]
Message-ID: <20260108074929.356683-10-chizhiling@163.com> (raw)
In-Reply-To: <20260108074929.356683-1-chizhiling@163.com>

From: Chi Zhiling <chizhiling@kylinos.cn>

Yuezhang said: "exfat_map_cluster() is only used for files. The code
in this 'else' block is never executed and can be cleaned up."

Suggested-by: Yuezhang Mo <Yuezhang.Mo@sony.com>
Signed-off-by: Chi Zhiling <chizhiling@kylinos.cn>
---
 fs/exfat/inode.c | 18 +-----------------
 1 file changed, 1 insertion(+), 17 deletions(-)

diff --git a/fs/exfat/inode.c b/fs/exfat/inode.c
index 55984585526e..b714d242b238 100644
--- a/fs/exfat/inode.c
+++ b/fs/exfat/inode.c
@@ -156,27 +156,11 @@ static int exfat_map_cluster(struct inode *inode, unsigned int clu_offset,
 			else
 				*clu += clu_offset;
 		}
-	} else if (ei->type == TYPE_FILE) {
+	} else {
 		int err = exfat_get_cluster(inode, clu_offset,
 				clu, &last_clu);
 		if (err)
 			return -EIO;
-	} else {
-		/* hint information */
-		if (clu_offset > 0 && ei->hint_bmap.off != EXFAT_EOF_CLUSTER &&
-		    ei->hint_bmap.off > 0 && clu_offset >= ei->hint_bmap.off) {
-			clu_offset -= ei->hint_bmap.off;
-			/* hint_bmap.clu should be valid */
-			WARN_ON(ei->hint_bmap.clu < 2);
-			*clu = ei->hint_bmap.clu;
-		}
-
-		while (clu_offset > 0 && *clu != EXFAT_EOF_CLUSTER) {
-			last_clu = *clu;
-			if (exfat_get_next_cluster(sb, clu))
-				return -EIO;
-			clu_offset--;
-		}
 	}
 
 	if (*clu == EXFAT_EOF_CLUSTER) {
-- 
2.43.0


  parent reply	other threads:[~2026-01-08  7:50 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-08  7:49 [PATCH v2 00/13] Enable multi-cluster fetching for exfat_get_block Chi Zhiling
2026-01-08  7:49 ` [PATCH v2 01/13] exfat: add cache option for __exfat_ent_get Chi Zhiling
2026-01-08  7:49 ` [PATCH v2 02/13] exfat: support reuse buffer head for exfat_ent_get Chi Zhiling
2026-01-08  7:49 ` [PATCH v2 03/13] exfat: improve exfat_count_num_clusters Chi Zhiling
2026-01-08  7:49 ` [PATCH v2 04/13] exfat: improve exfat_find_last_cluster Chi Zhiling
2026-01-08  7:49 ` [PATCH v2 05/13] exfat: remove the check for infinite cluster chain loop Chi Zhiling
2026-01-08  7:49 ` [PATCH v2 06/13] exfat: remove the unreachable warning for cache miss cases Chi Zhiling
2026-01-08  7:49 ` [PATCH v2 07/13] exfat: reduce the number of parameters for exfat_get_cluster() Chi Zhiling
2026-01-08  7:49 ` [PATCH v2 08/13] exfat: reuse cache to improve exfat_get_cluster Chi Zhiling
2026-01-08  7:49 ` Chi Zhiling [this message]
2026-01-08  7:49 ` [PATCH v2 10/13] exfat: support multi-cluster for exfat_map_cluster Chi Zhiling
2026-01-13  6:37   ` Yuezhang.Mo
2026-01-13  8:53     ` Chi Zhiling
2026-01-13 10:26       ` Yuezhang.Mo
2026-01-14  3:07         ` Chi Zhiling
2026-01-08  7:59 ` [PATCH v2 11/13] exfat: tweak cluster cache to support zero offset Chi Zhiling
2026-01-08  7:59   ` [PATCH v2 12/13] exfat: return the start of next cache in exfat_cache_lookup Chi Zhiling
2026-01-08  7:59   ` [PATCH v2 13/13] exfat: support multi-cluster for exfat_get_cluster Chi Zhiling

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260108074929.356683-10-chizhiling@163.com \
    --to=chizhiling@163.com \
    --cc=chizhiling@kylinos.cn \
    --cc=linkinjeon@kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sj1557.seo@samsung.com \
    --cc=yuezhang.mo@sony.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®