mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Chi Zhiling <chizhiling@163.com>
To: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Namjae Jeon <linkinjeon@kernel.org>,
	Sungjong Seo <sj1557.seo@samsung.com>,
	Yuezhang Mo <yuezhang.mo@sony.com>,
	Chi Zhiling <chizhiling@kylinos.cn>
Subject: [PATCH v2 05/13] exfat: remove the check for infinite cluster chain loop
Date: Thu,  8 Jan 2026 15:49:21 +0800	[thread overview]
Message-ID: <20260108074929.356683-6-chizhiling@163.com> (raw)
In-Reply-To: <20260108074929.356683-1-chizhiling@163.com>

From: Chi Zhiling <chizhiling@kylinos.cn>

The infinite cluster chain loop check is not work because the
loop will terminate when fclus reaches the parameter cluster,
and the parameter cluster value is never greater than
ei->valid_size.

The following relationship holds:
'fclus' < 'cluster' ≤ ei->valid_size ≤ sb->num_clusters

The check would only be triggered if a cluster number greater than
sb->num_clusters is passed, but no caller currently does this.

Signed-off-by: Chi Zhiling <chizhiling@kylinos.cn>
---
 fs/exfat/cache.c | 10 ----------
 1 file changed, 10 deletions(-)

diff --git a/fs/exfat/cache.c b/fs/exfat/cache.c
index 61af3fa05ab7..0ee4bff1cb35 100644
--- a/fs/exfat/cache.c
+++ b/fs/exfat/cache.c
@@ -238,8 +238,6 @@ int exfat_get_cluster(struct inode *inode, unsigned int cluster,
 		unsigned int *last_dclus, int allow_eof)
 {
 	struct super_block *sb = inode->i_sb;
-	struct exfat_sb_info *sbi = EXFAT_SB(sb);
-	unsigned int limit = sbi->num_clusters;
 	struct exfat_inode_info *ei = EXFAT_I(inode);
 	struct exfat_cache_id cid;
 	unsigned int content;
@@ -279,14 +277,6 @@ int exfat_get_cluster(struct inode *inode, unsigned int cluster,
 		return 0;
 
 	while (*fclus < cluster) {
-		/* prevent the infinite loop of cluster chain */
-		if (*fclus > limit) {
-			exfat_fs_error(sb,
-				"detected the cluster chain loop (i_pos %u)",
-				(*fclus));
-			return -EIO;
-		}
-
 		if (exfat_ent_get(sb, *dclus, &content, NULL))
 			return -EIO;
 
-- 
2.43.0


  parent reply	other threads:[~2026-01-08  7:50 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-08  7:49 [PATCH v2 00/13] Enable multi-cluster fetching for exfat_get_block Chi Zhiling
2026-01-08  7:49 ` [PATCH v2 01/13] exfat: add cache option for __exfat_ent_get Chi Zhiling
2026-01-08  7:49 ` [PATCH v2 02/13] exfat: support reuse buffer head for exfat_ent_get Chi Zhiling
2026-01-08  7:49 ` [PATCH v2 03/13] exfat: improve exfat_count_num_clusters Chi Zhiling
2026-01-08  7:49 ` [PATCH v2 04/13] exfat: improve exfat_find_last_cluster Chi Zhiling
2026-01-08  7:49 ` Chi Zhiling [this message]
2026-01-08  7:49 ` [PATCH v2 06/13] exfat: remove the unreachable warning for cache miss cases Chi Zhiling
2026-01-08  7:49 ` [PATCH v2 07/13] exfat: reduce the number of parameters for exfat_get_cluster() Chi Zhiling
2026-01-08  7:49 ` [PATCH v2 08/13] exfat: reuse cache to improve exfat_get_cluster Chi Zhiling
2026-01-08  7:49 ` [PATCH v2 09/13] exfat: remove handling of non-file types in exfat_map_cluster Chi Zhiling
2026-01-08  7:49 ` [PATCH v2 10/13] exfat: support multi-cluster for exfat_map_cluster Chi Zhiling
2026-01-13  6:37   ` Yuezhang.Mo
2026-01-13  8:53     ` Chi Zhiling
2026-01-13 10:26       ` Yuezhang.Mo
2026-01-14  3:07         ` Chi Zhiling
2026-01-08  7:59 ` [PATCH v2 11/13] exfat: tweak cluster cache to support zero offset Chi Zhiling
2026-01-08  7:59   ` [PATCH v2 12/13] exfat: return the start of next cache in exfat_cache_lookup Chi Zhiling
2026-01-08  7:59   ` [PATCH v2 13/13] exfat: support multi-cluster for exfat_get_cluster Chi Zhiling

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260108074929.356683-6-chizhiling@163.com \
    --to=chizhiling@163.com \
    --cc=chizhiling@kylinos.cn \
    --cc=linkinjeon@kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sj1557.seo@samsung.com \
    --cc=yuezhang.mo@sony.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®